aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Poll

Shall extension icon be added next to filename like azureus does?

Yes
- 6 (66.7%)
No
- 3 (33.3%)

Total Members Voted: 8


Pages: 1 [2]

Author Topic: Add extension icon next to filename like azureus does  (Read 11722 times)

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Add extension icon next to filename like azureus does
« Reply #15 on: May 06, 2007, 03:13:38 PM »

... w00t?
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Add extension icon next to filename like azureus does
« Reply #16 on: May 06, 2007, 05:19:07 PM »

lfroen, you cannot always extract icons from the shell. For example, my solaris box runs CDE, it has no other window manager...how do you extract CDE's icons? and what about fluxbox? enlightenment? windowmaker, etc? dont' think only about GNOME and KDE please. Using embbeded icons would be fine for me :)

Regards.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Add extension icon next to filename like azureus does
« Reply #17 on: May 07, 2007, 04:33:39 AM »

IMHO match more useful is to have such icons on shared files list, and not on downloads.
Well, it is probably a matter of personal taste, I rarely use the shared folder tab. Why not have it in both places?

Also, icons must not be hardcoded, but extracted from shell in run-time.
I agree, but how can we do that? Remember we are supposed to be platform independent, so assuming things here like gtk+ is not an option. Anyway, just my curiosity, do you have a code example that does it?

Cheers!
« Last Edit: May 07, 2007, 04:35:51 AM by phoenix »
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Add extension icon next to filename like azureus does
« Reply #18 on: May 07, 2007, 04:53:07 AM »

Maybe use a code similar to the aMule skins for these icons? a skin could even be extended to include these icons, perhaps...I would like that option. That way, lfroen would be kindda happy (no hardcoded icons), but the app would not relay on some software being present to extract the icons.

Regards.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Add extension icon next to filename like azureus does
« Reply #19 on: May 07, 2007, 06:09:21 AM »

skolnick,

Treviño is working on a patch that could fit your suggestion: http://forum.amule.org/index.php?topic=12588

He is centralizing the replicated code, so it would be easier to implement what you said.

Cheers!
Logged

lfroen

  • Guest
Re: Add extension icon next to filename like azureus does
« Reply #20 on: May 07, 2007, 04:40:31 PM »

Also, icons must not be hardcoded, but extracted from shell in run-time.
I agree, but how can we do that? Remember we are supposed to be platform independent, so assuming things here like gtk+ is not an option. Anyway, just my curiosity, do you have a code example that does it?
Cheers!

I have no idea how to do it, I just pointed out what functionality should it have. You see, if .avi have some particular icon in Nautilus/Konqueror/Explorer, aMule should show the same icon exactly, or it will be counter-productive (instead of suggesting file type by known icon it will confuse by unknown one).
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Add extension icon next to filename like azureus does
« Reply #21 on: May 08, 2007, 04:48:51 AM »

I have no idea how to do it, I just pointed out what functionality should it have. You see, if .avi have some particular icon in Nautilus/Konqueror/Explorer, aMule should show the same icon exactly, or it will be counter-productive (instead of suggesting file type by known icon it will confuse by unknown one).
I get your point and I agree. The system graphic shell should have a suggestion for the icon of a file. Have a look at this:

http://www.wxwidgets.org/manuals/stable/wx_wxmimetypesmanager.html

http://www.wxwidgets.org/manuals/stable/wx_wxfiletype.html#wxfiletypegeticon

Cheers!
« Last Edit: May 08, 2007, 04:58:45 AM by phoenix »
Logged

Treviño

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 50
    • http://italy.copybase.ch/blog/
Re: Add extension icon next to filename like azureus does
« Reply #22 on: May 08, 2007, 05:20:39 AM »

http://www.wxwidgets.org/manuals/stable/wx_wxfiletype.html#wxfiletypegeticon
Latest seems cool, maybe it would allow to satisfy every taste, since it will allow to support both native icons for KDE/GNOME/Mac/Windows users and other amule-defined pixmaps shared with the mule itself...

lfroen

  • Guest
Re: Add extension icon next to filename like azureus does
« Reply #23 on: May 08, 2007, 09:10:12 AM »

lfroen, you cannot always extract icons from the shell.

Oh, really? Let me share little secret with you. User don't give a flying fsck how you do it. It's one of UI design guidelines - CONSISTENCY. K3B, for example, shows icons just fine. And so should aMule. As others pointed out, WX provide such support, so no reason it will not be used if such feature desired.

And regarding your appeal to different window managers - that's completely irrelevant. Major distribution targeting regular users use either KDE or Gnome or both. If you happens to run windowmaker, may be your don't need icons at all.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Add extension icon next to filename like azureus does
« Reply #24 on: May 09, 2007, 06:02:46 AM »

lfroen, you cannot always extract icons from the shell.
Oh, really? Let me share little secret with you. User don't give a flying fsck how you do it. It's one of UI design guidelines - CONSISTENCY.
No need to be sarcastic. I am well aware of consistency as a good example of UI design. I was just pointing that there is no standard way of showing always the shell icons. I am pretty sure no library can do that, it's why I suggested using the icons embedded in the skin, or something like that. But since you seem to love consistency, then I want my CDE icons shown on aMule. I like them ;)
K3B, for example, shows icons just fine.
Terrible example, lfroen. K3b relies on KDE, and it will always show KDE's icons, no matter what. Consistency? tell that to a k3b user on GNOME. It will not show his favorite icons, but KDE ones.

And regarding your appeal to different window managers - that's completely irrelevant. Major distribution targeting regular users use either KDE or Gnome or both. If you happens to run windowmaker, may be your don't need icons at all.
OK, so now you tell me I have no freedom of choice. If I choose another window manager, then I should have no icons simply because you are not allowed to receive suggestions from anyone. Yours is the last word. It seems no fair, UNIX and linux is about freedom to choose. I should be able to get icons no matter what WM I use. However, you seem to care very little about people who thinks different from you (i.e: uses a non-bloated WM).

Regards.
« Last Edit: May 09, 2007, 06:04:17 AM by skolnick »
Logged

lfroen

  • Guest
Re: Add extension icon next to filename like azureus does
« Reply #25 on: May 09, 2007, 08:37:08 AM »

Quote
I was just pointing that there is no standard way of showing always the shell icons. I am pretty sure no library can do that,
As phoenix already told, Wx library can do it. Didn't check this personally thou.

Quote
I want my CDE icons shown on aMule.
And I want pony on my birthday. Both things have similar probability to happen. Does it mean that I have to throw away my dog too? No. I can't have a pony, but the dog stays. Same here: even if CDE isn't supported - it doesn't mean that Gnome should not be supported too.

Sarcasm aside: If CDE works with freedesktop's standards - you will have your icons.

Quote
OK, so now you tell me I have no freedom of choice.
No, what I actually tell you is that choice have price. Your choice of non-standard window manager may have a price of amule-without-pretty-icons (or hard-coded in skin icons, depends on implementation).

Quote
It seems no fair, UNIX and linux is about freedom to choose.
Yes. And no choice comes without price.

Quote
However, you seem to care very little about people who thinks different from you
Let's keep this discussion focused on actual issue (icons in amule). Now, it's not about "care" - it's about what should I fix/implement in very little time I have for amule. And I prefer to fix things that more people need.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Add extension icon next to filename like azureus does
« Reply #26 on: May 09, 2007, 03:34:17 PM »

good lfroen, now your reply makes much more sense, so you are just using freedesktop's standards, it seems fair. I think that's what wx uses too. Unfortunately, as you say, CDE is older than freedesktop :P. I like the into-skin icons more tough...:D

Quote
it's about what should I fix/implement in very little time I have for amule. And I prefer to fix things that more people need.
I agree with you, lfroen. Then let's keep this icon stuff low-priority, at least while we have issues with big files (bigger than 4GB) on aMule. It seems in some places info is misreported (I've made some bug reports, and can help you testing if yu want to).

Regards.
Logged

Treviño

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 50
    • http://italy.copybase.ch/blog/
Re: Add extension icon next to filename like azureus does
« Reply #27 on: September 03, 2007, 06:58:13 PM »

Has this thread stopped?

I've tested some latest version of FileZilla (it is writte in wxwidgets too) and supports many system Icons I've...  Is it using the wx feature suggested by phoenix (I've not had time to check)?

Btw, why has this "trashed"?

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Add extension icon next to filename like azureus does
« Reply #28 on: September 03, 2007, 08:41:52 PM »

Please create a bug report (http://bugs.amule.org), I'll have a look at it after the release of 2.2.0.
Logged
Pages: 1 [2]