aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Sent copies column in Shared files tab  (Read 4001 times)

eisa01

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 100
Sent copies column in Shared files tab
« on: November 17, 2007, 08:59:05 PM »

I would love to have a column that shows how many times you have uploaded a complete copy of the file to the network. That gives me IMHO much more information than what the total upload is. This is a feature I miss from the overnet, eDonkey2000 clients that MetaMachine released.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Sent copies column in Shared files tab
« Reply #1 on: November 17, 2007, 11:18:02 PM »

I am not saying that it will or will not be implemented, but from the p2p client point of view, this is not relevant. If you share a file, pehaps you will only upload the first chunk of it all of your life, but others in the network will complete the rest, so in theory you have never uploaded the file completely, though you might have transferred dozens of  times more bytes than the size of the file. I really would not even know how to compute this number.

Cheers!
Logged

eisa01

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 100
Re: Sent copies column in Shared files tab
« Reply #2 on: November 18, 2007, 12:36:13 PM »

It isn't supposed to keep track of what chunks it has sent. It's basically (amount transferred)/filesize. I just find it easier, and more informative to know how many copies I've sent out, than the total transferred size.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Sent copies column in Shared files tab
« Reply #3 on: November 18, 2007, 01:13:46 PM »

Hi eisa01,

The information (amount transferred)/filesize can be displayed. I have not looked at the code, but in the worst case would involve creating a new tag in know.met to accumulate the statistics on a per file basis.

If I am not mistaken, this file is kept compatible with eMule, and in that case it would be a bad idea to mess with it. Do you know if there is any documentation (besides source code) for this file? Maybe the corresponding tag even exists, but we just don't use it.

Cheers!
Logged

eisa01

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 100
Re: Sent copies column in Shared files tab
« Reply #4 on: November 18, 2007, 02:06:22 PM »

Sorry, I don't really know a lot about this stuff.

But does it really need to be stored? I don't see a problem with just calculating it and storing it in memory for every file.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Sent copies column in Shared files tab
« Reply #5 on: November 18, 2007, 03:43:23 PM »

Hi again,

No, it does not need to be stored, but in case it is not, you loose your statistics every time aMule shutsdown. Doing so in a per session basis should be very easy.

There is just one problem now :) Adding a column to the display breaks configuration file compatibility, I once wanted to add a column, but Kry "pulled my ears" because the code I wanted to commit would not keep compatibility. Unfortunately, I don't have time to hack into this, I would happily break this compatibility because it would be a one time break, but hey, I am not the boss :)

So, I hope we hear from Kry.

Cheers!
Logged

eisa01

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 100
Re: Sent copies column in Shared files tab
« Reply #6 on: November 18, 2007, 05:04:45 PM »

Ah, I get what you mean. I'm not so interested in the sent copies in the session, but in the lifetime.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Sent copies column in Shared files tab
« Reply #7 on: December 12, 2007, 01:52:45 PM »

You have "Share Ratio" in the Shared files window long ago. What else do you need?
Logged
concordia cum veritate

eisa01

  • Full Member
  • ***
  • Karma: 0
  • Offline Offline
  • Posts: 100
Re: Sent copies column in Shared files tab
« Reply #8 on: December 13, 2007, 03:29:57 PM »

Oh, you're right.

Nice :)
Logged