aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Friend slot not working  (Read 3504 times)

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Friend slot not working
« on: June 28, 2009, 11:07:56 PM »
I just noticed that the friend slot in aMule doesn't seem to work.

I gave a friend slot to a fellow and he received a high rating (and score) and became the first on the upload queue.
However after the upload of 10.0 MB finished, he got back into the queue and his rating went back to normal, like I didn't give him a friend slot at all.
Checking the friend slot status in the "Messages" section revealed, that the slot was still active.

Why did the friend slot lose its effect after uploading only one part?
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Friend slot not working
« Reply #1 on: June 28, 2009, 11:45:38 PM »
What version are you using?

Please use an SVN revision >= 9675, upload kicking logic was heavily reworked there.
Logged
concordia cum veritate

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: Friend slot not working
« Reply #2 on: June 29, 2009, 09:27:35 AM »
This happens with SVN 9675.
Logged

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 570
Re: Friend slot not working
« Reply #3 on: June 29, 2009, 12:43:26 PM »
...here it works!
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Friend slot not working
« Reply #4 on: June 29, 2009, 11:15:33 PM »
Should not happen.
Add some debug messages and get to the core of the problem.  :)
I'd guess the friendslot itself gets lost somehow. I doubt a friendslot can be kicked with current SVN.
Or he misbehaved, asked for a non-available part of the file or such, and got disconnected.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: Friend slot not working
« Reply #5 on: June 30, 2009, 06:32:07 AM »
I have upgraded to SVN 9692 and tried it another time.
Worked well. The "friend" stood in the upload queue after 10.0 MB had been transferred. :)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Friend slot not working
« Reply #6 on: June 30, 2009, 10:02:23 PM »
No change in between (except that it doesn't crash anymore if you cancel an uploading download).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon