Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[lionel77]

I think it would be really helpful to include the corresponding file name in the "Expected part-hash ..." messages in the log. The way the setup is now, you just get a ton of these Expected/Actual part-hash messages and it's very tedious to figure out to which files they belong.

Since the messages always come in pairs, it's probably sufficient to only include the file name in the "Expected..." message and not the "Actual..." message. Plus, for long file names this would introduce less clutter.

So the messages could look something like this:

Code: [Select]

2005-11-06 13:39:08: Expected part-hash: ABCABCABCABCABCABCABCABCABCABCAB (File.I.am.downloading.zip)
2005-11-06 13:39:08: Actual part-hash: DFEDFEDFEDFEDFEDFEDSFEDFEDFEDFED

[Xaignar]

It shouldn't even be shown unless CPartFile-debugmsgs are enabled.

[lionel77]

I didn't realize this. But don't you think it would be informative to the user to have these messages? The "Downloaded part xx is corrupt in file: SomeFile.zip" messages show up rather rarely, so I feel like the user is not getting a good idea about the amount of corruption that is encountered. Plus, if you are trying to identify the culprits for banning them in your firewall, the frequent part hash messages are much more helpful (once you figured out to which file they belong) than the occasional "Downloaded part ..." messages.

[spiorf]

you just get a ton of these Expected/Actual part-hash messages

but those messages don't give you an idea about the amount of corruption, because if you get a wrong bit at the end of a chunk (about 9 MB), those messages will pop up until you redownload almost  the whole chunk. You can see exactly how AICH works here http://www.amule.org/wiki/index.php/AICH
And if you need to know the file name of an hash, you can use http://stats.razorback2.com/

The "Downloaded part xx is corrupt in file: SomeFile.zip" messages show up rather rarely,

I think it is a GOOD thing, this is the message that can show you the real amount of corruption you get.