aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: Charset Support  (Read 10513 times)

pochu

  • Approved Newbie
  • *
  • Karma: 4
  • Offline Offline
  • Posts: 34
Charset Support
« on: March 06, 2007, 01:59:05 PM »

Hello everybody!

This is my first message in this community, so be polite with me! :D

I have discussed this with Kry on IRC. What I am asking for is for all charset support. The problem is the next:
Actually, when a file is downloaded, it is created in Incoming/ as ISO-8859-1

This is the Ubuntu bug report:
https://launchpad.net/ubuntu/+source/amule/+bug/40238

Talking with Kry:
<Kry>   static wxCSConv aMuleConv(wxT("iso8859-1"));
<Kry>   tht's on StringFunctions.h

...

<Kry>   ok
<Kry>   change the line you changed in your build
<Kry>   to
<Kry>   static wxCSConv aMuleConv(wxConvLocal);
<Kry>   and try then.

I tried that, and it worked really fine. So this is my suggestion:
Can this be included in the CVS source tree, so it is included in aMule 2.2.0?

If you want me to test it, I will do it :)

Thanks for your work
Pochu
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #1 on: March 07, 2007, 12:34:38 PM »

Hi Pochu,

Before I do that, I want you to do a test for me. Using this patch, create a folder whose name is a valid iso-8859-1 string and try to share it with aMule. Please report the result.

Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Charset Support
« Reply #2 on: March 07, 2007, 12:48:46 PM »

I didn't say I aprove of the change, just FYI. It has to be carefuly considered.
Logged

pochu

  • Approved Newbie
  • *
  • Karma: 4
  • Offline Offline
  • Posts: 34
Re: Charset Support
« Reply #3 on: March 07, 2007, 07:42:01 PM »

Kry, I haven't said you approved it ;) but I would like you to consider it :D

Hi Pochu,

Before I do that, I want you to do a test for me. Using this patch, create a folder whose name is a valid iso-8859-1 string and try to share it with aMule. Please report the result.

Phoenix: my system is entirely utf-8, so I don't know how to create an iso folder (if that's what you want me to do). Or do you want me to create a folder with a valid iso name (such us "valid" hehe) and test it?

I tested with the normal Incoming/ folder, but I can test with whatever you need. But please, specify it :D

Thanks
Emilio
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #4 on: March 09, 2007, 05:28:01 AM »

Hi Emilio,

Do something like that:

$ mkdir $'espa\xf1a'

then try to share this directory.
Logged

pochu

  • Approved Newbie
  • *
  • Karma: 4
  • Offline Offline
  • Posts: 34
Re: Charset Support
« Reply #5 on: March 09, 2007, 10:20:39 AM »

Hello.

I've tried that.

First, the folder, in Nautilus (gnome) is displayed as espa?a
I have compiled amule cvs with that change, and with wx2.8.1.

I can't share the folder, because it isn't displayed. Well, it is displayed, but it hasn't a name. And also, I've created a subdirectory inside espa?a called "testing", to see if I could share it, and this is what happens (attachment).

Please tell me if I can do anything else to get this working.

Best regards
Emilio
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #6 on: March 10, 2007, 01:12:06 AM »

Hi pochu,

Please try this patch and report.
Logged

pochu

  • Approved Newbie
  • *
  • Karma: 4
  • Offline Offline
  • Posts: 34
Re: Charset Support
« Reply #7 on: March 10, 2007, 01:36:30 AM »

You ROCK!
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #8 on: March 14, 2007, 04:27:36 AM »

New version of the patch. One less bug  ;D
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #9 on: March 17, 2007, 05:14:44 AM »

Last version of the patch. This one is against current CVS (tomorrow). Has many bug fixes and has been tested for a week.
Please test.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #10 on: March 19, 2007, 11:44:44 PM »

Well, it just does not work always. wxStat is foobarred. I'll have to try a work around, which is to use the present code as a fallback.  :(
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Charset Support
« Reply #11 on: March 20, 2007, 12:30:52 AM »

TOLD YOU
TOLD YOU
TOLD YOU x many times (cut for readability)
« Last Edit: March 21, 2007, 05:33:46 AM by wuischke »
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #12 on: March 20, 2007, 11:32:24 AM »

Lol!  ;D

But I found another way, just wait... And this time I will use no fallback. ::)
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Charset Support
« Reply #13 on: March 21, 2007, 12:47:31 AM »

Pochu, please try this one! Notice that you HAVE to run ./autogen.sh, because this patch changes one Makefile.am and your configure script will be wrong.

Kry, this one is definitive  8) And fixes wxStat behaviour.
« Last Edit: March 21, 2007, 02:44:18 AM by phoenix »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Charset Support
« Reply #14 on: March 21, 2007, 02:25:43 PM »

We'll see about that
Logged
Pages: [1] 2