Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Kry]

we don't lose portability, we use fopen and then associate the FILE* to a wxFFile object and use it like we're doing now.

[phoenix]

Everybody, please test tomorrow svn tarball. Xaignar has probably fixed this issue.

[mr_hyde]

Just tried with amule and amuled, Incoming and Temp on a NTFS partition (mounted by ntfs-3g). Everything seems to work correctly!
Thanks again for your marvellous job!

EDIT:  I forgot to report my locale settings: en_US.utf8 and ntfs-3g partitions mounted with options "locale=en_US.utf8"

Bye,
  Mr Hyde

[macias]

I tested 20080205 version and comparing it to patched (ConvAmule) 20071226 I would say it is a regression -- no matter what I do (*), I don't see Polish characters.

(*) LANG=en_EN or LANG=pl_PL.ISO-8859-2  (I use ISO-8859-2 characters in filenames)

In 20071216 (but only patched!) Polish characters are displayed 100% correctly.

[wuischke]

If I'm not mistaken, this is intended behaviour.

We use only Unicode now, so you'll get a misdisplay, but at least all the filenames should be written correctly to disk. It would be preferable to use Unicode on your system, too, but iirc you stated some reasons not to use Unicode earlier.

Keep in mind that I haven't read the code after the changes yet, so I could be wrong about what I say.

[macias]

We use only Unicode now, so you'll get a misdisplay, but at least all the filenames should be written correctly to disk.

It is impossible by definition? Unicode can be properly written if the FS is Unicode. If it is not, and any conversion is not done there is no change (i.e. filenames will be written incorrectly).

imho amule should take LANG into account because it is quite good indicator how the system is set.

[phoenix]

macias,

Xaignar is now looking at your issue and it will be fixed. Please test and report your results after he says it is committed.

Cheers!

[Xaignar]

We use only Unicode now, so you'll get a misdisplay, but at least all the filenames should be written correctly to disk.

It is impossible by definition?

No, the problem with not displaying the Polish chars is because of a bug in the demangling routines used for printing. The filename strings used when actually accessing the filesystem are not affected by this problem. In any case, I've commited a fix, so that these routines should now use the system locale when possible, instead of ISO-8859-1, which was the previously hardcoded fallback.

[macias]

No, the problem with not displaying the Polish chars is because of a bug in the demangling routines used for printing. The filename strings used when actually accessing the filesystem are not affected by this problem. In any case, I've commited a fix, so that these routines should now use the system locale when possible, instead of ISO-8859-1, which was the previously hardcoded fallback.

I downloaded 20080206 SVN and all filenames with Polish characters are now displayed 100% properly. THANK YOU!

[Xaignar]

I downloaded 20080206 SVN and all filenames with Polish characters are now displayed 100% properly. THANK YOU!

Glad to hear it, and appologies for the oversight on my part.