aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: why automatic change of search entry when changing the tab?  (Read 7262 times)

yelo3

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
why automatic change of search entry when changing the tab?
« on: March 20, 2010, 09:41:16 PM »

As requested in the related bug [1], I'm wondering why when you change the search tab, the text entry is changed automatically.
I find that emule has a slightly better way to do it: a right click context menu entry called "restore search parameters".
To continue to fix the bug, Sturedman needs to know if this is an error or a wanted behavior, and eventually (if in the second case) if this can be overridden as in amule

[1]: http://bugs.amule.org/view.php?id=1534
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: why automatic change of search entry when changing the tab?
« Reply #1 on: March 22, 2010, 07:53:42 PM »

Just remove the lines from 270 to 288 in SearchDlg.cpp.
I guess this can't be made permanent because the GUI is - arghhh - locked.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: why automatic change of search entry when changing the tab?
« Reply #2 on: March 22, 2010, 08:20:36 PM »

Not for long, actually, and that's good news. I'm pretty much done, but not ready tu push it forward yet.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: why automatic change of search entry when changing the tab?
« Reply #3 on: March 22, 2010, 08:25:34 PM »

Sturedman needs to know if this is an error or a wanted behavior
Question is: does anybody still want this feature? If not I'd just kick it. We could make it configurable of course, but I think that's a bit overdoing things for a little detail like that.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: why automatic change of search entry when changing the tab?
« Reply #4 on: March 23, 2010, 12:00:15 PM »

I like that feature. If I have 3 searches with no results, I can come back, select the tab with the old search and just restart it without further work. And if another search is needed, I just can cick "Clean fields".
If you change the behaviour of the search, clean fields button isn't needed anymore, so you could reuse this button for copying search parameters of current tab.
Logged
Homefucking is killing prostitution

yelo3

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: why automatic change of search entry when changing the tab?
« Reply #5 on: March 23, 2010, 12:09:54 PM »

I instead don't like the feature, because if you type something in the search filed, and then change tab (for example because you have to consult more search results), it will be overwritten.
Maybe we can achieve a compromise, and overwrite the search field only if the user didn't type on it.
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: why automatic change of search entry when changing the tab?
« Reply #6 on: March 23, 2010, 12:39:14 PM »

Would be possible, but what if the user starts to type a long search term, and then remembers that a search for this is already there and clicks on the tab to get the text without typing?

Maybe you should just finish one thing (writing and starting search) before you do something else. You consult your results while you're waiting for the new search to finish.
Logged
Homefucking is killing prostitution

yelo3

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: why automatic change of search entry when changing the tab?
« Reply #7 on: March 23, 2010, 12:45:39 PM »

Would be possible, but what if the user starts to type a long search term, and then remembers that a search for this is already there and clicks on the tab to get the text without typing?
he cleans what he's written, and switch the tab, so the entry is overwritten.
Anyway I really don't see the point of starting again a search that has already been completed. Can you better explain?

Maybe you should just finish one thing (writing and starting search) before you do something else. You consult your results while you're waiting for the new search to finish.
It might happen (actually it happens lots of time in my case) that while you are writing, you must consult the other results to affine the search query.
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: why automatic change of search entry when changing the tab?
« Reply #8 on: March 23, 2010, 01:02:02 PM »

Would be possible, but what if the user starts to type a long search term, and then remembers that a search for this is already there and clicks on the tab to get the text without typing?
he cleans what he's written, and switch the tab, so the entry is overwritten.
Anyway I really don't see the point of starting again a search that has already been completed. Can you better explain?

When you start aMule and immediately start a search, you are most likely connected to just a few nodes, which for sure give you less results. If you start the same search after some time again, you'll get in most cases more results with exactly the same searchterm.

Maybe you should just finish one thing (writing and starting search) before you do something else. You consult your results while you're waiting for the new search to finish.
It might happen (actually it happens lots of time in my case) that while you are writing, you must consult the other results to affine the search query.

Sure, that's the case when you get too much results. This feature is only usefull if you get no or not enough or no good results.  But if you want to reduce the search results for term "A", it's not usefull to switch on the tab of "B" which doesn't contain the saerchterm you want to adjust. In most cases you go to tab of "A C" or "A D" maybe to combine them to "A C D", so in this case the feature is still usefull. Or maybe you want to adjust your search to "A B", in this case you have to type either "A" or "B" (or just copy them, for what you still need it to be in the text field). In this case I would like to switch to the tab that contains the longer part and just retype the shorter one.

In any case (given that you use an OS that supports it), you can just mark your term, examine as many tabs as you wish, then click "Clean Fields" (or just keep the tab you want to expand) and then middle-click to get the marked text in there.

Otherwise, if the text wouldn't be taken, you have either to retype the whole term (like for a new, not related search), or if there would be a button to copy the text, you would have to go to the tab, copy the text to the field, makr or copy the text, go to the next tab, copy it again, just to insert the old one.

So you see, current way and your proposed way have the exact opposite targets. And as current way doesn't mean more work than your proposed way in case of the not targetted task than the other around, current way is better as default.
Logged
Homefucking is killing prostitution

yelo3

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: why automatic change of search entry when changing the tab?
« Reply #9 on: March 23, 2010, 01:34:02 PM »

Since this feature can help you only in the first minute, it shouldn't affect the whole execution time.
Anyway I've just executed a (maybe too simple) test searching for the same term:
- after 10 minutes running: 16 results
- after 5 seconds running: 16 results (the first result had 100 less sources, but the other ones were very near)

Another approach might be repeating the search at intervals until the number of results is satisfactory.
Since I have lots of ideas today, I can propose also a button next to the tab "x", or a right click option called "refresh results" if the button is not achievable. And this is really better than current behavior because it doesn't open a new tab, and less intrusive because it does not change the search term.
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: why automatic change of search entry when changing the tab?
« Reply #10 on: March 24, 2010, 09:42:21 AM »

The group-box at the top defines a new search. The results below show the matched files.

I would also prefer a context menu for the search tabs that lets you repeat the search with all the options that were selected.

It doesn't really make sense to overwrite the entered text if a tab is selected, because there are other options as well and they don't get restored either.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: why automatic change of search entry when changing the tab?
« Reply #11 on: March 25, 2010, 02:32:37 PM »

I'd go with marcell's. Also, a drop-down for the text control could store all previously executed searches, so you could easily select if you want to replace the contents of the text control with a previous term.
Logged
concordia cum veritate

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: why automatic change of search entry when changing the tab?
« Reply #12 on: March 29, 2010, 08:52:45 AM »

I'd go with marcell's. Also, a drop-down for the text control could store all previously executed searches, so you could easily select if you want to replace the contents of the text control with a previous term.
Sounds like a very good idea to me. Can we have this as part of the GUI upgrade? ::)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: why automatic change of search entry when changing the tab?
« Reply #13 on: March 29, 2010, 06:23:35 PM »

After rather. Don't give Kry more excuses to delay it further.
Since you already have some good ideas about it I have assigned it to you, if you don't mind.  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: why automatic change of search entry when changing the tab?
« Reply #14 on: March 30, 2010, 12:13:15 PM »

After rather. Don't give Kry more excuses to delay it further.
Since you already have some good ideas about it I have assigned it to you, if you don't mind.  :)

Ahmm, ahmmm:

...
It's not urgent at all. And I want to repeat - it's not an assignment (we don't do that here), just an idea of a feature requested by a user which could be useful.

But to answer you question: I don't mind it. ;)
Logged