aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 2 [3]

Author Topic: Tab selection in Mac OS X  (Read 14127 times)

leio

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 3
    • http://www.wxwidgets.org/
Re: Tab selection in Mac OS X
« Reply #30 on: August 04, 2006, 09:24:48 PM »

Switching to wx version was done with the CVS log message
"Log: fix for sf bug 1448153: Widgets sample hangs on Japanese radio label"
https://sourceforge.net/tracker/index.php?func=detail&aid=1448153&group_id=9863&atid=109863

That was done March 17th.

On 28th May the wxVsnprintf implementation got added positional parameter support, but the log message says it's disabled at that point. However, I fail to find any #if 0 or anything that would actually disable that stuff.
I wonder if a checkout between 18th March and 27th May works fine.
Keep in mind that I haven't read the whole thread, if some dates have already been mentioned.
Logged
Compilers: gcc-3.3.6, gcc-3.4.5, gcc-4.0.3, gcc-4.1.1; OS: Gentoo Linux; WX: CVS HEAD; aMule: SVN HEAD

Project Manager of wxMUD - http://wxmud.sf.net/
Developer of wxGTK;
Gentoo Linux - wxwindows herd - http://www.gentoo.org/

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #31 on: August 04, 2006, 10:49:21 PM »

Just to avoid confusion, even wx checkouts from right after the vswprintf switch exhibit the same problem, so the issue has probably been in their code for some time.

For now it seems that manually reverting the vswprintf version works just fine for our purposes, but I am wondering if it would be good to get this fixed in wx, so that we won't run into any problems over the long term.

I was thinking about filing a bug report with them, but the problem is "aMule's display of times is screwed up when using wx's version of vswprintf" might not be very insightful to them, and unfortunately my understanding of the problem does not go much beyond that. So if somebody who has a better idea of why this is going on could file the report, that would be highly appreciated. :)
Logged
Current aMule CVS builds for OS X can be found here.

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Re: Tab selection in Mac OS X
« Reply #32 on: August 13, 2006, 05:43:53 PM »

Well, it happens with aMule's unit tests ("make check"), too.  Basically, it's the "unsigned long long" format specifier "%ull" that doesn't work properly in wx's wxVsnprintf.  I'm not certain if the "unsigned" is required; it might be that the "long long" format specifier "%ll" is also broken.

EDIT 1: I looked at the wxVsnprintf code a bit.  It's complicated, so I'm not sure I followed it correctly, but I don't think it will work with long long format specifiers on any platform.  The only reason long longs ever print  properly is that the vast majority of platforms use the native library, not wx's implementation (as we've discovered on the Mac).

EDIT 2: Hmm.  I just tried and aMule's unit tests don't compile these days.  Anyway, the problem is as I've described it above.
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #33 on: August 13, 2006, 06:55:42 PM »

Well, I guess if most other platforms use their own vswprintf implementation anyway, maybe we can just keep patching wx so that it uses the one built into OS X.
Logged
Current aMule CVS builds for OS X can be found here.
Pages: 1 2 [3]