aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: 2004-11-18 Global Search broken  (Read 4542 times)

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
2004-11-18 Global Search broken
« on: November 18, 2004, 09:03:10 PM »

global search doesn't work in amule-CVS-20041118. If global search is selected and a search is performed amule disconnects from the server with the message "Unknown exception while processing packet from server!". (Code:
Code: [Select]
} catch (...) {
                AddLogLineM(false, _("Unknown exception while processing packet from server!"));
                SetConnectionState(CS_DISCONNECTED);
                return false;
        }
in ServerSocket.cpp)

global search works fine in cvs-20041115. i will try to track down the cause but someone more proficient might do it faster than me =p
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: 2004-11-18 Global Search broken
« Reply #1 on: November 18, 2004, 10:15:39 PM »

Funny, it works, but only 3 results from each server. Most probably I broke it :)

EDIT: no, it's ok. Works here perfectly, which server are you connected to? Global search is UDP, so should't break on ServerSocket.
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #2 on: November 18, 2004, 10:39:06 PM »

Razorback2. tried with others too. cvs from 2004-11-17 works fine though.
2004-11-18 compiled with exactly the same config options as 2004-11-17 has this global search strangeness. disconnection from the server and about 10 results on a search that yields about 440 results with 2004-11-17.
« Last Edit: November 18, 2004, 10:52:10 PM by volpol »
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #3 on: November 19, 2004, 02:16:12 PM »

i split the diff between 20041117 and 20041118 and applied patches one at a time. the strangeness began after applying UDPSocket+PartFile+DownloadQueue+ServerSocket+SearchList patch.
(i had to apply all five of them because of the specific changes in them)
can it be the changed usage of CSafeMemFile in UDPSocket and others?
e.g.
Code: [Select]
-                               CSafeMemFile* sources = new CSafeMemFile((BYTE*)packet,size);
+                               CSafeMemFile sources((BYTE*)packet,size);
in ServerSocket.cpp
thanks for your attention
Logged

realcruncher

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 46
Re: 2004-11-18 Global Search broken
« Reply #4 on: November 19, 2004, 04:28:34 PM »

Is it possible that something with UDP is wrong ?
The LowID problem could be because if you disable UDP then amule still seems to use UDP (the starting message says *** UDP socket at 1025).
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: 2004-11-18 Global Search broken
« Reply #5 on: November 19, 2004, 05:17:16 PM »

Kry has just rewritten the UDP code. please test tonight's cvs tarball :)

Greetings!
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #6 on: November 22, 2004, 05:29:41 PM »

still no luck with amule-cvs-20041122
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: 2004-11-18 Global Search broken
« Reply #7 on: November 22, 2004, 05:33:42 PM »

volpop, it works everywhere alse :-/ are you sure you have your UDP port forwareded in your router?
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #8 on: November 22, 2004, 05:53:17 PM »

ok, i will assume something is wrong on my side until i can confirm it's not the case.
the funny thing is that 2004-11-17 works: compiled with the same compiler, with exactly the same options and using the same wxGTK. i removed old configuration and reconfigured 2004-11-18 from scratch: no luck. by the way there is no router: i am directly connected.

p.s. am i still volpop!? =)
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: 2004-11-18 Global Search broken
« Reply #9 on: November 22, 2004, 06:03:33 PM »

> p.s. am i still volpop!? =)
damn, sorry, i meant boogiepop

> the funny thing is that 2004-11-17 works
oh.... so you mean that 17 Oct's cvs did work but 18 Oct cvs doesn't? What about cvs versions after 18 Oct?
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #10 on: November 22, 2004, 06:18:29 PM »

Quote
oh.... so you mean that 17 Oct's cvs did work but 18 Oct cvs doesn't? What about cvs versions after 18 Oct?
You mean 17th November, right? because i am talking about this month's cvs here.
i tried cvs from 20th and 22nd: both of them show the same behavior as 18th.
Quote
damn, sorry, i meant boogiepop
ok, NOW i am satisfied.
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: 2004-11-18 Global Search broken
« Reply #11 on: November 22, 2004, 06:33:42 PM »

ok, then it's a bug in cvs. strange no one else has reported :-/

ok, just took a look at cvs commits. the night between the 17th and 18th of Nove was when Kry commited his UDP code rewrite, so something is bugged there,

pollypop, please come into #amule at irc.freenode.net since he might need you to test the global search in various ways in your box (since your the only one with this problem, your the only one who can help hehe).

Thanks in advance :)

Greetings!
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #12 on: November 22, 2004, 06:47:45 PM »

it might be something with my box which was sleeping until now. because it is strange that i am the only one experiencing this strangeness. ok, i've just joined #amule.
Logged

volpol

  • Evil KDE Hater
  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 43
Re: 2004-11-18 Global Search broken
« Reply #13 on: November 23, 2004, 10:16:20 PM »

i found the problem and it was in fact something specific to my setup. i was fooled by the fact that 20041117 worked while 20041118 did not while i haven't changed anything. sorry for all the trouble.
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: 2004-11-18 Global Search broken
« Reply #14 on: November 25, 2004, 01:33:18 PM »

ok, np ;)
Logged