aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Compilation on debian/unstable pb  (Read 3351 times)

oNolYx

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Compilation on debian/unstable pb
« on: May 01, 2004, 12:33:50 PM »

amule doesn't compile on my debian/unstable since "ClientCredits.h:27:37: crypto++/config.h :"  can't be found,
it is actually called crypto++/cryptopp_config.h


The code is
Code: [Select]
#ifdef __CRYPTO_DEBIAN_GENTOO__
        #include
        #include
#else

It has been changed since rc2 in which it was ok.
I don't know if it works with woody but debian users willing to compile rc3 are mainly unstable users, then it would be better this little part works cleanly for them.

I don't know how it is on Gentoo.
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: Compilation on debian/unstable pb
« Reply #1 on: May 01, 2004, 12:41:32 PM »

with super-user (root) priviledges, run `ln -s /usr/include/crypto++/cryptopp_config.h /usr/include/crypto++/config.h`and tehn re-run compilation.
That'll do the trick, or at least it should.
Greetings.
Logged

oNolYx

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Compilation on debian/unstable pb
« Reply #2 on: May 01, 2004, 01:32:52 PM »

Changing the line in ClientCredits.h works well too, but i meant that since this is already a Debian specific bloc in the file it should work without further modification no ?

In another way, why has this line been changed while it worked well before ?
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: Compilation on debian/unstable pb
« Reply #3 on: May 01, 2004, 09:35:43 PM »

Changing that line might work well, but you'll have to change it on every aMule compilation. And not only that, on every source of any app you might want to compile which uses Crypto++ ;-)
It's better if you link, definitly.
About why it worked well before and not now, no idea. I believe now configure detects the type of distro you are on and is able to knwo if your Crypto++ package uses "crypto++" as it's name or "cryptopp" so maybe it's not detecting your distro correctly.

Greetings.
Logged

oNolYx

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Compilation on debian/unstable pb
« Reply #4 on: May 02, 2004, 03:19:24 PM »

Quote
Originally posted by Jacobo221
Changing that line might work well, but you'll have to change it on every aMule compilation. And not only that, on every source of any app you might want to compile which uses Crypto++ ;-)
It's better if you link, definitly.

Ok but since this include is in a #ifdef __CRYPTO_DEBIAN_GENTOO__
i wanted to warn you that this piece of code which is supposed to be debian specific (and gentoo) doesn't work on debian without change, it is a pity...


Quote
About why it worked well before and not now, no idea.

Because before the line was
#include crypto++/cryptopp_config.h
and that reflects how it actually is on a debian/unstable.



I admit that i don't understand why you want to keep a line that is in debian specific bloc (#ifdef __CRYPTO_DEBIAN_GENTOO__) and that is known not to work on debian/unstable....

Ok the file should be called config.h instead of cryptopp_config.h but for the moment it is not the case and produce a compilation error.
Logged

Jacobo221

  • Hero Member
  • *****
  • Karma: 3
  • Offline Offline
  • Posts: 2712
Re: Compilation on debian/unstable pb
« Reply #5 on: May 03, 2004, 10:20:01 AM »

The thing is that this is a bug on the Debian package. THEY have to fix it. Otherwise, we would end up with a code with plenty of #ifdef DEBIAN_CRYPTO-1 #ifdef DEBIAN_CRYPTO-2 ... ;-) In fact, the Debian crypto++ package, untill too weeks ago or so (maybe more) had another bug, but it's fixed now. Obviously the code can't be adapted to other's bugs, but other's bugs HAVE to be addapted to the correct way. ATM, all that can be done is to tell about the link that must be doen to anyone with the same problem on Debian... until the Debian Crypto++ mantainer fixes it.

I hope I made myself clear ;-)
Greetings.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Compilation on debian/unstable pb
« Reply #6 on: May 03, 2004, 11:58:14 AM »

Nah, jacobo, he's right. if we have a workaround, must be a WORKING workaround. Thanks for the report.
Logged

oNolYx

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Compilation on debian/unstable pb
« Reply #7 on: May 03, 2004, 12:25:48 PM »

As far as I am concerned, i think the best is trying to adapt to the main distros, and if something is weird or should be changed, contact the package maintainer to know if (and when) he plans a change.

It is a personal choice but it helps amule users a bit.

I mail him so that we will know why this file is named cryptopp_config.h and not config.h
Logged