aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 [2] 3

Author Topic: [r9364] Nice Percentage  (Read 10367 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #15 on: January 10, 2009, 04:23:53 PM »

Hmm - can't find anything wrong (and can't reproduce it either).
Please make sure
- you are using 9364 for both amule/amuled AND amulegui
- you made a clean build (extracted the tarball to an empty dir before building)

If yes, please disable autoconnect, change your TCP port, and restart aMule. Everything is red, no traffic. Still bad progress bars?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #16 on: January 10, 2009, 06:48:51 PM »

Please try also amule < 9348 with amulegui 9364, and amule 9364 with amulegui < 9348 (protocol wasn't changed), and tell me which combination works/fails. (And both < 9348 for good measure...)
I made some changes to gaplist handling in 9348 in case you wonder.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #17 on: January 10, 2009, 07:20:33 PM »

Please try also amule < 9348 with amulegui 9364, and amule 9364 with amulegui < 9348 (protocol wasn't changed), and tell me which combination works/fails. (And both < 9348 for good measure...)
I made some changes to gaplist handling in 9348 in case you wonder.

Ähm, how should i do this?
I install ONE version with deb.
And i have only one PC not a network of PCs.
My amuled is on the same PC as the GUI or the amule.

I screenshot the aMuleGUI without all sources as you sayed.
(if you test it, dont forget the .seed Files in the /temp/ dir.
Logged

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #18 on: January 10, 2009, 07:28:58 PM »

Same Problem with r9362
Logged

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #19 on: January 10, 2009, 07:37:35 PM »

No Errors in r9328
Logged

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #20 on: January 10, 2009, 07:40:32 PM »

All versions build with this settings:

Code: [Select]
./configure --disable-debug --enable-optimize --disable-ccache  --disable-upnp --disable-xas --enable-alc --enable-alcc --disable-xas --enable-amulecmd --enable-webserver --enable-amule-daemon --enable-amule-gui
Logged

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #21 on: January 10, 2009, 08:02:05 PM »

Here are a few of my .deb but only for Debian/32Bit.

http://rapidshare.com/files/181834312/amule.tar.bz2.html
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #22 on: January 10, 2009, 08:03:54 PM »

Ok, played a bit with it too.
- problem appears to be caused by remotegui only (with old gui it works)
- problem depends on certain files
I added a bunch of files and suddenly could reproduce it. Two files were totally broken in the remotegui and triggered even debug assertions (MD4 == 0). Many others looked full or almost full as in your shot.
After removing these two (which were obvious fakes) the others were fine again too.

I keep digging...  :-\
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #23 on: January 10, 2009, 08:08:52 PM »

I thought its only a display error.
The %tage was ok every time, only the bar was wrong.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #24 on: January 10, 2009, 09:58:35 PM »

Duh.  :-[
Code: [Select]
Index: src/PartFile.cpp
===================================================================
--- src/PartFile.cpp (revision 9365)
+++ src/PartFile.cpp (working copy)
@@ -3562,6 +3562,7 @@
  SetFileName(CPath(tag->FileName()));
  m_abyFileHash = tag->ID();
  SetFileSize(tag->SizeFull());
+ m_gaplist.Init(GetFileSize(), true); // Init empty
  m_partmetfilename = CPath(tag->PartMetName());
  transferred = tag->SizeXfer();
  percentcompleted = (100.0*completedsize) / GetFileSize();

That should do the trick.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #25 on: January 10, 2009, 10:33:44 PM »

Code: [Select]
patching file src/PartFile.cpp
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 3562 with fuzz 1.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #26 on: January 10, 2009, 11:01:17 PM »

Just apply it by hand.   :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #27 on: January 11, 2009, 07:02:58 AM »

Ok, the patch is fixing the error.

Let's compile the newer sources.
In r9369 your fix is included?
Logged

Schuttwegraeumer

  • Sr. Member
  • ****
  • Karma: 2
  • Offline Offline
  • Posts: 421
Re: [r9364] Nice Percentage
« Reply #28 on: January 11, 2009, 10:41:02 AM »

No broken bars seen in r9369
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: [r9364] Nice Percentage
« Reply #29 on: January 11, 2009, 04:02:55 PM »

In r9369 your fix is included?
Yes.

Vielen Dank fürs testen!  :D

Edit: Translation: Thanks a lot for testing!
« Last Edit: January 12, 2009, 03:28:39 PM by wuischke »
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon
Pages: 1 [2] 3