aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: more flexible queue code  (Read 2573 times)

fmoliveira

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 3
more flexible queue code
« on: June 22, 2006, 12:31:56 PM »

I think functions like CUploadQueue::AddUpNextClient could call some other function to compare 2 clients and return wich of them has a bigger score, instead of comparing the integer scores directly.

It would make simpler to mod things like pay-back first, one queue for each file, etc.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: more flexible queue code
« Reply #1 on: June 22, 2006, 03:13:24 PM »

Uh?
Logged

fmoliveira

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 3
Re: more flexible queue code
« Reply #2 on: June 22, 2006, 09:37:23 PM »

I mean, there is a lot of mods, at least in emule, that change the way the queue works.

I like to upload first to people that gave me more than I gave them, before testing their scores. And there is a lot of emule mods that change things like that, like random picking who will get the next upload, instead of a queue, or an individual queue for each file.

Today, each new amule version that gets out, I have to change more than one place to do that, since there is more than one function that compare clientes by score.

These are:
CUploadQueue::AddUpNextClient
CUploadQueue::GetWaitingPosition
CUploadQueue::CheckForTimeOver

The last one is because when transfer full chunks is disabled, the uploading time is based in score. I am ignoring the inteface list sorting because I do it just for myself, but it should also count.

Some emule mods do some ugly hacks to avoid it, like setting the MSB bit of the score value, but its ugly and very limited.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: more flexible queue code
« Reply #3 on: June 23, 2006, 01:27:38 AM »

And we should make your life easier to make modifications to the fairness of the client that we find harmful to the network because... ?
Logged

fmoliveira

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 3
Re: more flexible queue code
« Reply #4 on: June 24, 2006, 05:27:15 AM »

If you really think its unfair to boost rare files, random queues and more aggressive credit systems, then there is nothing to see here.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: more flexible queue code
« Reply #5 on: June 24, 2006, 06:05:31 AM »

there is nothing to see here.
Logged