aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 [2] 3

Author Topic: remember all files ever canceled  (Read 16880 times)

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: remember all files ever canceled
« Reply #15 on: July 22, 2007, 06:07:26 AM »
I just realized that my patch does *not* solve the problem (and had an error in the implementation, but that's only secondary).

aMule already displayed all known files in green, even those which were cancelled. My code just changed the green color to grey and was meant to differ between files still being shared and removed files.

I'll try to have a look at it when I come back from work.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: remember all files ever canceled
« Reply #16 on: July 22, 2007, 07:05:34 AM »
But that will also show in gray the files I downloaded successfully but for some reason I took out of the incoming folder, doesn't it?

Regards.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: remember all files ever canceled
« Reply #17 on: July 22, 2007, 03:06:52 PM »
Yes, that's what I meant when I said cancelled/removed files in an earlier post.

To really resolve this problem are further changes needed, which I won't make before the release of 2.2.0.
Logged

ernestoI

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Re: remember all files ever canceled
« Reply #18 on: December 30, 2009, 01:05:26 AM »
I recently filed http://www.amule.org/abugs/view.php?id=1571 and was asked to make a forum post, I see there is already a thread concerning this so I'll just bump it. I'm wondering can be done about this. I'm unfamiliar with aMule's architecture, but I have a thorough understanding of C++, and the libraries that aMule appears to use, so perhaps if someone was willing to steer me in the right direction I could work on this myself.
Quote
Please start a thread in the forum to discuss the issue. It has been discussed before, but I can't remember the result right now.
To do this you have to store the hashes of the canceled files in a map, save it on shutdown and load it on startup (like the known files in known.met).
Could known.met be used? Where in the source should this be implemented?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: remember all files ever canceled
« Reply #19 on: December 30, 2009, 01:24:47 PM »
First we have to see if everybody agrees on the feature. Then implementation should not be a problem.
known.met should not be touched for reasons of compatibility, but the places where it's read/written are the same where canceled.met (to name it) has to be accessed.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: remember all files ever canceled
« Reply #20 on: January 04, 2010, 12:06:15 AM »
Got it running (at least without EC).
When should the "canceled" status be reset? When the file is downloaded again, or only when it completes download?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: remember all files ever canceled
« Reply #21 on: January 04, 2010, 11:48:24 AM »
When it get's downloaded again. So it has either downloading/finished or cancelled instead of downloading and cancelled.
Logged
Homefucking is killing prostitution

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: remember all files ever canceled
« Reply #22 on: January 04, 2010, 01:15:24 PM »
I'd prefer when it's completed. So if you start a download from a link you have a chance to see it was canceled before.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: remember all files ever canceled
« Reply #23 on: January 04, 2010, 01:25:41 PM »
That was the intention. If it's in cancelled list, mark it on the search somehow. If someone decides to start it again, move into downloading till it's finished or cancelled again. otherwise you'll get told it was cancelled while you are downloading already again.
Logged
Homefucking is killing prostitution

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: remember all files ever canceled
« Reply #24 on: January 04, 2010, 01:57:13 PM »
Quote from: Vollstrecker on January 04, 2010, 01:25:41 PM
If it's in cancelled list, mark it on the search somehow.
That's good, but doesn't help if you add the file from an ed2k link (e.g. by clicking a link in your browser).
Logged
concordia cum veritate

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: remember all files ever canceled
« Reply #25 on: January 04, 2010, 02:06:29 PM »
Sure, but does anything happen when you click a link that is already downloading, or if you click an already finished link? I don't think so, it just keeps downloading or downloads it again, so no disadvantage on that side, but an advantage for users using the search.
Logged
Homefucking is killing prostitution

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: remember all files ever canceled
« Reply #26 on: January 04, 2010, 03:06:47 PM »
Vollstrecker, the idea is to show an ongoing download as "canceled at some time" (maybe in the properties). This is only possible if the canceled state is kept while downloading. If such a download shows as "canceled" or "downloading" in the search view is a different question.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: remember all files ever canceled
« Reply #27 on: January 04, 2010, 03:55:19 PM »
ok, In the properties this is something different. Are we already displaying something like "succesfully downloaded a while ago" there?
Logged
Homefucking is killing prostitution

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: remember all files ever canceled
« Reply #28 on: January 04, 2010, 04:55:33 PM »
I don't think so, but there is a feature request. It's blocked with the GUI atm.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: remember all files ever canceled
« Reply #29 on: January 04, 2010, 04:57:48 PM »
Then it should be implemented all in one. just for consitency.
Logged
Homefucking is killing prostitution
Pages: 1 [2] 3
« previous next »