aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 2 [3] 4 5 ... 7

Author Topic: A new look for aMule 2.2.0  (Read 105479 times)

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: A new look for aMule 2.2.0
« Reply #30 on: November 20, 2007, 04:46:41 PM »

Ok, you are right in the sense that to support all platforms a toolkit is much simpler. But :)

Threads and processess are not really a problem. llibUPnP compiles and works in Windows, Mac, Linux, and other stuff, and they use no toolkit, just pthread support.

Strings could be a problem because std::wstring uses wchar_t, which is not guaranteed to be 32 bits. But again, in any of these platforms is wchar_t different from 32 bits? Look:
Code: [Select]
#include <string>

#include <stdio.h>

int main(void)
{
printf("sizeof (wchar_t) = %zd\n", sizeof (wchar_t));
return 0;
}

output on both x86_64 and i386:
$ g++ -Wall -o t t.cpp
$ ./t
sizeof (wchar_t) = 4
Please, someone test it in windows and Mac.

Filenames are another issue, but we already use a toolkit and filenames are still an issue, so the toolkit hasn't really helped us here.

So, to be quite frank, I do believe you can do it without toolkits. As I said before, there may be some platform dependent code for sockets, but very little. Other than that, we would need a routine to convert UNICODE to and from UTF-8, which is something simple and common.

GUI is a complete different story, I think we both agree here on the importance of a toolkit.

Oh, and I almost forgot, there is nothing wrong with EC. It needs attention because it is incomplete in the sense that aMuleGUI does not have the full functionality of aMule. Not a big deal, this is easy to add nowadays.

Cheers!
Logged

apo758

  • Guest
Re: A new look for aMule 2.2.0
« Reply #31 on: November 20, 2007, 05:27:43 PM »

Do you need PPC Mac, Intel Mac or it's indifferent? On my Mac Intel (32bit) it gives me "sizeof (wchar_t) = 4".
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: A new look for aMule 2.2.0
« Reply #32 on: November 20, 2007, 05:38:44 PM »

someone has never used pthreads
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: A new look for aMule 2.2.0
« Reply #33 on: November 20, 2007, 05:59:18 PM »

phoenix: I was talking about wxDesigner and DialogBlocks, which are both closed source.

I don't think that it is a good idea to rewrite the whole core without a toolkit or rather with self-written functions to do the same job. It's too much work with little direct benefit.

I think it would be better to spend the time in the development of remote GUI related code, like e.g. an EC implementation using QT or Python to facilitate the development of a new GUI.

Quote
Anything wrong with protocol? What exactly needs attention?
The documentation. I still have the beginning of an EC implementation in Python on my old PC, which I gave up for a lack of time, because although the code is pretty well commented it is still not trivial to understand and takes quite some time to figure out.
Logged

brainnolo

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 23
Re: A new look for aMule 2.2.0
« Reply #34 on: November 20, 2007, 08:27:33 PM »

Is not just about preferences, the GUI is bad for  many reasons. What puzzles me is why there is a setting for every damn protocol option and the search is rudimentary with no real option (filter by file type, filter by size) which would be useful for the task one wants to accomplish.

I still believe the wx is not at fault at all, although is not perfect is not really that much worse than Qt or any other toolkit. You cannot be native with any cross-platform tool, maybe you will always look bad on some platform, but you can make the thing usable at least.

However, I'm just empty talking and that's not some real help. If I get to do some work I will post sketches and then we can talk seriously about the matter.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: A new look for aMule 2.2.0
« Reply #35 on: November 21, 2007, 02:31:13 AM »

What puzzles me is why there is a setting for every damn protocol option and the search is rudimentary with no real option (filter by file type, filter by size) which would be useful for the task one wants to accomplish.
My aMule has such options and more, I just have to click the "Extended parameters" checkbox and they appear. However I have no idea since when is that available. I've always seen it.

Regards.
Logged

brainnolo

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 23
Re: A new look for aMule 2.2.0
« Reply #36 on: November 21, 2007, 09:40:07 AM »

My aMule has such options and more, I just have to click the "Extended parameters" checkbox and they appear. However I have no idea since when is that available. I've always seen it.

Regards.

That's some way of hiding features! :P
Logged

apo758

  • Guest
Re: A new look for aMule 2.2.0
« Reply #37 on: November 21, 2007, 09:58:46 AM »

I think it's good the way aMule handle search options. You don't need it everytime and when you do you just need a click. This checkbox makes the interface clean but powerful. But it would be good to make aMule remember the last search mode (global, local, kad or file hash).
Logged

lfroen

  • Guest
Re: A new look for aMule 2.2.0
« Reply #38 on: November 21, 2007, 10:59:06 AM »

Quote
Anything wrong with protocol? What exactly needs attention?
The documentation. I still have the beginning of an EC implementation in Python on my old PC, which I gave up for a lack of time, because although the code is pretty well commented it is still not trivial to understand and takes quite some time to figure out.
Pleeese, don't be ridiculous. Why ask for things you sure not gonna get? Documentation is one of them. Even very popular open source projects suffer from this very problem. No chance that aMule will be different.


Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: A new look for aMule 2.2.0
« Reply #39 on: November 21, 2007, 12:25:31 PM »

It is not ridiculous to ask for documentation. Ok, maybe you won't get it :D

If we are going to do something like libEC, it should have a nice documentation, like any library.

Besides, if we were using doxygen (and we are using doxygen tags in a few places), we would have a good start.

And besides #2, there is already some documentation.

Cheers!
Logged

lfroen

  • Guest
Re: A new look for aMule 2.2.0
« Reply #40 on: November 21, 2007, 01:27:43 PM »

If we are going to do something like libEC, it should have a nice documentation, like any library.
I think that yours "like any library" is very precise. Most of open source libraries have bad or non-existing documentation.
Logged

EseNoy

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Re: A new look for aMule 2.2.0
« Reply #41 on: November 21, 2007, 07:57:43 PM »

Hi, I'm N0y a graphic designer from Spain.

I'm really interested in make that icon-set (I'm actually working  on it).  ;)
I'm triying to desing icons undertandable in any country, and working without text too...
I want to know what kind of style are you looking for.
And would be useful to contact directly with somebody via email so I can send examples and discuss it.

If you are interested, please, have no doubt in contact me.

Salud!!
Logged

EseNoy

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Re: A new look for aMule 2.2.0
« Reply #42 on: November 21, 2007, 07:59:25 PM »

P.D.: I love rabbits too!!
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: A new look for aMule 2.2.0
« Reply #43 on: November 21, 2007, 08:06:13 PM »

Hi EseNoy,

It's very nice to hear that you are working on a icon set! It's hard to say what kind of style, but I would like to see something fresh and "serious", i.e. no bright colours or funny motives. I like the style of the tango project a lot.

If you need any help or want to discuss something, please contact me. (wuischke@amule.org)

kind regards

P.D. TambiƩn hablo el Castellano bastante bien y si prefieres, puedes escribirme en Castellano.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: A new look for aMule 2.2.0
« Reply #44 on: November 21, 2007, 08:53:37 PM »

How about a skins subforum?
Logged
Pages: 1 2 [3] 4 5 ... 7