aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: wrong ordering/placing of clients in the download window  (Read 4333 times)

ozsd

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 17
wrong ordering/placing of clients in the download window
« on: July 15, 2008, 02:44:19 PM »

Hi, I noticed a problem with aMule 2.2.1 (note that I'm using a version compiled for Ubuntu, so it may not be a problem of aMule itself but the underlying library). When I double click on a file in download to view the client connecting, sometimes the client are placed "randomly" in the window and not under the "double clicked" file.

The following image shows the problem:
* I "double clicked" the second file (note the little point next to the status bar);
* the client are shown on the first two and last two row; I was expecting that they were shown under the file itself instead. Note also that I was ordering by priority.
« Last Edit: July 15, 2008, 02:53:30 PM by wuischke »
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: wrong ordering/placing of clients in the download window
« Reply #1 on: July 15, 2008, 02:50:51 PM »

Thanks for this report, but please don't show file names. I'll take care of it for now, but remember this in the future.

Does this happen only when you sort by priority? Please try it with default sorting.
Logged

ozsd

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 17
Re: wrong ordering/placing of clients in the download window
« Reply #2 on: July 15, 2008, 03:07:15 PM »

Thanks for this report, but please don't show file names. I'll take care of it for now, but remember this in the future.
Sorry.
Quote
Does this happen only when you sort by priority? Please try it with default sorting.
It's difficult to say. I usually keep sorting by priority and the problem is hard to reproduce during testing. I will post an update if get some more info related on how to reproduce it and the importance on the sorting criteria.
Logged

ozsd

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 17
Re: wrong ordering/placing of clients in the download window
« Reply #3 on: July 16, 2008, 10:22:05 AM »

Since yesterday I was able to reproduce it only once and with priority sorting. However I wouldn't bet that this is the cause.

I also want to add that I have "Auto-sort files in the download queue (high CPU)" option enabled in the preferences. Maybe is related to this?
Logged

ozsd

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 17
Re: wrong ordering/placing of clients in the download window
« Reply #4 on: November 21, 2008, 12:47:07 PM »

I am still having this issue with 2.2.2 (in Ubuntu 8.10, pakage from official repository).

I noticed it only when sorting by priority.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: wrong ordering/placing of clients in the download window
« Reply #5 on: November 21, 2008, 06:43:07 PM »

It will also happen when you download two files of the same size, sort by size and then show clients of one of them.  ;D
Reason is that some files are equal according to some sort orders, and that's fatal if one has its clients open, because they can be assigned to the wrong one then.
I sort them now by name if they are equal. Fix will be in 2.2.3 (and in trunk once that file gets unlocked...).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: wrong ordering/placing of clients in the download window
« Reply #6 on: November 21, 2008, 09:34:47 PM »

It won't be relevant in trunk anymore once they're unlocked, so go on fix it in 2.2.3.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: wrong ordering/placing of clients in the download window
« Reply #7 on: November 21, 2008, 10:00:34 PM »

It's already done.
Looking forward to seeing what you've achieved with the ListCtrls.  8)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon