aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: aMule renders tables slow  (Read 5690 times)

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
aMule renders tables slow
« on: September 26, 2008, 02:41:47 AM »

Hi!

I just installed aMule SVN from sept 22 2008, and I find its network performance is great. It connects way faster than even aMule 2.2.2 to both, ed2k and kad. Thanks for that. However, I also noticed that tables rendering is really slow (downloads, uploads and shared files). it takes a huge amount of time to scroll down my list of downloads (OK, there are like 900 of themm almost all paused, but aMule 2.2.2 had the same downloads and it wasn't this slow). It happens the same with uploads. I usually hide the uploads part (via the green button that hides that part) but if I click the button to show them, it appears, but it takes long time to show the just 6 uploads I regularly have. Not to mention the 2 minutes it takes to change from transfers to shared files (158 shared files) and the painful slowness when scrolling the shared files. Again, with aMule 2.2.2 this worked fine.

I'm using fedora 9 x86 fully patched, wxGTK provided by fedora (2.8.7) and aMule monolithic. The computer is an athlon x64 5600+ with 2GB RAM.

Thanks!
Logged

gav616

  • Guest
Re: aMule renders tables slow
« Reply #1 on: September 26, 2008, 02:50:07 AM »

i mentioned this a while ago, and got told it was because i compile with optimize off,

but tbh every aMule svn i build now i use (for good backtraces) debug on, optimize off, and run in an gdb environment

i haven't noticed painfully slow rendering of menus in latest builds though.

on arch linux wx 2.8.8
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #2 on: September 26, 2008, 03:43:46 AM »

I am using amule compiled with --enable-optimze, --disable-debug and the binaries are stripped. I have no clue how can i optimize it further.

Regards.
Logged

gav616

  • Guest
Re: aMule renders tables slow
« Reply #3 on: September 26, 2008, 04:07:34 AM »

could be 2d driver performance, you use ati?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule renders tables slow
« Reply #4 on: September 26, 2008, 04:49:37 PM »

Could you try this patch and see if it helps ?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #5 on: September 27, 2008, 03:24:56 AM »

Hi!

I am inclined to the gav616 option, since I use F9 and nvidia, and because of livna system being down I have not been able to install the latest nvidia driver on my system, therefore I am using the standard 2d nv driver for my card. That should be the cause. I'll wait for livna driver and test again. However, the sturedman's patch seems interesting...what should it do, stu?

Regards.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule renders tables slow
« Reply #6 on: September 27, 2008, 07:05:48 PM »

Right now the progress bars are rendered with high level graphic functions DrawLine/DrawRectangle which use pens and brushes. The patch renders the whole bar into an array and draws it as a raw bitmap all at once. This does away with the GDI ressource problem on Windows and also improves  performance. How much should depend on the performance of the DrawLine/DrawRectangle functions - it could be more on some platforms than on others. Especially if there's no hardware drawing support as in your case.

You can try disabling progress bars  for a start. If that increases your performance dramatically the patch should help as well (with bars back on of course).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #7 on: September 28, 2008, 02:03:27 AM »

sturedman:

Is there any loss in committing your patch to SVN? will it be commited?

Regards.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #8 on: September 28, 2008, 06:48:02 PM »

Hi!

I installed sturedman's patch, and 5 minutes after using aMule, it shows no slowness at all. In fact, it works as good as when I had my nvidia drivers installed. So far, i like this patch. I think it should be commited, since it seems the patch removes aMule's dependance on a properly working video driver and it makes it work using a plain VESA video driver. I'll keep you informed on any new events...

Thanks!

Edit: After running for more than 8 hours, aMule is still completely responsive, and even faster than ever was. The sorting of the tables is now as fast as emule on windows (a breeze), which is really good. I love this patch.
« Last Edit: September 29, 2008, 02:59:08 AM by skolnick »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: aMule renders tables slow
« Reply #9 on: September 29, 2008, 06:42:11 AM »

It will most probably be commited, it's my fault it hasn't been yet. But it will.
Logged

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #10 on: September 30, 2008, 05:45:04 AM »

Thanks Kry. This seem to address one of the complains I had with aMule: the GUI was slower than the emule one.

Regards.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule renders tables slow
« Reply #11 on: November 18, 2008, 11:47:25 PM »

Patch is in SVN now (already in the snapshot Wuischke posted).
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: aMule renders tables slow
« Reply #12 on: November 19, 2008, 04:16:13 PM »

Great sturedman, thanks a lot!
Logged