aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Wrong available parts on files bigger than 4GB  (Read 2442 times)

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Wrong available parts on files bigger than 4GB
« on: December 01, 2008, 05:53:39 AM »

Hi!

I have on my aMule SVN from Sep 22 2008 a file bigger than 4GB (6.84GB). The file has complete sources, and I've downloaded about 60% of the file, but the file details windows says that only 244 of the 756 parts are available, which is false. I have only seen this with this file, and is the only file bigger than 4GB I'm currently downloading, so I think it's related.

Regards.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Wrong available parts on files bigger than 4GB
« Reply #1 on: December 01, 2008, 11:43:56 PM »

Cute!  ;D
It's not directly related with 4GB, rather with files with more than 255 parts. Just a relic from the times when available parts could be counted in a single byte.  Hint: 244 + 2*256 == 756 .
Fixed.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: Wrong available parts on files bigger than 4GB
« Reply #2 on: December 02, 2008, 06:05:24 AM »

Thanks Stu Redman. But then, does that means that for files bigger than about 2.5GB aMule always counted the parts wrongly? (9.25*255 is about 2.5GB) I ask because 2.5GB files have always been allowed by the emule protocol, therefore aMule should have provided this fix long time ago, since the beginning, to be exact.

Regards.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Wrong available parts on files bigger than 4GB
« Reply #3 on: December 02, 2008, 09:44:14 PM »

But then, does that means that for files bigger than about 2.5GB aMule always counted the parts wrongly?
Yes. But the variable involved is only used for the display in the file detail dialog, so it's not so severe.

Quote
aMule should have provided this fix long time ago, since the beginning, to be exact.
Since the start of supporting large files actually, before it didn't matter. Well, fixes can't be provided sooner than someone notices something is wrong.  ;)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon