aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: aMule 2.2.3 - IPFILTER problem and a new sorting problem  (Read 9315 times)

Marsjanin

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
  • Hell-Law, World ]:>
    • Marsjanin's Homepage
aMule 2.2.3 - IPFILTER problem and a new sorting problem
« on: January 29, 2009, 06:37:20 PM »
Hello.

I just compiled the newest aMule 2.2.3 on my Ubuntu 8.10 to make myself sure, that there's no missed updates, that fix the bugs, that I want to wrote on a forum about. I had previously 2.2.2 version from Ubuntu repository.

Well... The main for me bug is not fixed: aMule still can't load IPFILTER file that begins (or ever contains?) lines with comments (that begins with a #hash). So, the well-known IPFILTER from emule-mods.de is incompatible with aMule. I just go wrote same thing in some place in a forum now.

And... \o/ What a great move. :/ Some good functionality disaperared now. Let me explain, what it was:
Old aMule remembered (within a session - better that than nothing) in what order I clicked columns to sort a files.

So, when I clicked first on filename, then on progress bar, the result was - first, the files that had biggest amount of downloaded data, then, if them has the same result there (commonly all the paused on 0% ones) - ALPHABETICALLY.

Another example: click on filemane, progress bar, then sources. First the ones with greatest number of sources, then, if some (again: paused on 0% ones in most cases) has the same src number, sorted by amount of DL-ed data, then alphabetically.

I usually sort the files after launch of aMule like that:
Filename ↑ , Sources ↓ , Priority ↑ , Status ↑ , Progress ↓
and I had it sorted in my way...

Now i got all sorted reversed-alphabetically (Z to A) because of (i think) the arrow in Progress (last clicked) column is down.
Previously, the file I wait for, but there's actually NO sources, I got just under the dowloading ones.
Now I got it somwhere alphabetically sorted.

Is that bug or feature - or a compiling mistake (there was no errors during ./configure)?
« Last Edit: January 29, 2009, 11:38:10 PM by Marsjanin »
Logged
Best Regards,
Marsjanin

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #1 on: January 30, 2009, 07:14:15 PM »
Quote from: Marsjanin on January 29, 2009, 06:37:20 PM
aMule still can't load IPFILTER file that begins (or ever contains?) lines with comments (that begins with a #hash).
Hash has nothing to do with it. Problem are some non-printable characters in the comment that screw up the file type detection and don't belong there in the first place. Please complain with the guy who makes the list.

Quote from: Marsjanin on January 29, 2009, 06:37:20 PM
And... \o/ What a great move. :/ Some good functionality disaperared now.
If you're trying to convince us to do something for you, you are doing a lousy job.  :P

Quote from: Marsjanin on January 29, 2009, 06:37:20 PM
Old aMule remembered (within a session - better that than nothing) in what order I clicked columns to sort a files.
If it really behaved that way it was purely accidental. And it's pretty useless anyway.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #2 on: January 30, 2009, 09:23:11 PM »
I don't agree that it's useless, and I have my doubts about it being a coincidence - I heard Xaignar at some point discussing a "sort stack". But, it might just be that things sorted by the criteria "A" and then "B" will mean that the comparison between items X and Y by criteria A resulting in XY is unaffected once the criteria B is applied, because they are equal for that criteria. If X==Y by B, but X>Y by A, both ->A->B-> and ->B->A-> will transitively reach the same sorting point, XY.

... am I not at my peak usefulness point today? :D
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #3 on: January 30, 2009, 10:09:42 PM »
 :o
(checking commit mails)
 :(
Nope, you can top that.  ;)
</end dev joke>

Quote from: Kry on January 30, 2009, 09:23:11 PM
But, it might just be that things sorted by the criteria "A" and then "B" will mean that the comparison between items X and Y by criteria A resulting in XY is unaffected once the criteria B is applied, because they are equal for that criteria.
We only provide a comparison, the sort itself is done in wx. And the order of equal elements after the sort depends on the sort algorithm - it could stay equal, or be totally mixed up. So behaviour might rather depend on wx version than on aMule. Don't know if anything was changed there.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #4 on: January 31, 2009, 03:33:58 AM »
Actually Stu, if you remember http://www.amule.org/amule/index.php?topic=16394.msg86814#msg86814 (Broken link for regular users, sorry), wxWidgets actually uses qsort with our function.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #5 on: January 31, 2009, 12:40:33 PM »
I do remember, and Quicksort is not a stable search algorithm.
What I didn't research is if wx has been using qsort forever, or if the now-gone "feature" might be related to a 2.2.2 build with an older wx version using a different (and stable) search.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Marsjanin

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
  • Hell-Law, World ]:>
    • Marsjanin's Homepage
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #6 on: January 31, 2009, 08:02:21 PM »
Well, in first words - I didn't meant I want some extra features just for me; just though *if* that was a bug or accidental mistake in that part of code, I wanted to highlight a problem. Well, unfortunately You said that's no aMule's part of code, so there's no way to fix it by aMule programmers.

Well, but what about the unprintable characters in IP list? Is there no way to fix it in another version on aMule? That ipfilter is very popular and it seems to work properly in other apps (i guess here mainly eMule and its mods), so author may not want to change anything in next versions. Now it reminds me a famous "begin " problem in Outlook Express. :(
Logged
Best Regards,
Marsjanin

Marsjanin

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
  • Hell-Law, World ]:>
    • Marsjanin's Homepage
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #7 on: February 05, 2009, 04:31:45 PM »
Hello, it's me again.
I just noticed the columns in window "shared files" works in old way, i.e. they "remember" the history of sorting... Strange for me.
Logged
Best Regards,
Marsjanin

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #8 on: March 14, 2009, 09:03:56 PM »
Quote from: Kry on January 30, 2009, 09:23:11 PM
I heard Xaignar at some point discussing a "sort stack".
It's mostly there in the code, but I don't think it's fully operational.

Quote from: Stu Redman on January 30, 2009, 10:09:42 PM
We only provide a comparison, the sort itself is done in wx.
The comparison routine was originally designed that two different list entries were never equal, whatever search criteria you chose.
Logged
concordia cum veritate

Pitxyoki

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 40
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #9 on: March 15, 2009, 12:57:08 PM »
Quote from: Marsjanin on February 05, 2009, 04:31:45 PM
Hello, it's me again.
I just noticed the columns in window "shared files" works in old way, i.e. they "remember" the history of sorting... Strange for me.
I can confirm this. Sorting on the "Shared Files" window works as expected. Also, the "Uploads" and the "On Queue" lists also seem to be sorting well too.
It's only the download list that isn't sorting the downloads as it should (i.e., it doesn't "remember the history of sorting"). Couldn't you use the same "good" sorting function for all lists?

P.S.- I just noticed a small issue that may not be related to this, but when sorting by client on the "On Queue" or "Uploads" lists, the lists are only sorted by the client name and the version seems to be ignored. The attached screenshots show what I mean.
This last issue is not very important to me, but I think that these little bugs end up spoiling a consistent feel a regular user would expect from a good program like aMule. :)

Thanks,
Pitxyoki

<edit>I forgot the attachements  :-X</edit>
« Last Edit: March 15, 2009, 04:01:37 PM by Pitxyoki »
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #10 on: March 15, 2009, 03:21:54 PM »
OK, I'm seeing clear now. The functionality was broken by - tadah - me in 2.2.3 (only for the download list control).  :-[
But it was broken for a reason - see here.
I'll see if I can get both issues working together.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #11 on: March 15, 2009, 06:24:25 PM »
Fixed in 9517, so it will behave in 2.2.4 like in 2.2.2.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Marsjanin

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
  • Hell-Law, World ]:>
    • Marsjanin's Homepage
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #12 on: March 15, 2009, 09:31:01 PM »
Nice to hear. :)
Logged
Best Regards,
Marsjanin

Pitxyoki

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 40
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #13 on: January 09, 2010, 02:36:04 AM »
This is working well now, but can't we keep the sorting used from session to session?

Currently (2.2.6), after a restart, aMule(gui) remembers the last sorted column, but it seems to always use the file name for secondary sorting. When I start aMule, I'd like to see its columns sorted like I left them when I closed it.
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: aMule 2.2.3 - IPFILTER problem and a new sorting problem
« Reply #14 on: January 09, 2010, 09:35:40 AM »
As far as I can tell there is no "secondary sorting" in aMule. I am using 2.2.6 too and it seems to remember the sorted columns correctly.
Btw. is this by any means related to: http://bugs.amule.org/view.php?id=1088 ?
Logged
Pages: [1] 2
« previous next »