aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Shared file filter  (Read 7179 times)

jpv950

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 59
Shared file filter
« on: April 09, 2009, 03:46:12 PM »
It'd be really nice to have a shared file filter, implemented in preferences->directories, to exclude certain files by extension. Use case, among many others: user has video files and subtitles in the same folder but just wants to share the video.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Shared file filter
« Reply #1 on: April 09, 2009, 09:22:14 PM »
Quote from: jpv950 on April 09, 2009, 03:46:12 PM
user has video files and subtitles in the same folder but just wants to share the video.
Why?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

jpv950

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 59
Re: Shared file filter
« Reply #2 on: April 09, 2009, 11:24:30 PM »
Quote from: Stu Redman on April 09, 2009, 09:22:14 PM
Quote from: jpv950 on April 09, 2009, 03:46:12 PM
user has video files and subtitles in the same folder but just wants to share the video.
Why?

Because subtitles generally take 10 seconds to download using google and many video players can already do it automatically. Or more precisely, because there is a limit to how many files one may share. It's better to hit that limit sharing other, more valuable kinds of files.
Logged

lfroen

  • Guest
Re: Shared file filter
« Reply #3 on: April 10, 2009, 06:02:55 AM »
"shared directory" called "shared" because user desire to share it's contents. Move files out of it and create links to those you want.
Logged

jpv950

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 59
Re: Shared file filter
« Reply #4 on: April 10, 2009, 05:03:34 PM »
Quote from: lfroen on April 10, 2009, 06:02:55 AM
"shared directory" called "shared" because user desire to share it's contents. Move files out of it and create links to those you want.

The thing is, I don't have directories I want to share, just files. For archiving it is useful to keep video and subtitles in the same folder (because then the subtitles are automatically loaded when I play a file) but not so for sharing. So if you imagine that the max limit is 200 shared files and my total shared count is 1000 files (500 videos and 500 subtitles), some files will be left out. So I might be sharing 100 videos and 100 subtitles when I could be sharing 200 videos instead. Which do you think is better?
Logged

lfroen

  • Guest
Re: Shared file filter
« Reply #5 on: April 10, 2009, 10:16:05 PM »
I think better is create directory with links to relevant files.
Logged

jpv950

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 59
Re: Shared file filter
« Reply #6 on: April 10, 2009, 10:48:28 PM »
Quote from: lfroen on April 10, 2009, 10:16:05 PM
I think better is create directory with links to relevant files.

Ok, fair enough, but instead of putting the burden on the user I think it's worth considering such a simple feature to improve the quality of the network.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Shared file filter
« Reply #7 on: April 10, 2009, 10:51:27 PM »
I doubt anybody except you would be using it, so it would hardly improve the quality of the network.  :P
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Shared file filter
« Reply #8 on: April 11, 2009, 09:20:32 AM »
jpv950: Could you create a proof-of-concept patch, please?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Shared file filter
« Reply #9 on: April 11, 2009, 12:36:18 PM »
What should that proove? Of course it can be done. Question is if it makes sense or not and that can be discussed without a patch.
Also we can't commit GUI changes at the moment anyway.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Shared file filter
« Reply #10 on: April 11, 2009, 01:14:50 PM »
What should it prove? - that feature requests accompanied by a patch a more likely to be implemented.

I'm not opposed to the functionality, but I wouldn't bother implementing it. If there's a good patch around, I would commit it. That's no guarantee that we implement for the requester, but at least he has a working implementation for himself in this case.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Shared file filter
« Reply #11 on: April 11, 2009, 03:22:18 PM »
Quote from: jpv950 on April 10, 2009, 10:48:28 PM
I think it's worth considering such a simple feature

Well, implementation is not at all simple. eMule0.49c has the feature to allow individual files be shared or unshared regardless of their location (which means, you can share a file that's not in a shared directory or you can unshare a single file in a shared directory). This may be ported to aMule in the future.
Logged
concordia cum veritate

jpv950

  • Jr. Member
  • **
  • Karma: 2
  • Offline Offline
  • Posts: 59
Re: Shared file filter
« Reply #12 on: April 11, 2009, 09:21:57 PM »
Quote from: wuischke on April 11, 2009, 01:14:50 PM
What should it prove? - that feature requests accompanied by a patch a more likely to be implemented.

I'm not opposed to the functionality, but I wouldn't bother implementing it. If there's a good patch around, I would commit it. That's no guarantee that we implement for the requester, but at least he has a working implementation for himself in this case.

Ok, I'll keep that in mind. I'm having to learn Java at school and the syllabus includes some C++. Maybe then I'll try to provide a patch.

Quote from: GonoszTopi on April 11, 2009, 03:22:18 PM
Quote from: jpv950 on April 10, 2009, 10:48:28 PM
I think it's worth considering such a simple feature

Well, implementation is not at all simple. eMule0.49c has the feature to allow individual files be shared or unshared regardless of their location (which means, you can share a file that's not in a shared directory or you can unshare a single file in a shared directory). This may be ported to aMule in the future.


I didn't know eMule had this feature. That would be even better because it would provide more fine grained control over shared files but yeah, not as simple to implement as a filter and harder to get right in terms of usability.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Shared file filter
« Reply #13 on: April 12, 2009, 07:09:52 PM »
Quote from: wuischke on April 11, 2009, 01:14:50 PM
What should it prove? - that feature requests accompanied by a patch a more likely to be implemented.
Well, I have seen such requests turned down anyway and didn't want him to dig right in without general acceptance.

Quote from: GonoszTopi on April 11, 2009, 03:22:18 PM
eMule0.49c has the feature to allow individual files be shared or unshared regardless of their location
I'd prefer this approach too.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon