aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: aMule statistics! :)  (Read 4529 times)

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 580
aMule statistics! :)
« on: July 31, 2009, 12:12:33 PM »

Well...for now i post a screenie of the stats window, until we can have a copy feature of the text! :D



There seems also to be a small bug where it says "Found sources"....without a download they are too much! :D

Post your stats, too! :)
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5898
Re: aMule statistics! :)
« Reply #1 on: July 31, 2009, 12:54:48 PM »

That found sources looks like a -1 to me.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: aMule statistics! :)
« Reply #2 on: July 31, 2009, 08:58:36 PM »

I think this should fix it:
Code: [Select]
Index: DownloadQueue.cpp
===================================================================
--- DownloadQueue.cpp (revision 9731)
+++ DownloadQueue.cpp (working copy)
@@ -572,13 +572,7 @@
  } else {
  // Source was known, but reqfile NULL.
  source->SetRequestFile( sender );
- if (source->GetSourceFrom() != nSourceFrom) {
- if (source->GetSourceFrom() != SF_NONE) {
- theStats::RemoveSourceOrigin(source->GetSourceFrom());
- theStats::RemoveFoundSource();
- }
- source->SetSourceFrom(nSourceFrom);
- }
+ source->SetSourceFrom(nSourceFrom);
  sender->AddSource( source );
  if ( source->GetFileRating() || !source->GetFileComment().IsEmpty() ) {
  sender->UpdateFileRatingCommentAvail();

Sources are supposed to be counted through CPartFile::AddSource, CPartFile::DelSource . I don't see why the sourceFrom of a client without a RequestFile should influence the stats. Anybody disagree?  :-\
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 163
  • Offline Offline
  • Posts: 2688
Re: aMule statistics! :)
« Reply #3 on: July 31, 2009, 09:17:25 PM »

Anybody disagree?
No. At least me not.
Logged
concordia cum veritate

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 529
Re: aMule statistics! :)
« Reply #4 on: August 01, 2009, 06:48:50 PM »

I noticed that the total UL:DL ratio is not displayed. It should be there at the top in parentheses.
Logged

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 580
Re: aMule statistics! :)
« Reply #5 on: August 02, 2009, 01:51:40 AM »

Yeah, would be nice! ;)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: aMule statistics! :)
« Reply #6 on: August 02, 2009, 09:51:34 PM »

Total UL:DL ratio is now displayed (9741). And I committed the fix for the negative sources (9743). Myth, please verify if it fixes the problem.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 529
Re: aMule statistics! :)
« Reply #7 on: August 03, 2009, 07:43:06 PM »

Total UL:DL ratio is now displayed (9741). And I committed the fix for the negative sources (9743). Myth, please verify if it fixes the problem.
Good job, I'll try to verify later.
Logged

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 580
Re: aMule statistics! :)
« Reply #8 on: August 04, 2009, 12:48:33 AM »

Until now, both work very fine! THX!
Logged

myth

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 38
  • Offline Offline
  • Posts: 580
Re: aMule statistics! :)
« Reply #9 on: May 16, 2010, 12:04:37 PM »

Here some longtime stats, before using the new gui ;)

Logged