aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: ed2k link handler doesn't handle too long links  (Read 5363 times)

Morse

  • Full Member
  • ***
  • Karma: 6
  • Offline Offline
  • Posts: 105
ed2k link handler doesn't handle too long links
« on: August 04, 2009, 11:35:59 AM »
remote gui 2.2.5
Don't know if this is true for monolithic.

If ed2k-link is longer than screen width it would be splitted in two lines, and thus would be useless - "commit" button wouldn't actually commit it.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: ed2k link handler doesn't handle too long links
« Reply #1 on: August 04, 2009, 08:02:06 PM »
True for monolithic too, and fixed in SVN. However, on GTK long links become unreadable because a scrollbar appears and covers them. They still work though.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: ed2k link handler doesn't handle too long links
« Reply #2 on: August 05, 2009, 02:01:48 AM »
Didn't we have this conversation a long time ago, stu? Please revert and find a difefrent fix, even one that fixed wxWidgets, which is where the bug is.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: ed2k link handler doesn't handle too long links
« Reply #3 on: August 05, 2009, 12:13:53 PM »
Please don't tell me that we had that conversation,
cause I won't remember, save your breath, cause what's the use?  ;D

Can't revert - someone has locked the file.  :P

As of now we could choose between:
a) visible and broken
b) invisible and functional (but why would you want to look at a link you pasted anyway?)
c) visible and broken, then try to glue the broken links back together.

I've made a patch for wx for an option to disable the scrollbar and filed a change request. Let's see what they say.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: ed2k link handler doesn't handle too long links
« Reply #4 on: August 05, 2009, 12:52:25 PM »
IF anything I'd go for c).

If you were able to commit a locked file, wouldn't you be able to revert as well?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: ed2k link handler doesn't handle too long links
« Reply #5 on: August 05, 2009, 02:34:28 PM »
The change 8872 was in the muuli and that can't be merged. So I see no point in reverting it now. But I can do it of course if you want.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: ed2k link handler doesn't handle too long links
« Reply #6 on: August 05, 2009, 02:41:27 PM »
Do we want to break linux and mac for windows?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: ed2k link handler doesn't handle too long links
« Reply #7 on: August 05, 2009, 04:03:53 PM »
Very well then. Long links can't be pasted on non-MSW platforms anymore as of 9753.  ::)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

skolnick

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 24
  • Offline Offline
  • Posts: 1188
  • CentOS 6 User
Re: ed2k link handler doesn't handle too long links
« Reply #8 on: August 06, 2009, 04:15:34 AM »
Quote from: Stu Redman on August 05, 2009, 04:03:53 PM
Very well then. Long links can't be pasted on non-MSW platforms anymore as of 9753.  ::)
Stu, please, define "long" in the above sentence.

Thanks!
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: ed2k link handler doesn't handle too long links
« Reply #9 on: August 06, 2009, 08:05:45 AM »
"Long" == "so long that the text will be wrapped in the control". Depends on your window size and the font size of your platform. Plain ED2K links usually have no problem (except with ridiculously long names). Links with more information (like additional SHA or magnet) may break of course.
It's just like in 2.2.5 again.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon