Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[wires]

Hi all,

I'm also using GCC 4.4.1 (on Fedora 11 64bits) but I'm able to compile both provided and generated versions... (aMule-SVN-r9783-RELEASE-2_2_X)

$ gcc --version
gcc (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2)
Copyright (C) 2009 Free Software Foundation, Inc.

$ grep fwrite php_lexer.c
 * we now use fwrite().
#define ECHO fwrite( yytext, yyleng, 1, yyout )

$ flex --version
flex 2.5.35

I've noticed that there is no php prefix but yy.  Don't know if it is important...

I can make some tests if you wish. Find attached the generated php_lexer.c.

Regards!

[GonoszTopi]

Code: [Select]

#define ECHO (void) fwrite( phptext, phpleng, 1, phpout )

That's definiately not what we want. At least on my system the above #define is included in a #ifndef ECHO block, which is defined in php_parser.h included before the test. That's why it works.

However, since ECHO is a token of the language and is used for something completely different by the generated code we should consider renaming the token to something else not conflicting with flex.

[stefanero]

btw thats the part how my "self" compiled stuff looks like

Code: [Select]

/* Copy whatever the last rule matched to the standard output. */
#ifndef ECHO
/* This used to be an fputs(), but since the string might contain NUL's,
 * we now use fwrite().
 */
#define ECHO do { if (fwrite( phptext, phpleng, 1, phpout )) {} } while (0)
#endif

should this file be in most cases static? so basically always use the one from svn?
or should we want this file be generated on most linux systems and only be static if requirements are not met, and on windows?

[Stu Redman]

At least on my system the above #define is included in a #ifndef ECHO block, which is defined in php_parser.h included before the test. That's why it works.

Yes, finally understood it. Only - why doesn't it work for Stefanero? 
Stefanero, is something wrong with your php_parser.h ? Like the #define ECHO missing or not processed or whatever?

However, since ECHO is a token of the language and is used for something completely different by the generated code we should consider renaming the token to something else not conflicting with flex.

Agreed. And we should backport it to 2.2.6 before the problem spreads.

should this file be in most cases static? so basically always use the one from svn?

I'd say everybody should use the generated code. Generation should only occur if someone modifies the lex file (and who does that should be able to figure out possible problems with his lexer himself  ).

[GonoszTopi]

And we should backport it to 2.2.6 before the problem spreads.

Completely agreed. I'll do it tonight.

[stefanero]

btw works like a charm in current svn now

[GonoszTopi]

Nice to hear.