aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: cathegory detection when providing a ed2k link  (Read 5921 times)

bubla

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
cathegory detection when providing a ed2k link
« on: September 03, 2009, 11:51:16 AM »

Hello,
imagine a situaion when you have a bunch of ed2k links and you want the respective files to be added to a certain cathegory.
Currently you can just add all the links and then select appropriate files in the "transfers" tab and assign them to the desired cathegories this way. Not bad.
But what would be IMHO even better - if you are adding the link in the "transfers" tab and you have a concrete cathegory tab selected, amule could assign that file to that cathegory right away.
Doesn't sound bad, does it?
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: cathegory detection when providing a ed2k link
« Reply #1 on: September 04, 2009, 01:45:32 AM »

Does make sense to me.
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: cathegory detection when providing a ed2k link
« Reply #2 on: September 04, 2009, 09:37:18 PM »

Me too, though it's a bit random if you add them through your browser using ed2k.exe and have the app minimized since a day ago.
I'd make an option "Add new downloads to a) general b) last cat selected in transfer tab"
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: cathegory detection when providing a ed2k link
« Reply #3 on: September 05, 2009, 01:22:14 PM »

it's a bit random if you add them through your browser using ed2k.exe
I'd use this approach only when the links are added via the GUI (either monolithic or remote, in both you see the current selected tab in front of you). Any other addition (ed2k.exe, webserver, amulecmd) should add to the default category as they do now.
Logged
concordia cum veritate

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: cathegory detection when providing a ed2k link
« Reply #4 on: September 05, 2009, 01:59:04 PM »

Maybe the other additions should go to a new temporary category called "Newly added" or something, so the users can then sort them as they want instead of search them in default.
Logged
Homefucking is killing prostitution

bubla

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 9
Re: cathegory detection when providing a ed2k link
« Reply #5 on: September 05, 2009, 02:58:30 PM »

it's a bit random if you add them through your browser using ed2k.exe
I'd use this approach only when the links are added via the GUI (either monolithic or remote, in both you see the current selected tab in front of you). Any other addition (ed2k.exe, webserver, amulecmd) should add to the default category as they do now.
That sounds nice. It would be a nice feature if it is not too complicated to implement this.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: cathegory detection when providing a ed2k link
« Reply #6 on: September 05, 2009, 03:24:57 PM »

I'd use this approach only when the links are added via the GUI
I hardly ever do that, so I think the usefulness would be quite limited that way. :(
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: cathegory detection when providing a ed2k link
« Reply #7 on: September 05, 2009, 06:54:42 PM »

We still can create a config option or some other method to specify a default category for new files added via ed2k links (I mean links without category specification, of course).
Logged
concordia cum veritate

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: cathegory detection when providing a ed2k link
« Reply #8 on: September 05, 2009, 11:57:18 PM »

You could also allow a regexp in the category properties to be applied to the filename of the newly added links and add it there if matches. Wouldn't take more than a couple lines of code.
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: cathegory detection when providing a ed2k link
« Reply #9 on: September 06, 2009, 01:14:38 AM »

That works for videos or music, but if you get a file from a website and your browser gives it to ed2k-handler, I don't think the filename will meet your regex. I still prefer the "newly added " category approach. You know "Kill them all and let god sort them out".
Logged
Homefucking is killing prostitution

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: cathegory detection when providing a ed2k link
« Reply #10 on: September 06, 2009, 02:01:24 AM »

Notice the "also"
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: cathegory detection when providing a ed2k link
« Reply #11 on: September 06, 2009, 11:30:17 AM »

The also makes no difference. With a regex you can match what you want, but if you can influence the material, you either can adjust the regex on everey new file or search for filenames that could match. Option 1 isn't really usefull, if you have to open aMule for this, you can just switch to the right category and leave the rest as it is. Option 2 means, that you have to have your regex on mind when you get a file, and if you found a file that doesn't match search on, or return to option one. So no really advantage here.
Logged
Homefucking is killing prostitution

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: cathegory detection when providing a ed2k link
« Reply #12 on: November 22, 2009, 12:06:00 AM »

But what would be IMHO even better - if you are adding the link in the "transfers" tab and you have a concrete cathegory tab selected, amule could assign that file to that cathegory right away.
Doesn't sound bad, does it?
Um - did anybody involved in the discussion try it? It already works that way.  :D
With 9879 it works in the remote gui too.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon