Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[RRM]

Wow, thats fast!!!
Ive downloaded your UploadBandwidthThrottler.cpp, and replaced the existing ones in:
~/tmp/amule-stu/src
~/tmp/amule-upstream/src

then i have to call:

Code: [Select]

$ cd ~/tmp/amule-stu
$ ./configure --prefix=/usr/local/stow/amule-opt/ --enable-geoip --enable-optimize --disable-debug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-opt

and then:

Code: [Select]

$ sudo stow -D amule-opt
$ cd ~/tmp/amule-upstream
$ ./configure --prefix=/usr/local/stow/amule-stu-opt-debug/ --enable-geoip --enable-optimize --enable-debug --with-wxdebug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-stu-opt-debug

Correct?

[btkaos]

Wow, thats fast!!!
Ive downloaded your UploadBandwidthThrottler.cpp, and replaced the existing ones in:
~/tmp/amule-stu/src
~/tmp/amule-upstream/src

then i have to call:

Code: [Select]

$ cd ~/tmp/amule-stu
$ ./configure --prefix=/usr/local/stow/amule-opt/ --enable-geoip --enable-optimize --disable-debug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-opt

and then:

Code: [Select]

$ sudo stow -D amule-opt
$ cd ~/tmp/amule-upstream
$ ./configure --prefix=/usr/local/stow/amule-stu-opt-debug/ --enable-geoip --enable-optimize --enable-debug --with-wxdebug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-stu-opt-debug

Correct?

I RRM.

Let's see, having two versions of source (amule-stu, amule-upstream) is only useful if you leave the amule-upstream one unmodified, so you can test both.

Anyways, you did it right, but you can do it more efficiently. For instance, if you got the ./configure parameters all right, you only need to call make again.

[RRM]

Thank you, so (after eplacing the file) i just need to call:

Code: [Select]

$ cd ~/tmp/amule-stu
$ make -j 2 && sudo make install
$ cd ~/tmp/amule-upstream
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-stu-opt-debug

But then, at the end, i get this:

Code: [Select]

collect2: ld returned 1 exit status
make[3]: *** [amule] Error 1
make[3]: Leaving directory `/home/rrm/tmp/amule-upstream/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/rrm/tmp/amule-upstream/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/rrm/tmp/amule-upstream'
make: *** [all] Error 2

So, i will have to start  with the amule-stu version, i guess...

Code: [Select]

cd /usr/local/stow
sudo stow amule-opt

[RRM]

ooops, im making a mess of it:

Code: [Select]

stow: CONFLICT: /usr/local/stow/amule-opt/bin/ed2k vs. /usr/local/bin/ed2k
rrm@rrm-desktop:/usr/local/stow$
and when i try to run amule:

Code: [Select]

Fatal Error: Mismatch between the program and library build versions detected.
The library used 2.8 (debug,Unicode,compiler with C++ ABI 1002,wx containers,compatible with 2.6),
and your program used 2.8 (no debug,Unicode,compiler with C++ ABI 1002,wx containers,compatible with 2.6).

So, i will have to configure with debug, no?
hmm, that doesnt work either...

[RRM]

I tried both

Code: [Select]

$ cd ~/tmp/amule-stu
$ ./configure --prefix=/usr/local/stow/amule-opt/ --enable-geoip --enable-optimize --disable-debug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-opt
and

Code: [Select]

$ cd ~/tmp/amule-stu
$ ./configure --prefix=/usr/local/stow/amule-opt/ --enable-geoip --enable-optimize --enable-debug --with-wxdebug --mandir=/share/bin
$ make -j 2 && sudo make install
$ cd /usr/local/stow
$ sudo stow amule-opt
but in both cases i get

Code: [Select]

Fatal Error: Mismatch between the program and library build versions detected.
The library used 2.8 (debug,Unicode,compiler with C++ ABI 1002,wx containers,compatible with 2.6),
and your program used 2.8 (no debug,Unicode,compiler with C++ ABI 1002,wx containers,compatible with 2.6).

[Stu Redman]

Use the second one and run make clean before make.

[RRM]

Fantastic!
Thank you.
Im running it and stepping on the gaspedal...

[RRM]

Its a high-VSZ crash

$ ps axl | grep amule

Code: [Select]

0  1000  4805  4774  20   0 122960  5300 poll_s S+   pts/0      0:01 gdb amule
0  1000  4807  4805  20   0 3145724 2716400 ptrace Tl pts/0    70:04 /usr/local/stow/amule-opt/bin/amule
0  1000  5056  4965  20   0   3036   792 pipe_w S+   pts/1      0:00 grep amule
Terminated after throwing an instance of 'std::bad_alloc'
   what(): std::bad_alloc
* Could not get symbol names for backtrace
   backtrace:


Program received signal SIGABRT, Aborted.
0x0093d422 in __kernel_vsyscall ()
(gdb) bt full

Code: [Select]

#0  0x0093d422 in __kernel_vsyscall ()
No symbol table info available.
#1  0x00af64d1 in raise () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#2  0x00af9932 in abort () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#3  0x0834fecd in OnUnhandledException () at MuleDebug.cpp:103
        t = 0x0
        output = 0xc0c560
#4  0x0082f415 in ?? () from /usr/lib/libstdc++.so.6
No symbol table info available.
#5  0x0082f452 in std::terminate() () from /usr/lib/libstdc++.so.6
No symbol table info available.
#6  0x0082f591 in __cxa_throw () from /usr/lib/libstdc++.so.6
No symbol table info available.
#7  0x0082fc0f in operator new(unsigned int) () from /usr/lib/libstdc++.so.6
No symbol table info available.
#8  0x009c7633 in wxObjectList::CreateNode (this=0x90c8ec0, prev=0x4c294ab0,
    next=0x0, data=0x4c294af0, key=...) at ../include/wx/list.h:1185
No locals.
#9  0x009dc6b9 in wxListBase::Append (this=0x90c8ec0, object=0x4c294af0)
    at ../src/common/list.cpp:244
        __FUNCTION__ = "Append"
---Type <return> to continue, or q <return> to quit---
        node = <value optimized out>
#10 0x00a45f96 in wxObjectList::Append (this=0x8672600, event=...)
    at ../include/wx/list.h:1185
No locals.
#11 wxEvtHandler::AddPendingEvent (this=0x8672600, event=...)
    at ../src/common/event.cpp:1143
        eventCopy = <value optimized out>
        __FUNCTION__ = "AddPendingEvent"
#12 0x0015ad60 in wxSocketBase::OnRequest (this=0x9292ee0,
    notification=wxSOCKET_OUTPUT) at ../src/common/socket.cpp:1006
        event = {<wxEvent> = {<wxObject> = {_vptr.wxObject = 0x866b788,
              static ms_classInfo = {m_className = 0xa74d98 L"wxObject",
                m_objectSize = 8, m_objectConstructor = 0, m_baseInfo1 = 0x0,
                m_baseInfo2 = 0x0, static sm_first = 0x7728cc,
                m_next = 0xaca8a4, static sm_classTable = 0x8860008},
              m_refData = 0x0}, m_eventObject = 0x9292ee0,
            m_eventType = 10002, m_timeStamp = 0, m_id = 6123,
            m_callbackUserData = 0x0, m_propagationLevel = 0,
            m_skipped = false, m_isCommandEvent = false,
            static ms_classInfo = {m_className = 0xa86590 L"wxEvent",
              m_objectSize = 36, m_objectConstructor = 0,
              m_baseInfo1 = 0xaca838, m_baseInfo2 = 0x0,
              static sm_first = 0x7728cc, m_next = 0xacb8e8,
---Type <return> to continue, or q <return> to quit---
              static sm_classTable = 0x8860008}}, m_event = wxSOCKET_OUTPUT,
          m_clientData = 0x0, static ms_classInfo = {
            m_className = 0x162f80 L"wxSocketEvent", m_objectSize = 44,
            m_objectConstructor = 0x1595e0 <wxSocketEvent::wxCreateObject()>,
            m_baseInfo1 = 0xacb900, m_baseInfo2 = 0x0,
            static sm_first = 0x7728cc, m_next = 0x16c54c,
            static sm_classTable = 0x8860008}}
        flag = <value optimized out>
#13 0x0015ae54 in wx_socket_callback (notification=GSOCK_OUTPUT,
    cdata=0x9292ee0 "\350\206?\b") at ../src/common/socket.cpp:942
No locals.
#14 0x0016027b in GSocket::Detected_Write (this=0xb2bf1f8)
    at ../src/unix/gsocket.cpp:1836
No locals.
#15 0x00f47927 in _GSocket_GDK_Input (data=0xb2bf1f8, source=139,
    condition=GDK_INPUT_WRITE) at ../src/gtk/gsockgtk.cpp:41
No locals.
#16 0x00cf4f7c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
No symbol table info available.
#17 0x06670d5b in ?? () from /lib/libglib-2.0.so.0
No symbol table info available.
#18 0x06639e78 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
No symbol table info available.
---Type <return> to continue, or q <return> to quit---
#19 0x0663d720 in ?? () from /lib/libglib-2.0.so.0
No symbol table info available.
#20 0x0663db8f in g_main_loop_run () from /lib/libglib-2.0.so.0
No symbol table info available.
#21 0x049b8419 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#22 0x00f45ec8 in wxEventLoop::Run (this=0x92c4578)
    at ../src/gtk/evtloop.cpp:76
        __FUNCTION__ = "Run"
        exitcode = <value optimized out>
#23 0x00fe72ac in wxAppBase::MainLoop (this=0x888fee0)
    at ../src/common/appcmn.cpp:312
        mainLoop = {<wxEventLoopPtr> = {m_ptr = 0x92c4578}, m_pp = 0x888ff20,
          m_pOld = 0x0}
#24 0x00fe7001 in wxAppBase::OnRun (this=0x0) at ../src/common/appcmn.cpp:367
No locals.
#25 0x009cf3ea in wxEntry (argc=@0xac96ac, argv=0x887e470)
    at ../src/common/init.cpp:460
No locals.
#26 0x009cf497 in wxEntry (argc=@0xbffff440, argv=0xbffff4e4)
    at ../src/common/init.cpp:472
No locals.
#27 0x08252a1b in main (argc=1, argv=0xbffff4e4) at amule-gui.cpp:94
---Type <return> to continue, or q <return> to quit---
No locals.

(gdb) thread apply all bt full

Code: [Select]

Thread 6 (Thread 0xb7eaeb70 (LWP 4826)):
#0  0x0093d422 in __kernel_vsyscall ()
No symbol table info available.
#1  0x00b8aba6 in poll () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#2  0x059f0cc2 in ?? () from /usr/lib/libpulse.so.0
No symbol table info available.
#3  0x059dde09 in pa_mainloop_poll () from /usr/lib/libpulse.so.0
No symbol table info available.
#4  0x059dfc23 in pa_mainloop_iterate () from /usr/lib/libpulse.so.0
No symbol table info available.
#5  0x059dfcf4 in pa_mainloop_run () from /usr/lib/libpulse.so.0
No symbol table info available.
#6  0x059f0bc3 in ?? () from /usr/lib/libpulse.so.0
No symbol table info available.
#7  0x05a95ac2 in ?? () from /usr/lib/libpulsecommon-0.9.19.so
No symbol table info available.
#8  0x0089d80e in start_thread () from /lib/tls/i686/cmov/libpthread.so.0
No symbol table info available.
#9  0x00b987ee in clone () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.

---Type <return> to continue, or q <return> to quit---
Thread 5 (Thread 0xb63e5b70 (LWP 4825)):
#0  0x0093d422 in __kernel_vsyscall ()
No symbol table info available.
#1  0x008a2142 in pthread_cond_timedwait@@GLIBC_2.3.2 ()
   from /lib/tls/i686/cmov/libpthread.so.0
No symbol table info available.
#2  0x00a41a3e in wxConditionInternal::WaitTimeout (this=0x89279c0,
    milliseconds=100) at ../src/unix/threadpsx.cpp:405
        tspec = {tv_sec = 1261500610, tv_nsec = 860000000}
        err = <value optimized out>
#3  0x00a41aca in wxCondition::WaitTimeout (this=0x92ae81c, milliseconds=100)
    at ../include/wx/thrimpl.cpp:256
        __FUNCTION__ = "WaitTimeout"
#4  0x00a437a4 in wxSemaphoreInternal::WaitTimeout (this=0x92ae818,
    milliseconds=100) at ../src/unix/threadpsx.cpp:552
        remainingTime = <value optimized out>
        locker = {m_isOk = true, m_mutex = @0x92ae818}
#5  0x00a4382a in wxSemaphore::WaitTimeout (this=0x9113138, milliseconds=100)
    at ../include/wx/thrimpl.cpp:320
        __FUNCTION__ = "WaitTimeout"
#6  0x0834c472 in CTimerThread::Entry (this=0x9113118) at Timer.cpp:66
        now = <value optimized out>
        delta = 0
---Type <return> to continue, or q <return> to quit---
        evt = {<wxEvent> = {<wxObject> = {_vptr.wxObject = 0x84db408,
              static ms_classInfo = {m_className = 0xa74d98 L"wxObject",
                m_objectSize = 8, m_objectConstructor = 0, m_baseInfo1 = 0x0,
                m_baseInfo2 = 0x0, static sm_first = 0x7728cc,
                m_next = 0xaca8a4, static sm_classTable = 0x8860008},
              m_refData = 0x0}, m_eventObject = 0x0, m_eventType = 10244,
            m_timeStamp = 0, m_id = 6128, m_callbackUserData = 0x0,
            m_propagationLevel = 0, m_skipped = false,
            m_isCommandEvent = false, static ms_classInfo = {
              m_className = 0xa86590 L"wxEvent", m_objectSize = 36,
              m_objectConstructor = 0, m_baseInfo1 = 0xaca838,
              m_baseInfo2 = 0x0, static sm_first = 0x7728cc,
              m_next = 0xacb8e8,
              static sm_classTable = 0x8860008}}, <No data fields>}
        lastEvent = 3075193032
#7  0x00a449e3 in wxThreadInternal::PthreadStart (thread=0x9113118)
    at ../src/unix/threadpsx.cpp:766
        pthread = 0x92cc958
        rc = <value optimized out>
        dontRunAtAll = false
        __FUNCTION__ = "PthreadStart"
#8  0x00a44aed in wxPthreadStart (ptr=0x9113118)
    at ../src/unix/threadpsx.cpp:718
---Type <return> to continue, or q <return> to quit---
No locals.
#9  0x0089d80e in start_thread () from /lib/tls/i686/cmov/libpthread.so.0
No symbol table info available.
#10 0x00b987ee in clone () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.

Thread 3 (Thread 0xb73e8b70 (LWP 4823)):
#0  0x0093d422 in __kernel_vsyscall ()
No symbol table info available.
#1  0x008a5466 in nanosleep () from /lib/tls/i686/cmov/libpthread.so.0
No symbol table info available.
#2  0x00a4b468 in wxMicroSleep (microseconds=1000000)
    at ../src/unix/utilsunx.cpp:191
        tmReq = {tv_sec = 1, tv_nsec = 0}
#3  0x00a4b491 in wxMilliSleep (milliseconds=1000)
    at ../src/unix/utilsunx.cpp:212
No locals.
#4  0x00a4176d in wxThread::Sleep (milliseconds=1000)
    at ../src/unix/threadpsx.cpp:986
No locals.
#5  0x081c5858 in UploadBandwidthThrottler::Entry (this=0x8fa5e78)
    at UploadBandwidthThrottler.cpp:323
        timeSinceLastLoop = 0
---Type <return> to continue, or q <return> to quit---
        minFragSize = 1300
        doubleSendSize = 2600
        sleepTime = 1000
        thisLoopTick = 3075192409
        bytesToSpend = <value optimized out>
        extraSleepTime = 1000
        lastLoopTick = 3075192409
        allowedDataRate = 3072000
        rememberedSlotCounter = 87
        sendLock = {m_isOk = 184, m_mutex = @0x0}
#6  0x00a449e3 in wxThreadInternal::PthreadStart (thread=0x8fa5e78)
    at ../src/unix/threadpsx.cpp:766
        pthread = 0x8fce970
        rc = <value optimized out>
        dontRunAtAll = false
        __FUNCTION__ = "PthreadStart"
#7  0x00a44aed in wxPthreadStart (ptr=0x8fa5e78)
    at ../src/unix/threadpsx.cpp:718
No locals.
#8  0x0089d80e in start_thread () from /lib/tls/i686/cmov/libpthread.so.0
No symbol table info available.
#9  0x00b987ee in clone () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
---Type <return> to continue, or q <return> to quit---

Thread 1 (Thread 0xb7fdd760 (LWP 4807)):
#0  0x0093d422 in __kernel_vsyscall ()
No symbol table info available.
#1  0x00af64d1 in raise () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#2  0x00af9932 in abort () from /lib/tls/i686/cmov/libc.so.6
No symbol table info available.
#3  0x0834fecd in OnUnhandledException () at MuleDebug.cpp:103
        t = 0x0
        output = 0xc0c560
#4  0x0082f415 in ?? () from /usr/lib/libstdc++.so.6
No symbol table info available.
#5  0x0082f452 in std::terminate() () from /usr/lib/libstdc++.so.6
No symbol table info available.
#6  0x0082f591 in __cxa_throw () from /usr/lib/libstdc++.so.6
No symbol table info available.
#7  0x0082fc0f in operator new(unsigned int) () from /usr/lib/libstdc++.so.6
No symbol table info available.
#8  0x009c7633 in wxObjectList::CreateNode (this=0x90c8ec0, prev=0x4c294ab0,
    next=0x0, data=0x4c294af0, key=...) at ../include/wx/list.h:1185
No locals.
#9  0x009dc6b9 in wxListBase::Append (this=0x90c8ec0, object=0x4c294af0)
---Type <return> to continue, or q <return> to quit---
    at ../src/common/list.cpp:244
        __FUNCTION__ = "Append"
        node = <value optimized out>
#10 0x00a45f96 in wxObjectList::Append (this=0x8672600, event=...)
    at ../include/wx/list.h:1185
No locals.
#11 wxEvtHandler::AddPendingEvent (this=0x8672600, event=...)
    at ../src/common/event.cpp:1143
        eventCopy = <value optimized out>
        __FUNCTION__ = "AddPendingEvent"
#12 0x0015ad60 in wxSocketBase::OnRequest (this=0x9292ee0,
    notification=wxSOCKET_OUTPUT) at ../src/common/socket.cpp:1006
        event = {<wxEvent> = {<wxObject> = {_vptr.wxObject = 0x866b788,
              static ms_classInfo = {m_className = 0xa74d98 L"wxObject",
                m_objectSize = 8, m_objectConstructor = 0, m_baseInfo1 = 0x0,
                m_baseInfo2 = 0x0, static sm_first = 0x7728cc,
                m_next = 0xaca8a4, static sm_classTable = 0x8860008},
              m_refData = 0x0}, m_eventObject = 0x9292ee0,
            m_eventType = 10002, m_timeStamp = 0, m_id = 6123,
            m_callbackUserData = 0x0, m_propagationLevel = 0,
            m_skipped = false, m_isCommandEvent = false,
            static ms_classInfo = {m_className = 0xa86590 L"wxEvent",
              m_objectSize = 36, m_objectConstructor = 0,
---Type <return> to continue, or q <return> to quit---
              m_baseInfo1 = 0xaca838, m_baseInfo2 = 0x0,
              static sm_first = 0x7728cc, m_next = 0xacb8e8,
              static sm_classTable = 0x8860008}}, m_event = wxSOCKET_OUTPUT,
          m_clientData = 0x0, static ms_classInfo = {
            m_className = 0x162f80 L"wxSocketEvent", m_objectSize = 44,
            m_objectConstructor = 0x1595e0 <wxSocketEvent::wxCreateObject()>,
            m_baseInfo1 = 0xacb900, m_baseInfo2 = 0x0,
            static sm_first = 0x7728cc, m_next = 0x16c54c,
            static sm_classTable = 0x8860008}}
        flag = <value optimized out>
#13 0x0015ae54 in wx_socket_callback (notification=GSOCK_OUTPUT,
    cdata=0x9292ee0 "\350\206?\b") at ../src/common/socket.cpp:942
No locals.
#14 0x0016027b in GSocket::Detected_Write (this=0xb2bf1f8)
    at ../src/unix/gsocket.cpp:1836
No locals.
#15 0x00f47927 in _GSocket_GDK_Input (data=0xb2bf1f8, source=139,
    condition=GDK_INPUT_WRITE) at ../src/gtk/gsockgtk.cpp:41
No locals.
#16 0x00cf4f7c in ?? () from /usr/lib/libgdk-x11-2.0.so.0
No symbol table info available.
#17 0x06670d5b in ?? () from /lib/libglib-2.0.so.0
No symbol table info available.
---Type <return> to continue, or q <return> to quit---
#18 0x06639e78 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
No symbol table info available.
#19 0x0663d720 in ?? () from /lib/libglib-2.0.so.0
No symbol table info available.
#20 0x0663db8f in g_main_loop_run () from /lib/libglib-2.0.so.0
No symbol table info available.
#21 0x049b8419 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
No symbol table info available.
#22 0x00f45ec8 in wxEventLoop::Run (this=0x92c4578)
    at ../src/gtk/evtloop.cpp:76
        __FUNCTION__ = "Run"
        exitcode = <value optimized out>
#23 0x00fe72ac in wxAppBase::MainLoop (this=0x888fee0)
    at ../src/common/appcmn.cpp:312
        mainLoop = {<wxEventLoopPtr> = {m_ptr = 0x92c4578}, m_pp = 0x888ff20,
          m_pOld = 0x0}
#24 0x00fe7001 in wxAppBase::OnRun (this=0x0) at ../src/common/appcmn.cpp:367
No locals.
#25 0x009cf3ea in wxEntry (argc=@0xac96ac, argv=0x887e470)
    at ../src/common/init.cpp:460
No locals.
#26 0x009cf497 in wxEntry (argc=@0xbffff440, argv=0xbffff4e4)
    at ../src/common/init.cpp:472
---Type <return> to continue, or q <return> to quit---
No locals.
#27 0x08252a1b in main (argc=1, argv=0xbffff4e4) at amule-gui.cpp:94
No locals.


[Stu Redman]

So that wasn't it either. 

[RRM]

At least the code gets cleaned up 

[RRM]

...and the more you clean up that is not the culprit,
the closer we get to finding what IS

[Vollstrecker]

I'm afraid of the moment when this bug is solved, and all the cleaned up code that had nothing to do with it explodes, or kills the network or something. Huh, you think it's possible that we get a bug that makes the clients of these network poiseners crash?

[btkaos]

I'm afraid of the moment when this bug is solved, and all the cleaned up code that had nothing to do with it explodes, or kills the network or something.

So far, including the clean ups is an orthogonal issue to the bugs. If the cleanups doesn't meet some quality criteria, just don't commit them.

Anyways, this is a consequence of the poor development model that the closed svn imposes. For instance, if we'd use git, creating a cleanup branch a testing it would be easy cake.

Another problem with aMule is that wx + gtk + x11 is a poor toolkit in comparison with my favorite one: QT. I had to dig deep in the code and I was not happy with what I saw, specially in the gtk side. GTK is certainly an amateurish-coded toolkit, whatever the hype the have built around it, just see the support it has for concurrency. WX may be a little bit better, but in some places is half-finished, sometimes lacks documentation and proper structuring of layers, and has aberrations like WxString.

No surprise aMule is so fragile.

I say all the above with a big IMVHO and big respect for developers.  That is to say, I don't think I could code something better. I don't want to troll, that's just my what I think. In fact I want to thank all WX and GTK developers for their code, I just think we can do better.

Huh, you think it's possible that we get a bug that makes the clients of these network poiseners crash?

I'm afraid I don't understand what you mean. If you mean the clients of anti-emule business, they are custom coded and I guess they wouldn't take too much impact. More successful attacks against those guys where based just on hacking their [Windows] computers and networks.

[Vollstrecker]

Svn vs. git: there is something like a git-mirror of amule, and svn should be able to do something like this, too. But why? That's what the development version is for.

gtk vs. qt: I you compare wx + gtk with just qt it's a bit unfair, because there is no layer in between. I work with kdelibs + qt and like every project, beginning is hard. But even a poor widgetset is no excuse for, let's call it, unclean code, so the problems of the past have it's origin somewhere else.

My whole post and especially anti-emule: Adjust your sarcasm-detector and answer with a smiley.

[btkaos]