aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: 1 ... 26 27 [28] 29 30 ... 37

Author Topic: RRM's epic struggle for a better aMule on high-speed connections  (Read 198809 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #405 on: December 27, 2009, 06:16:05 PM »
Hi RRM,
another attempt, please try it out.

Code: [Select]
Index: EMSocket.cpp
===================================================================
--- EMSocket.cpp (revision 9905)
+++ EMSocket.cpp (working copy)
@@ -527,7 +527,8 @@
     uint32 sentStandardPacketBytesThisCall = 0;
     uint32 sentControlPacketBytesThisCall = 0;
 
-    if(byConnected == ES_CONNECTED && IsEncryptionLayerReady() && !(m_bBusy && onlyAllowedToSendControlPacket)) {
+    if(byConnected == ES_CONNECTED && IsEncryptionLayerReady() && !m_bBusy) {
 
  //printf("* Internal attemptto send on %p\n", this);       
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #406 on: December 27, 2009, 07:03:18 PM »
Thank you Stu.
I replaced the EMSocket.cpp file in ~/tmp/amule-stu/src by your version.
Then i called:
Code: [Select]
$ cd ~/tmp/amule-stu
$ ./configure --prefix=/usr/local/stow/amule-opt/ --enable-geoip --enable-optimize --enable-debug --with-wxdebug --mandir=/share/bin
$ make clean
$ make -j 2 && sudo make install
and to make this version the default aMule:
Code: [Select]
$ cd /usr/local/stow
$ sudo stow -D amule-stu-opt-debug
$ sudo stow amule-opt
« Last Edit: December 27, 2009, 07:18:04 PM by RRM »
Logged

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #407 on: December 28, 2009, 06:39:08 AM »
Wow, ive left aMule running at full speed all night, and its still running!  ::)
However, there is a steady build up of VSZ,
so i expect her to crash anyway...  :(

$ ps axl | grep amule
Code: [Select]
0  1000 15089 15058  20   0 144872 130248 rt_sig S   pts/0      0:02 gdb amule
0  1000 15091 15089  20   0 290976 168436 poll_s Sl+ pts/0      6:53 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 302688 180104 poll_s Sl+ pts/0     17:29 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 303096 179692 poll_s Sl+ pts/0     19:45 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 306292 183356 -     Rl+  pts/0     26:43 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 312472 189260 poll_s Sl+ pts/0     31:58 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 316072 190000 sync_p Dl+ pts/0     40:12 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 333092 201536 -     Rl+  pts/0     80:07 /usr/local/stow/amule-opt/bin/amule
0  1000 15091 15089  20   0 340112 205092 -     Rl+  pts/0    183:19 /usr/local/stow/amule-opt/bin/amule
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #408 on: December 28, 2009, 01:23:57 PM »
28 pages and finally a glimpse of hope.  :D
The remaining raise may be because of KAD. It accumulates data over time, and there is also a problem of fake content spam.
Keep it running, let's see what happens.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #409 on: December 28, 2009, 06:37:46 PM »
HUH ? ::)?? ::) ??

Coming home from work, I expected aMule to have crashed,
but guess what?
Not just a glimpse of hope....
ITS STILL RUNNING LIKE MAD!!!!!!!  :) ;D 8) :) ;D 8)

Logged

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #410 on: December 28, 2009, 06:40:46 PM »
Im not courageous enough to actually say it, but...
Maybe you really... ?

VSZ is still going up very slowly though ...
Shouldnt it plateau somewhere? Or does KAD continuously cause it to grow?
(and therefore cause a crash eventually?)
Its at 357048 KB now. It was at 340112 this morning.
Usually VSZ started growing exponentially once it grew bigger than 250000 or 300000 max.
« Last Edit: December 28, 2009, 06:50:10 PM by RRM »
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #411 on: December 28, 2009, 06:59:05 PM »
Hehe, maybe I really. But lets wait a little longer.  :D
I think it should plateau after like 24h, with some residual (but minimal) growth.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #412 on: December 28, 2009, 07:56:12 PM »
24 hours?
But thats now already...
or do you mean CPU time?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #413 on: December 28, 2009, 08:16:14 PM »
Well, it almost has plateaued.
One exception for example is the log message window, which simply grows and grows. And there are more, but it shouldn't really matter.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #414 on: December 28, 2009, 08:24:45 PM »
True.
VSZ has not increased at all in the last 30 minutes,
so i will add a few extra popular downloads....
Logged

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #415 on: December 29, 2009, 10:06:53 AM »
I.N.C.R.E.D.I.B.L.E...

aMule is still running.
it doesnt matter how much i ask of her,
the mule just does it...
Is this still a mule, or is it aHorse?

Stu, could you please explain what the change is that you made?
in such a way that people like me can understand?
Im very curious...

(VSZ is 396216 KB)
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #416 on: December 29, 2009, 02:24:04 PM »
aMule has a thread for uploading (called "UploadBandwidthThrottler"). This thread continuously feeds data to all uploading sockets (a socket is a network connection).
When data is fed to a socket it can either be sent right away, or the socket replies that it is busy at the moment (still uploading the last packet). In that case the socket is marked as busy and the data will be sent later in the background. (When its finished it triggers an event that marks the socket as not busy again.)
Now, what happens if the upload thread tries to feed data to a already busy socket? It should recognize it's busy and skip it. This worked only for control packets however. Data packets just got fed and fed and so queued up more and more in the socket's internal queue until finally the memory was exhausted.
I simply enabled the busy-check for all packets. I have no idea why it was limited to control packets in the first place. This was unmodified code from eMule.

Now I can't say if I managed to explain it well enough for you can understand, but I don't know how to put it simpler.  :)

Commited in 9913. RRM, I want to thank you for your unending patience that made it possible to finally fix that bug.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #417 on: December 29, 2009, 03:08:06 PM »
You explained it perfectly well. Thank you. Im glad it has been committed.
I was surprised that you thank me, because its you guys who made and make aMule possible.
Im just a persistent user who keeps asking for help and got helped very, very, very much by you and btkaos in particular.
One cannot get any better help than that.
Thanks to you guys aMule worked, and now works even much better. Thank you.

Since this was unmodified code from eMule,
and since i experienced the same issues when i still used eMule,
and with me many other users,
shouldnt you notify the guys behind eMule,
so that they can fix this error as well?
That might help a lot of eMule users, no?

Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #418 on: December 29, 2009, 04:10:56 PM »
You're welcome! Hey, we need more users like you anyway for the network.  :D

I've notified them. It may well be however that the underlying networking layer in Windows behaves differently than wxWidgets/Linux, so eMule may not be involved. You don't happen to have a Windows box to check it out?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

RRM

  • Sr. Member
  • ****
  • Karma: 40
  • Offline Offline
  • Posts: 444
Re: RRM's epic struggle for a better aMule on high-speed connections
« Reply #419 on: December 29, 2009, 04:21:58 PM »
Good post Stu.

Quote
You don't happen to have a Windows box to check it out?

You mean a windows installation, and not Wine, right?
No, but i have a windows XP CD, so i can install it, of course...
Is that what you are suggesting?
If so, should i do it in a specific way?
Logged
Pages: 1 ... 26 27 [28] 29 30 ... 37
« previous next »