aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: eMule 0.50a - what to import ?  (Read 11382 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
eMule 0.50a - what to import ?
« on: April 15, 2010, 03:11:06 PM »

Just noticed that there is a new eMule version 0.50a. What features should we import?
I suggest
  • ED2K links handling (always with AICH)
  • drop Kad 1
  • check connections from the settings dialog
  • tabbed file detail dialog
I'll keep this first post updated if more features are agreed or disagreed on.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

gav616

  • Guest
Re: eMule 0.50a - what to import ?
« Reply #1 on: April 19, 2010, 07:00:28 PM »

My vote is all of the above especially dropping Kad1/ed2k, double hashing algorithms and tabbed file detail dialog.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: eMule 0.50a - what to import ?
« Reply #2 on: April 19, 2010, 08:17:48 PM »

Dropping ED2K is not an option.  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

gav616

  • Guest
Re: eMule 0.50a - what to import ?
« Reply #3 on: April 19, 2010, 08:37:08 PM »

Dropping ED2K is not an option.  :)
haha oops. :D
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: eMule 0.50a - what to import ?
« Reply #4 on: April 19, 2010, 10:26:42 PM »

Dropping ED2K is not an option.  :)

Why? Drop eD2k, Kad1, Kad2 and we have a nice maintainable app ;)

Seriously, I'll take care of the Kademlia part. (not the dropping, the porting, I mean)

Candidates to the list from v0.49c:
- single shared files
- kad search keyword reordering
« Last Edit: April 19, 2010, 10:28:33 PM by GonoszTopi »
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: eMule 0.50a - what to import ?
« Reply #5 on: April 20, 2010, 10:37:56 PM »

Why? Drop eD2k, Kad1, Kad2 and we have a nice maintainable app ;)
Actually I would drop ED2K, but there is no need to while people are still using it. It can wait until eMule drops it (in 1.0 probably...)

- single shared files
If Marcell is already stirring up the shares he could also add this while he's at it.  :)
Quote
- kad search keyword reordering
What's that?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

elcamilo

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 48
    • Proarci
Re: eMule 0.50a - what to import ?
« Reply #6 on: April 21, 2010, 10:33:13 AM »

I vote 'tabbed file detail dialog', very handy and useful. But don't known what mean 'drop Kad 1', I did not saw it in eMule.

However I wish you consider to add captchas to aMule as you already discuss here:

http://forum.amule.org/index.php?topic=15811.0

My position is: add captchas, or remove messages window.
regards.

EDIT: sorry, i didn't read captchas were included in 2.3.0
« Last Edit: April 21, 2010, 10:38:45 AM by elcamilo »
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: eMule 0.50a - what to import ?
« Reply #7 on: April 21, 2010, 12:02:39 PM »

Quote
- kad search keyword reordering
What's that?

Code: [Select]
             // figure out if we can use a better keyword than the one the user selected
             // for example most user will search like this "The oxymoronaccelerator 2", which would ask the node which indexes "the"
             // This causes higher traffic for such nodes and makes them a viable target to attackers, while the kad result should be
             // the same or even better if we ask the node which indexes the rare keyword "oxymoronaccelerator", so we try to rearrenge
             // keywords and generally assume that the longer keywords are rarer
Logged
concordia cum veritate

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: eMule 0.50a - what to import ?
« Reply #8 on: April 21, 2010, 01:45:47 PM »

I completely know who wrote that JUST by the word oxymoronaccelerator.
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: eMule 0.50a - what to import ?
« Reply #9 on: April 21, 2010, 03:39:15 PM »

- single shared files
If Marcell is already stirring up the shares he could also add this while he's at it.  :)
For that to happen Marcell would have to know what "single shared files" means.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: eMule 0.50a - what to import ?
« Reply #10 on: April 21, 2010, 03:46:37 PM »

- single shared files
If Marcell is already stirring up the shares he could also add this while he's at it.  :)
For that to happen Marcell would have to know what "single shared files" means.
I'll tell you when you finish what you're currently working on. 8)
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: eMule 0.50a - what to import ?
« Reply #11 on: April 21, 2010, 08:32:45 PM »

But don't known what mean 'drop Kad 1', I did not saw it in eMule.
It's the old version of the Kad protocol which has been obsolete for some years. Dropping it will simplify the code (and force users of old clients to update, since they are getting shut out as more and more eMule and aMule users update).

Code: [Select]
             // so we try to rearrenge
             // keywords and generally assume that the longer keywords are rarer
I don't like that. If I search for, say, "Kry nudes" the longer keyword is not rarer and I won't find what I want.

I completely know who wrote that JUST by the word oxymoronaccelerator.
Yeah, rings a bell.
Rather than simply acquiescing to this byzantine monoculture, I believe it to be prudent

For that to happen Marcell would have to know what "single shared files" means.
Allow selection of files and not only directories, so you don't always have to share all files in a directory.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: eMule 0.50a - what to import ?
« Reply #12 on: April 21, 2010, 10:56:17 PM »

- single shared files
If Marcell is already stirring up the shares he could also add this while he's at it.  :)
For that to happen Marcell would have to know what "single shared files" means.
I'll tell you when you finish what you're currently working on. 8)
If you refer to the hashing progress: it's completed. I simply can't commit it, because it involves changes in DownloadListCtrl, which is locked by you know who.
Logged

gav616

  • Guest
Re: eMule 0.50a - what to import ?
« Reply #13 on: April 22, 2010, 01:37:53 AM »

I say we give the emule team something to think about and take the first steps and drop 'eD2k'!  
..just think about all that smelly old code being taken out (include Kad1 in that) :D


p.s.

slight joking aside, I wonder how many users actually need/use eD2k now?

maybe a serious discussion  in 'Development' corner would be a good idea
« Last Edit: April 22, 2010, 01:43:48 AM by gav616 »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: eMule 0.50a - what to import ?
« Reply #14 on: April 22, 2010, 04:41:06 AM »

- single shared files
If Marcell is already stirring up the shares he could also add this while he's at it.  :)
For that to happen Marcell would have to know what "single shared files" means.
I'll tell you when you finish what you're currently working on. 8)
If you refer to the hashing progress: it's completed. I simply can't commit it, because it involves changes in DownloadListCtrl, which is locked by you know who.

That's cool. You may ask other people to not break locks, too :D
Logged
Pages: [1] 2