aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: Theming wxListCtrl  (Read 6087 times)

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Theming wxListCtrl
« on: May 21, 2010, 10:53:05 AM »

Hi, i'm using amule under linux and with the current GTK+ theme there's a visibility issue with the wxListCtrl in the Tranfers page.
Since the foreground text color is white and the background item color is light grey, it becomes hard to read the text while selecting the list item.
There's a way to theme it and change the color within gtkrc?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Theming wxListCtrl
« Reply #1 on: May 21, 2010, 04:04:09 PM »

You are using 2.2.6?
This should be fixed in the SVN version.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5898
Re: Theming wxListCtrl
« Reply #2 on: May 21, 2010, 06:02:42 PM »

That was my fix, wasn't it? We should probably backport it as a patch and post it somewhere.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Theming wxListCtrl
« Reply #3 on: May 21, 2010, 06:27:13 PM »

Better get 2.3 released. There are more pressing issues than light text in strange themes.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Re: Theming wxListCtrl
« Reply #4 on: May 21, 2010, 07:28:34 PM »

I'm using 2.2.1 it's what i have in debian stable.
I'll try the backport to see if fixes it.
thanks

ps. the strange theme is murrine  neographite :p
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 163
  • Offline Offline
  • Posts: 2688
Re: Theming wxListCtrl
« Reply #5 on: May 25, 2010, 12:04:52 AM »

That was my fix, wasn't it? We should probably backport it as a patch and post it somewhere.
Quite an easy one: http://repo.or.cz/w/amule.git/commitdiff/f5414771ba0da3e2f3811e3664ac1383d904f430

"Backported":
Code: [Select]
Index: src/extern/wxWidgets/listctrl.cpp
===================================================================
--- src/extern/wxWidgets/listctrl.cpp   (revision 10182)
+++ src/extern/wxWidgets/listctrl.cpp   (working copy)
@@ -5784,7 +5784,7 @@
 #else
     wxUnusedVar(variant);
     wxVisualAttributes attr;
-    attr.colFg = wxSystemSettings::GetColour(wxSYS_COLOUR_WINDOWTEXT);
+    attr.colFg = wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOXTEXT);
     attr.colBg = wxSystemSettings::GetColour(wxSYS_COLOUR_LISTBOX);
     attr.font  = wxSystemSettings::GetFont(wxSYS_DEFAULT_GUI_FONT);
     return attr;
Logged
concordia cum veritate

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Re: Theming wxListCtrl
« Reply #6 on: May 25, 2010, 08:34:35 AM »

This patch requires a newer wxWidgets which isn't available in debian stable.

http://trac.wxwidgets.org/ticket/10089

I fixed it changing the background colour to wxSYS_COLOUR_BTNSHADOW
Logged

Vollstrecker

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 65
  • Offline Offline
  • Posts: 1471
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Theming wxListCtrl
« Reply #7 on: May 25, 2010, 11:00:29 AM »

In my repo is a new enough wx-version that is tested to not make any problems on upgrading to the next stable.
Logged
Homefucking is killing prostitution

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Re: Theming wxListCtrl
« Reply #8 on: May 25, 2010, 11:10:17 AM »

Yeah, unluckily i couldn't use your cool repository because i'm on AMD64.
Do you plan to release amd64 packages too? :-)

cheers
« Last Edit: May 25, 2010, 11:13:30 AM by iwkse »
Logged

Vollstrecker

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 65
  • Offline Offline
  • Posts: 1471
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Theming wxListCtrl
« Reply #9 on: May 25, 2010, 12:21:20 PM »

Only when someone donates the pkg's. I host everything usefull I get, but I don't fiddle around with crosscompiling. If you want to help, I can give you the needed instructions.
Logged
Homefucking is killing prostitution

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Re: Theming wxListCtrl
« Reply #10 on: May 25, 2010, 01:32:40 PM »

Okey, tell me how to do and i'll try these days to build amd64 packages.
Logged

Vollstrecker

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 65
  • Offline Offline
  • Posts: 1471
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Theming wxListCtrl
« Reply #11 on: May 26, 2010, 10:18:00 AM »

It's not that hard. Just take the diff.gz and orig.tar.gz from my repo, and save them in a folder. Then you call dpkg-source -x <diff-file>, remove the .diff-file, go into the newly created dir, open debian/changelog and put an entry on top of it, with a new version number (-2 or something). You can copy the last entry for keeping the right format. Then just run "dpkg-buildpackage -us -uc -rfakeroot" (if you want to sign them yourself, omit -uc -uk, and set -k<key_id>". When all went fine, sent me the new.diff, .changes and the debs.
Logged
Homefucking is killing prostitution

iwkse

  • Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 10
    • http://www.myspace.com/rule6elur
Re: Theming wxListCtrl
« Reply #12 on: May 26, 2010, 12:14:28 PM »

Ok, i'm building the packages, i'll post the links in here when they are ready.

thanks
ps. Beside amule i need to package also wxwidgets because of dependencies
Logged

Vollstrecker

  • Global Moderator
  • Hero Member
  • *****
  • Karma: 65
  • Offline Offline
  • Posts: 1471
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Theming wxListCtrl
« Reply #13 on: May 26, 2010, 05:31:41 PM »

I thought you're talking about wx, but they work both the same way.
Logged
Homefucking is killing prostitution
Pages: [1] 2