aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Allow Context Menu Resume Even when Active Files Are Selected  (Read 5020 times)

kristof

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20

I would like to be able to quickly select a block of files with a shift and click operation, right click for the context menu, and choose "resume."  The problem is that aMule removes the "resume" option from the context menu if I have selected any files that are already active.  Pretty smart but it makes more work for me.  I must control-click on every file that is active to remove it from the multiple selection before I can resume.

My request is to always allow the "resume" option so long as at least one file of a multiple selection is inactive.  aMule should be smart enough to resume only the files that can be resumed and do nothing for already active files.

I can make a patch for this against 2.3.1rc1 if it would be accepted.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Allow Context Menu Resume Even when Active Files Are Selected
« Reply #1 on: April 06, 2011, 10:23:07 PM »

You could always sort by status, so the resumable files are in one block.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Allow Context Menu Resume Even when Active Files Are Selected
« Reply #2 on: April 07, 2011, 09:31:33 PM »

I can make a patch for this against 2.3.1rc1 if it would be accepted.
First the patch, then we'll see about it. (I personally don't see anything bad in your request, so your patch could go on unless anyone vetoes it with a good reason.)
Logged
concordia cum veritate

kristof

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 20
Re: Allow Context Menu Resume Even when Active Files Are Selected
« Reply #3 on: April 29, 2011, 05:57:33 AM »

Ok, when I get around to doing it for myself I will produce a patch.  Unless amule code is doing some very strange things it should be a trivial change.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Allow Context Menu Resume Even when Active Files Are Selected
« Reply #4 on: April 29, 2011, 08:15:46 AM »

Haha. Ohboy. There goes another poor soul.

Make sure to check your sanity at the door before reading any code.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Allow Context Menu Resume Even when Active Files Are Selected
« Reply #5 on: April 29, 2011, 02:42:03 PM »

Don't scare off new volunteers like that.  ;)

And it really shouldn't be that hard. (No, I didn't check it out.)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon