aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Save file download status as it's changed?  (Read 2706 times)

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 317
Save file download status as it's changed?
« on: April 09, 2012, 05:31:30 PM »


At the moment a file's waiting/stopped status is only saved when amule is exited normally.

Which means that if amule crashes for any reason, any changes aren't saved (although priority changes are saved)

I think it'd be better to either periodically save the status of downloads, or save the setting as a partfile's status is toggled.


Similarly, the "Swap every A4AF to this file" setting isn't saved between sessions. Saving this would be a useful enhancement.

Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Save file download status as it's changed?
« Reply #1 on: April 09, 2012, 05:55:23 PM »

Paused/stopped/active should be saved once it is toggled, I agree. I'll take a look at it.

"Swap every A4AF to this file" is not a setting, only a temporary action and thus can't be saved.
If it were a setting, it could obviously hold only for one single download, or it would require extra priorities.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Save file download status as it's changed?
« Reply #2 on: April 09, 2012, 07:50:05 PM »

Fixed in 10771.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 317
Re: Save file download status as it's changed?
« Reply #3 on: April 11, 2012, 02:15:30 AM »

Thanks.

Are you planning on merging recent changes into ASIO branch?

Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Save file download status as it's changed?
« Reply #4 on: April 11, 2012, 01:58:57 PM »

I'm planning merging Asio branch into trunk.  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 317
Re: Save file download status as it's changed?
« Reply #5 on: April 12, 2012, 01:24:08 AM »

I'm sure many eagerly await. :)
Logged

stoatwblr

  • Sr. Member
  • ****
  • Karma: 12
  • Offline Offline
  • Posts: 317
Re: Save file download status as it's changed?
« Reply #6 on: June 17, 2012, 01:07:07 AM »

Fixed in 10771.

Damn.... It's fallen out somewhere between 10772 and 10788 :(

Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3830
  • Engines screaming
Re: Save file download status as it's changed?
« Reply #7 on: June 17, 2012, 10:26:34 AM »

Fix from 10771 is still there in the source. I checked.  ???
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

iz0bbz

  • Hero Member
  • *****
  • Karma: 57
  • Offline Offline
  • Posts: 766
  • Gort! Klaatu barada nikto!
Re: Save file download status as it's changed?
« Reply #8 on: June 17, 2012, 08:26:37 PM »

Damn.... It's fallen out somewhere between 10772 and 10788 :(
I was noticing this too in latest builds. It used to work, and now it doesn't.
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 164
  • Offline Offline
  • Posts: 2702
Re: Save file download status as it's changed?
« Reply #9 on: June 18, 2012, 09:15:21 PM »

Works here. Monolithic app, rev. 10792.
Logged
concordia cum veritate