Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[gnazio]

What about increasing the file buffer size limit?
The limit has been the same in about 10 years of development (considering emule too), and in the meanwhile PC's capacities (RAM/HD cache/...) are vastly improved.

[stoatwblr]

I believe that's the amount held in ram before committing to disk.

Is tweaking that a good idea? Linux/BSD already has their own disk write buffering anyway.

[Stu Redman]

It's hard to tweak, since I'm sure you won't notice any different behavior anyway.
And if you start with it, you need options to not waste4 memory on the embedded platforms and all that. I don't think it's worth the effort.

[darkbasic]

It helps preserving disk health, with modern connections you can fill a 1.5MB buffer in less than a second and ram isn't a problem anymore. You can keep the default and let power users customize it.

[darkbasic]

As I said you can keep the actual value as default but let peoples increase the buffer.

[ErstStavroBlofeld]

For anybody who wants to change it:

Got to the src folder and open the files and search for this lines.
Change the 15000 to 90000 and you have a max Buffer of 9MiB instead of 1.5MiB

PrefsUnifiedDlg.cpp:   

Code: [Select]

label = CFormat(wxPLURAL("File Buffer Size: %d byte", "File Buffer Size: %d bytes",
        event.GetPosition() * 15000)) % (event.GetPosition() * 15000);


Preferences.h:

Code: [Select]

static uint32 GetFileBufferSize() { return s_iFileBufferSize*15000; }
static void SetFileBufferSize(uint32 val) { s_iFileBufferSize = val/15000; }
[code]

This value should be outplaced as a constant.