aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Concerning aMule Derivations  (Read 3702 times)

themonk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 1
    • http://www.edn-project.org
Concerning aMule Derivations
« on: July 22, 2004, 04:14:28 PM »

xMule is attempting to become fully compliant with the GPL.  Thus in order to conform with the GPL Section 2a)
Quote
# a)  You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change.
we are attempting to isolate any and all projects from which xMule code has been derived.

We are fairly sure that the aMule devs have a fairly good understanding of what code xMule has copied from them, as they have frequently made reference to our CVS and the fact that we have copied the code.
If you could please submit at the minimum files that contain aMule-derived code, and hopefully the functions or even line numbers, it will greatly increase the "prominent display" of "such and such is derived from aMule" throughout the runtime of xMule, thus helping your project with publicity and xMule with compliance and licensing matters.

Please submit any and all information either to hopeseekr@xmule.ws or via the SourceForge support ticket system https://gna.org/support/?func=additem&group=xmule

Sincerely,
The xMule Team
Logged

Xaignar

  • Admin and Code Junky
  • Hero Member
  • *****
  • Karma: 19
  • Offline Offline
  • Posts: 1103
Re: Concerning aMule Derivations
« Reply #1 on: July 22, 2004, 04:50:05 PM »

Uhm, you want us to tell you what code you have copied from us? Wouldn't it be more efficent and safe to ask the xMule devs? It's not like we are doing code-reviews of your every single commit, so I can't see how we should know what you've copied except in a few cases where it was noticed (by chance I'd wager).

Anway, section 2a is quite interesting, and we at aMule should probably do our best to insure compliance with the GPL as well. 2a states: "You must cause the modified files to carry prominent notices stating that you changed the files and the date of any change.", however, it is not clear to if they want us to add a notice for each and every change (I bloody well hope not, that would be insane), or a notice for any one change.
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Concerning aMule Derivations
« Reply #2 on: July 22, 2004, 05:38:11 PM »

you guys propably know even better what code from aMule got into xMule. and as you did yourself the work to copy it, you can do yourself the work to look at it too.
i don't think we have the time for it.

greets

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Concerning aMule Derivations
« Reply #3 on: July 22, 2004, 07:25:04 PM »

Delta and Xaignar said it all. Of course, if you donate a fair amount to aMule project we can take a look and review your code for gpl breakages, but only as a paid service, sorry. We're busy coding our client :)
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Concerning aMule Derivations
« Reply #4 on: July 22, 2004, 11:20:11 PM »

I mean, it's kinnda insane
if xMule copies from aMule (and we all know except when ted tells everyone we didn't), just search your commits
is not like we're gonna request copyright headers everywhere
as long as we're on authors and major changes are there
(like the MuleNotebook.*, which is (c) Kry and should be also (c) aMule Team, as is on the original)
i.e. Run copied all opur packet handling code for endianess
and gave no (c) to aMule neither to the coder
that's bad too. it was a LONG diff :)
as for aMule - everything is cool. We have the same (c) headers as the forking time (Merkur) and we have xMule and lmule authors on AUTHORS file
we also state everywhere we're a xMule fork
and the changelog include's xMule changelogs
so everyone's changes prior to aMule are noted


We're GPL compliant, as 0 code has been imported by aMule after the fork.

Search you code for aMule code and add it if you want to be GPL compliant :)

[EDIT]
Version 1.2.0
-------------
2003-11-26

   Kry:
      * Some memleaks fixed (Thanks to xMule team)
[/EDIT]

That's on changelog but was removed later because it was wrong :) So no xMule code after the  fork (and it's even still there the notice)
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Concerning aMule Derivations
« Reply #5 on: July 23, 2004, 05:14:31 PM »

to avoid things like 'those stupid amule ppl doesn't know what code i copied so i can tell i never did it' a good point for the xmule team to start searching:

Quote
* Implemented nearly 100% of aMule-1,1,2's network modifications that worked.
* Added ZLIB support to xMule, based on aMule 1.1.1, which is based on eMule 0.30c