Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Fukinagashi]

Cheerio,

ok I am colorblind and regarding the statistics I am not alone  ;(

I am a bit annoyed with the actual display of the (low|high) ID. A colorcoding for such an important warning is not sufficient. I suggest the follwoing banal code-change:

diff -ru aMule-2.0.0rc5/src/ServerSocket.cpp aMule-2.0.0rc5-Fukinagashi/src/ServerSocket.cpp
--- aMule-2.0.0rc5/src/ServerSocket.cpp   2004-07-10 08:28:10.000000000 +0200
+++ aMule-2.0.0rc5-Fukinagashi/src/ServerSocket.cpp   2004-08-29 01:38:59.481638752 +0200
@@ -325,6 +325,9 @@
             }
             serverconnect->SetClientID(la->clientid);
             AddLogLineF(false,_("New clientid is %u"),la->clientid);
+            if (theApp.serverconnect->IsLowID()) {         // Oliver colorblind
+               AddLogLineF(false,_("WARNING: LowID"));
+            }

Any variant of this (with more sophisticated texts) is just fine, but it is important that we "blinden hühner" can see that we have a LowID

[Xaignar]

That's a very good point. I'll look into it ASAP ... except that it'll have to wait till I've gotten some sleep.

The warning should probably be something along the lines of:

WARNING: You have recieved LowID while connecting to a server.
 That means that you are unable to accept incomming connections, something that will cause slower downloads. For more information on how to fix this, please refer to .

[Xaignar]

One last thing. It could also be possible to change the default icons for connection type to instead use the smilies also used for client connections. You can see them here (the first 5):  http://emule-project.net/home/perl/help.cgi?l=1&rm=show_topic&topic_id=100

They would in turn be: High ID, , Low ID, Disconnected, Connecting

How does that sound?

[Fukinagashi]

... nice. If you have symbols (smilies) which are are recognized not only (majorly) recognized by their color, it helps. As well Tooltips over these icons would help. But for these changes I would apply only a low priority.

I though think the error message in the aMule Log, right after "New ClientID is ...", should be still granted. I even the an additional value for all users, in the possible history, when you loose connection to one server and than jump on other servers. And as mentioned the change is quite simple and has IMHO no side-effects.

But thank you very much for picking this up so quick!

[Xaignar]

Right, the first half has been added and looks like this:

Code: [Select]

08/30/04 18:41:08: Connecting to 211.214.161.107 (211.214.161.107 - 211.214.161.107:4661)
08/30/04 18:41:09: Connected to 211.214.161.107 (211.214.161.107:4661)
08/30/04 18:41:10: Connection established on: 211.214.161.107
08/30/04 18:41:10: WARNING: You have recieved Low-ID!
08/30/04 18:41:10:  Most likely this is because you're behind a firewall or router.
08/30/04 18:41:10:  For more information, please refer to http://wiki.amule.org
08/30/04 18:41:10: New clientid is 740878
How's that?