Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Seagull]

Files in categories with blue and grey tones are almost unreadable when selected (rc5 and cvs-20040930).

I then request that category colors dont be applied to selected files (foreground) or that the color be shifted.

The first option is easier and makes more sense in my opinion, since the defined color wont appear anyway.

The change in this case is trivial.

In DownloadListCtrl.cpp, CDownloadListCtrl::OnDrawItem:

Code: [Select]

Change:

if ( content->type == FILE_TYPE) {
// If we have category, override textforeground with what category tells us.

To:

if ( content->type == FILE_TYPE && !highlighted) {
// If we have category, override textforeground with what category tells us.

A little change to the above can be made by substituting "!highlighted" with "!GetFocus()", in which case, only when focus is on the item will the color not be applied.

Hope it makes it to rc6  :P

[Xaignar]

I've committed the !GetFocus() variant, since that is the best compromise between displaying the category information and being readable IMHO.