Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[nachbarnebenan]

ok, i dunno if this will work at all and how much it will affect performance, but i thought about implementing a file lock mechanism to reduce incompleteable files. it could work like this:
1. file is added to download list (either via search or uri) and first gets "locked" status.
2. while locked, sources are searched with low priority, but no upload queue place is taken until all parts of the file have been seen (not neccessarily at the same time).
3. when all parts are there, the lock is opened and everything from this point on works like it does now, except the already found sources are kept of course.
the lock can be opened manually and the file could be shown white in the dl list while locked.

i guess, this could decrease dead files be at least one third or more. and it will prevent wasting credits for incompleteable files

[GonoszTopi]

Maybe. After 2.0.0 final.

[lfroen]

nachbarnebenan: what exactly is the problem you trying to solve ? Amount of disk space  taken by uncompleted files ? You have "delete file" command on your operating system for this.

i dunno if this will work at all and how much it will affect performance

It will not. And will not affect performance, whatever you mean by this.

while locked, sources are searched with low priority

It doesn't work this way. Sources are not searched according to some priority. File priority means priority while downloading/uploading

but no upload queue place is taken

What direction are we talking about ?

the lock is opened and everything from this point on works like it does now

You mean that downloading doesn't start untill ALL parts are available ? Does it also mean, that if some of parts are no longer available (source is dropped for whatever reason), you will abort this download ? If your answer is "no" - your internal logic is broken, 'cause this file is going to become "incompleteable" by your definition.

i guess, this could decrease dead files be at least one third or more

How did you come out with number "1/3" ? Guess is not acceptable, sorry.
Detailed analysis of "how ed2k network works" shows that it will have no effect.

[skolnick]

I think the problem he is trying to solve is downloading files with no complete sources, or at least files where all the incomplete sources joint, give the complete file. This has already been implemented in some emule MODs, I think MorphXT already has it.

Regards.

[nachbarnebenan]

Yes, exactly. No file should start downloading until it's sure all parts are available (or the user overrides it). Of course, a file still can get lost if the only available source goes offline but this could give some improvement at least.

[lfroen]

WHY do you want to do it ?

No file should start downloading until it's sure all parts are available

Why it's a problem if it DOES start downloading ?

[GonoszTopi]

Why it's a problem if it DOES start downloading ?

Because there are people around the world (although in minority) who don't have unlimited disk space.

[djtm]

Yeah, it is a great Idea.

It would also help in the search section:
The servers would only display many sources (which actually have hardly anything of the file) if the file is actually available...

but mostly no space would be waisted for incomplete files.
And it should be very easy to implement.

The status should be saved: If it was completely found/started once it should keep going...

while ( available_percent != 100 ){pause_download(this);}
or better
if ( available_percent == 100 ){start_download(this);}
or similar

[nachbarnebenan]

> And it should be very easy to implement.

yep, i guess it will take one of the core devs less than a minute to hack it. Nevertheless it should not be added before 2.0 to not further delay the final.

[lionel77]

Originally posted by GonoszTopi

Why it's a problem if it DOES start downloading ?

Because there are people around the world (although in minority) who don't have unlimited disk space.

i think the even bigger issue here is to avoid wasting upload bandwidth of the clients we would be downloading from. since upload bandwidth is the most limited resource on the network, any attempt to reduce wasting it is very valuable...

[lfroen]

lionel77:

avoid wasting upload bandwidth

What does it have to do with upload ?! By pausing file in download queue how exactly you save upload bandwidth ?

GonoszTopi:

Because there are people around the world (although in minority) who don't have unlimited disk space.

When you put file in download queue, you obviously must have space for this file. The mere fact that this space is not allocated right away doesn't make it different. The space depends on size of whole file, not size of downloaded parts. Moreover, it's nice feature of ext2/3 that makes it possible to allocate only used parts, on vfat/ntfs it IS allocated right away.

djtm:
Search doesn't check parts availability. amule have to actually connect to each one of sources, and ask about parts available for each file. And there're limits about how fast it can be done, how many requests  amule can issue etc.

[phoenix]

Folks,

Dead files are a problem, but how do you know that a file is really dead? I think that the only ones capable of knowing it are the servers, that have a big up time and could do statistics about the last time a file part has been seen on the net.

If the file is not really dead, there is no bandwidth waste, because everybody is getting the existing parts. When the missing parts come up again, download continues.

Not starting a download because there are some parts missing at the moment goes against the nework philosophy in my opinion. If you really want that file, you will leave your client there asking for it a few days before dropping it from your queue. What harm does this file causes beeing on the download queue?

1) Disk space allocation
2) Source exchange bandwidth

Number 2 should be *very* small, number 1 depends upon your file system and hard disk free space.

Cheers!

[lfroen]

Not starting a download because there are some parts missing at the moment goes against the nework philosophy in my opinion. If you really want that file, you will leave your client there asking for it a few days before dropping it from your queue. What harm does this file causes beeing on the download queue?

That is exactly what I was talking about.

And there's another way: write perl script that will operate amulecmd and see available sources for each file, and call "pause" for those who have incomplete source set. And resume they later in same way.

[GonoszTopi]

And there's another way: write perl script that will operate amulecmd and see available sources for each file, and call "pause" for those who have incomplete source set. And resume they later in same way.

Not exactly. amulecmd doesn't show part info, only available sources - so you cannot determine whether the full file is available or not.

[lfroen]

So may be we should add it