aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Other people's credits not counting  (Read 5174 times)

gjn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Other people's credits not counting
« on: January 13, 2004, 09:20:27 PM »
HI,

I have a user in my Q from which I downloaded several 100's of megs. Yet, he does not advance faster in my Q than other people from which i didn't downloaded anything. I watched the Q for hours now. The details dialog shows the megs, I saw them coming, yet the rating in the Q for this user is still 100...

What did I miss? Does amule not work with credits?

I certainly would like to give this pal some megs back...

(Note: priority system works in the Q)
Logged

KingFish

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 52
RE: Other people's credits not counting
« Reply #1 on: January 13, 2004, 09:28:02 PM »
Hi, I'm not an aMule dev, but maybe I can help.. Have you checked your ~/.eMule file for the setting of "UseCreditSystem=1"? Is it 0? Well, that would be the only cause I know about.
Else, the credits might "outdate", like the transfer was to long ago or in another aMule session.. But as I said, I'm no dev and I don't know about the exact implementation. But aMule fully supports credits system!
Logged

gjn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
RE: Other people's credits not counting
« Reply #2 on: January 13, 2004, 09:46:21 PM »
UseCreditSystem is set to 1.

The upload is quite recent. In fact, I'm downloading from this user right now.

Anything else?
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Other people's credits not counting
« Reply #3 on: January 14, 2004, 12:29:58 AM »
shared files priority maybe ?
Logged

gjn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: Other people's credits not counting
« Reply #4 on: January 14, 2004, 10:53:37 AM »
don't think so. the observation i made was on the same file in the Q. In fact, shared files prority works as expected in the Q.

All users just have a rating of 100 in the Q, no matter how much I downloaded from them
Logged

gjn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: Other people's credits not counting
« Reply #5 on: January 14, 2004, 03:26:55 PM »
finally, went through the source code a bit. I think it's a bug.

Look up CUpDownClient::GetScore , the credits don't get into account at all.

On a side note: this GetScore function is not used properly throughout the programm. for example in ClientDetailDialog.cpp  in the OnInitDialog function, the first parameter of the functions is 'isdownloading' but the function assumes this as second parameter....

I could patch this up if you care, but not until next week....and I should know how the credits are calculated against the other options (file prio, time in queue). Maybe I'll look up in xmule and/or emule.

In any case, the GetScore function should be changed in order for the credits system to work. Right now it doesn't, and this goes against file-sharing philosophy, ain't it? How are credits calculated for the QR in xmule or emule?
Logged

gjn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 5
Re: Other people's credits not counting
« Reply #6 on: January 14, 2004, 03:38:10 PM »
i looked it up in emule. basically, the return value is just multiplicated with the GetScoreRatio of the credits...but only if the credits system is activated in the settings.

i'll change that for me and recompile. if you guys want a patch, just say how i could submit it.
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Other people's credits not counting
« Reply #7 on: January 14, 2004, 05:13:33 PM »
if it work for u, why not.. we r open for patches ;)
thx for tracking!
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Other people's credits not counting
« Reply #8 on: January 16, 2004, 05:16:18 PM »
fixed in cvs :)
thx gjn
Logged