Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Vollstrecker]

Hi,
while playing around with amule and the posibillity to startup amuleweb automatically I saw, that amuleweb isn't shutdown when I close amule. Maybe it's because I had to kill amule, but after 5 tries I have 5 amuleweb processes. One for each try.
I would suggest, that either amule kills amuleweb at shutdown (or kill) or that amule checks if amuleweb is already running, and then don't start another instance.

[lfroen]

That was an original idea, but implementation seems buggy ...

[Kry]

Code: [Select]

// Kill amuleweb if running
if (webserver_pid) {
printf("Killing amuleweb instance...\n");
wxKillError rc;
wxKill(webserver_pid,wxSIGKILL, &rc);
printf("Killed!\n");
}
Maybe if you don't kill it...

[Vollstrecker]

I don't want to, but sometimes it is needed. I wanted to test how many downloads it can handle, and with atm 649 on an remote fs appear some errors. Sometimes I just have to, so it would be nice, if amule would check if amuleweb is already running.

[Kry]

And do what if it's running?

[GonoszTopi]

Code: [Select]

wxKill(webserver_pid,wxSIGKILL, &rc);

Why killing? Why not just terminating it? Doesn't wx have a wxSIGTERM?

[Vollstrecker]

Originally posted by Kry
And do what if it's running?

Nothing. When I killed the new ones, I can use the old one.

[Kry]

Nonsense. amuleweb connects to a running aMule, and DOESN'T reconnect to it if it's lost. So you can't use the old one with a newly running aMule.

[Vollstrecker]

Maybe I killed the false one, but it should be no problem to reconnect. Or at the other side, you could let amuleweb die when it loses connection.

[ken]

Well, certainly, it should quit if it loses the connection and it has no stdin.

[Vollstrecker]

werner@Werner1:~$ ps -A | grep amule
12480 ?        00:00:00 amuleweb
werner@Werner1:~$

[Kry]

Yeah, that did make a lot of sense.

Now, if you could explain what you pretend to achieve by that lines...

[Vollstrecker]

Originally posted by ken
Well, certainly, it should quit if it loses the connection and it has no stdin.

Originally posted by Vollstrecker
werner@Werner1:~$ ps -A | grep amule
12480 ? 00:00:00 amuleweb
werner@Werner1:~$

Originally posted by kry
Now, if you could explain what you pretend to achieve by that lines...

Got it now?
There is no amule or amuled process running, so it has lost connection. I closed the console where I started amule, so it has no stdin, stdout or stderr. But it does run.
Or was that wath ken posted not the behaviour? If that was a suggestion, I would be glad to see that implemented.

[Kry]

It was a sugestion.

[lfroen]

Exit when connection is failed is wrong.
Instead, on every request from browser amuleweb must perform one more connection attempt. If succeded, return to normal operation; if not - display error page telling the nature of the problem, like "connection failed/timeout/no route to host/ etc".