aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: color of selected files in downloads  (Read 2233 times)

dnk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
  • Conection is the issue
color of selected files in downloads
« on: March 13, 2006, 04:32:06 PM »
The problem I have is that selected files in the downloads screen are highlighted with white text color in light pink background, and thus they cannot be correctly read.  :(
I have been searching whether anyone has reported that problem and found nothing.
I have downloaded the CVS version to see the code (I use a precompiled package) and it seems that aMule is using wxWidgets' wxSYS_COLOUR_HIGHLIGHT to set it, but I don know how to change that color (without changing the code, that is).  Any clue?  ?(
« Last Edit: March 13, 2006, 04:35:29 PM by dnk »
Logged

stefanero

  • Some Support
  • Developer
  • Hero Member
  • *****
  • Karma: 8
  • Offline Offline
  • Posts: 4235
Re: color of selected files in downloads
« Reply #1 on: March 13, 2006, 04:51:42 PM »
change your gtk theme...
Logged
In its default setup, Windows XP on the Internet amounts to a car
parked in a bad part of town, with the doors unlocked, the key in
the ignition and a Post-It note on the dashboard saying, "Please
don't steal this."

dnk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
  • Conection is the issue
RE: color of selected files in downloads
« Reply #2 on: March 13, 2006, 05:01:26 PM »
Hum, I have found a related message in the forum, entitled "debian sid - yellow selection, not saved priority" (for the title I could not imagine).  The proposed solution there is:
Quote
But I have changed "Color scheme" in Control Center -> Appearance & Themes -> Colors -> Color Scheme and everything is ok now.
The problem is that in my Ubuntu you have not the posibility of changing colors (they think you better do not change anything because you can make it bad  :().
Anyway, I think that this is an amule bug, because the program should ensure that the text color is readable within the background color, isn't it?
Any hint for ubuntu users? ?(
Logged

thedude0001

  • evil bugfinder ;)
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 827
RE: color of selected files in downloads
« Reply #3 on: March 13, 2006, 05:08:58 PM »
Quote
Originally posted by dnk
Anyway, I think that this is an amule bug, because the program should ensure that the text color is readable within the background color, isn't it?

No, it still is a "bug" in your GTK theme. Amule simply uses that theme. I have no idea about ubuntu, but searching for keywords like "gtk theme switcher" might help you.
Logged
Das Schlimme auf dieser Welt ist
daß die Dummen so selbstsicher sind
und die Gescheiten so voller Zweifel.

stefanero

  • Some Support
  • Developer
  • Hero Member
  • *****
  • Karma: 8
  • Offline Offline
  • Posts: 4235
Re: color of selected files in downloads
« Reply #4 on: March 13, 2006, 05:22:39 PM »
btw with normal gtk-apps you need to restart the x-server for changed to take effect

and amule does not really care what colours you use, its basically your decicion...so amule cannot figure out whats redeable for you and what not
Logged
In its default setup, Windows XP on the Internet amounts to a car
parked in a bad part of town, with the doors unlocked, the key in
the ignition and a Post-It note on the dashboard saying, "Please
don't steal this."

dnk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
  • Conection is the issue
RE: color of selected files in downloads
« Reply #5 on: March 13, 2006, 05:24:23 PM »
OK, I have changed the overall theme, but I don't think this should be that way.  Thankyou in any case.
Logged

dnk

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
  • Conection is the issue
Re: color of selected files in downloads
« Reply #6 on: March 13, 2006, 05:49:31 PM »
In my case I just have ro restart amule to see the changes.
Just to justify my point look at the source code which handles the selected file colors:
Code: [Select]
wxColour colour = BLEND( SYSCOLOR( wxSYS_COLOUR_HIGHLIGHT ), 125 );
m_hilightBrush  = new wxBrush( colour, wxSOLID );It is changing the selected background color, and thus when later sets the background and text color:
Code: [Select]
dc->SetBackground(*m_hilightBrush);
dc->SetTextForeground(wxSystemSettings::GetColour(wxSYS_COLOUR_HIGHLIGHTTEXT));the contrast of the colors may be changed.
Logged