aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: try to download first and last chunks first  (Read 3407 times)

fakeroot

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 1
try to download first and last chunks first
« on: February 26, 2004, 12:36:16 AM »

I think the option "try to download first and last chunks first" is broken. Especially the last chunk doesn't seem to have a higher priority at all.

I also notice a lot of files where the first 50 percent are already completed whereas the second half has many gaps. Chunks with lower numbers clearly seem to have a higher download priority. A look at the source code comments of CPartFile::GetNextRequestedBlock() shows that this is not what was intended originally.

I try to attach a small screenshot to clarify what I mean, hope it works.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: try to download first and last chunks first
« Reply #1 on: February 26, 2004, 01:51:46 AM »

Yes. True. We'll fix.
Logged

xenon

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
Re: try to download first and last chunks first
« Reply #2 on: May 07, 2004, 10:10:11 PM »

Same thing here: last chunk is not prioritized and - until RC2, the other chunks were downloaded in a "left to right" fashion. With RC3 things have changed, and chunks come randomly, it seems. I took a look at the .emule configuration file, and found no trace of the "First and last chunks first" option. Is this the problem? If so, could one manually add the entry and how should it look like? If not so, I hope to see it fixed in next versions.

And by the way, thanks to all devs for their work!  :)
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: try to download first and last chunks first
« Reply #3 on: May 07, 2004, 11:00:54 PM »

listRse.Append(new RseBool(IDC_PREVIEWPRIO, prefs->m_bpreviewprio, "PreviewPrio", false));

From PrefsUnifiedDlg :)
Logged

xenon

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
Re: try to download first and last chunks first
« Reply #4 on: May 08, 2004, 03:27:35 PM »

Thanks for your reply, but... what do you mean? Obviously what you posted doesn't look like a config entry, more like a code line. Do you mean the function is already there and it should work? I'm not familiar with the aMule codebase.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: try to download first and last chunks first
« Reply #5 on: May 08, 2004, 10:00:03 PM »

Sorry, too used to fast replies.

That was supposed to mean that the option exists, is called PreviewPrio and is used and works afaik.

I mixed your reply with fakeroot's one (who has obviously seen the code)
Logged

xenon

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 15
Re: try to download first and last chunks first
« Reply #6 on: May 09, 2004, 04:16:16 PM »

Well, I checked again and the PreviewPrio entry is indeed in my config file. But still, I must say it doesn't work for the last chunk, at least here.
Logged