aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Some menu options missing ? CVS - 13 oct 2007  (Read 5009 times)

ecforum

  • Full Member
  • ***
  • Karma: 1
  • Offline Offline
  • Posts: 105
Some menu options missing ? CVS - 13 oct 2007
« on: October 13, 2007, 05:21:07 PM »

Hello,

I had more options in previous amule versions in the contextual popup "Extented options". See the joined image.
I don't know if it is a bug on the cvs version or a problem on my version...
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #1 on: October 13, 2007, 05:21:47 PM »

what more options?
Logged

ecforum

  • Full Member
  • ***
  • Karma: 1
  • Offline Offline
  • Posts: 105
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #2 on: October 13, 2007, 05:50:52 PM »

Something like :
"drop no needed sources"
"drop queue full sources"

4 (?) options like that.
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #3 on: October 13, 2007, 05:51:59 PM »

Yes, the options regarding source dropping are missing. Due to having a pure 64bit system and wxDesigner being proprietary (and not available for x86_64) I haven't had the time to remove the rest yet.
Logged

smackers

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #4 on: November 03, 2007, 02:28:05 AM »

Yes, the options regarding source dropping are missing. Due to having a pure 64bit system and wxDesigner being proprietary (and not available for x86_64) I haven't had the time to remove the rest yet.
Hello.
This menu options and configuration tab "Source Dropping" will be completly removed and never back in the future?
This is important amule feature for me.
Sorry for my bad english  >:(
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #5 on: November 03, 2007, 08:00:33 AM »

Yes, it is completely removed as of 20 October.

Please explain why this feature is important to you and why it should have any advantages for you and I'll explain you my position in this regard.
Logged

smackers

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #6 on: November 03, 2007, 09:34:47 PM »

Hi.
Problem with these removed options is solved (for me) by patching and modify current cvs version code by code from cvs-20071020 and work fine.
Important because some clients (i'em firewalled) give to me very hqr's all time and my download/upload queues has many unimportant clients that never uploads data to me but only downloads hundred megs of data.

PS. Is any solution for fake data senders?
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #7 on: November 03, 2007, 10:12:47 PM »

Um...you drop these people from your download queue, not your upload queue. What is actually happening is, you drop a client from your download queue, it will be found some minutes later again only to be dropped again - causing unnecessary overhead without affecting your upload behaviour towards these clients at all.

Quote
PS. Is any solution for fake data senders?
Try an ipfilter file.
Logged

smackers

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #8 on: November 04, 2007, 02:33:05 AM »

Yes, these clients are already dropped from download and upload queues.
No, i'em always firewalled  >:( and overhead is smaller than you explain.
My upload is always set to 60kB/s and without this modification average download is about 5-10kB/s. With modification see screenshot for 5 hours of tonight run:

Is about 2x better than without, why - i dont known.

IPFilter (ipfilter_static.dat) is known for me, but my question is what detects these clients when its sends fake data? This is seriously problem on some popular files and i have already 42 ip's of these fake senders, but some are on dynamic ip's.
Again sorry for my horrible english.
Logged

ecforum

  • Full Member
  • ***
  • Karma: 1
  • Offline Offline
  • Posts: 105
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #9 on: November 04, 2007, 11:40:29 AM »

I haven't had the time to remove the rest yet.

"remove the rest" : does that mean that you will remove the A4AF options too ? I use these options to set the sources on a file that  want to download as quick as possible (it's what I understood reading the wiki...).
I also used the drop of sources but I was not sure that it was improving anything...
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #10 on: November 04, 2007, 11:58:16 AM »

No, I meant removing the options in the preferences. I have no intention to remove manual A4AF.

smackers: Source dropping will NOT remove these clients from your upload list. They will remain in your upload list, but you will not ask to download from them for a while.
I fail to see the relation between lowid and a smaller overhead as well, the overhead is in general higher with lowid. If it is possible you should try to get rid of your lowid.

There is no mechanism to detect fake data senders, you can only block clients and ip-ranges with ipfilter.
Logged

smackers

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #11 on: November 04, 2007, 07:53:01 PM »

smackers: Source dropping will NOT remove these clients from your upload list. They will remain in your upload list, but you will not ask to download from them for a while.
Yes i understand this, but my changes is not only copying old cvs code to current cvs   :)
Quote from: wuischke
I fail to see the relation between lowid and a smaller overhead as well, the overhead is in general higher with lowid.
With my modifications (including source dropping) total clients that utilise my connection are smaller (see screenshot about 6 files, ~200 clients) and data is send only to clients that gives me chance to download from - QR lower than 2000 at start for example. I run amule typically only for 8-10 hours and QR bigger than 2000 on start never gets me data.
Quote from: wuischke
If it is possible you should try to get rid of your lowid.
No is impossible  >:(
Quote from: wuischke
There is no mechanism to detect fake data senders, you can only block clients and ip-ranges with ipfilter.
I write some code that detects sending data contain only zeros (0x00) for example but this not always work  >:(

Thanks wuischke. My problem with source dropping is solved and amule works perfectly  :)
Logged

wuischke

  • Developer
  • Hero Member
  • *****
  • Karma: 183
  • Offline Offline
  • Posts: 4292
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #12 on: November 05, 2007, 12:07:04 AM »

Ah, OK. I understand now.

Quote
I write some code that detects sending data contain only zeros (0x00) for example but this not always work
Would you mind sharing this code? This seems like a good thing to have and we could start to improve upon this.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #13 on: November 06, 2007, 07:43:48 PM »

With my modifications (including source dropping) total clients that utilise my connection are smaller (see screenshot about 6 files, ~200 clients) and data is send only to clients that gives me chance to download from - QR lower than 2000 at start for example.

The ED2K network is a file sharing, not trading network. You're blocking from downloading from you, for no reason, people that are uploading to a lot of other people. It's completely against the goals and philosophy of the network, and harms it as a whole.
Logged

darkbasic

  • Approved Newbie
  • *
  • Karma: 1
  • Offline Offline
  • Posts: 47
Re: Some menu options missing ? CVS - 13 oct 2007
« Reply #14 on: November 06, 2007, 09:43:41 PM »

It's completely against the goals and philosophy of the network, and harms it as a whole.
*
Logged
Sorry for my bad English...
Debian Sid amd64 | Fedora 8
AMD Athlon64 3800+ X2@2600Mhz vcore 1.392| My PC