aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: "HAVE_STRFTIME" redefined  (Read 3827 times)

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
"HAVE_STRFTIME" redefined
« on: May 31, 2009, 12:56:23 AM »

This is another wx 2.9 problem. wx 2.9 defines HAVE_STRFTIME in wx/datetime.h , and aMule again in config.h.
Is there a way to exclude it from config.h, or #undef it at the beginning of config.h?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: "HAVE_STRFTIME" redefined
« Reply #1 on: May 31, 2009, 05:30:27 PM »

Although it is possible to undefine HAVE_STRFTIME in config.h, I'd better file a bug report for wx (I'm pretty sure aMule is not the only application having this problem).

It is never a good idea to define macros in a public header with the name of a well-known and widely used autoconf define.
Logged
concordia cum veritate

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: "HAVE_STRFTIME" redefined
« Reply #2 on: May 31, 2009, 08:32:56 PM »

Ok, done.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: "HAVE_STRFTIME" redefined
« Reply #3 on: May 31, 2009, 09:18:11 PM »

It took 25min to get fixed. Vadim rocks.  :D
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: "HAVE_STRFTIME" redefined
« Reply #4 on: June 01, 2009, 11:41:45 AM »

True.
Logged
concordia cum veritate