aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: amule is not using zlib properly  (Read 7807 times)

lugdunummaster

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
    • http://lugdunum2k.free.fr/kiten.html
amule is not using zlib properly
« on: July 13, 2004, 02:52:46 PM »
Hello

It seems edonkey and amule dont use zlib properly.

zlib was added to eserver mainly to decrease bandwidth requirements.

A client that announce zlib capability MUST use zlib when file publication takes place, since this is the most consuming part between a client and its server.

Starting of eserver-16.47, client that falsely announce zlib capability but continue to use uncompressed big packets are disconnected.

Please add the few lines in amule to correct this as soon as possible.

Thank you
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: amule is not using zlib properly
« Reply #1 on: July 13, 2004, 03:16:40 PM »
Hi lug and welcome. Can you confirm which aMule is causing that? 1.2.7 or the rc series?

I think it might bejust from 1.2.7 I'll review tonight.


Sorry for the problems :)
Logged

lugdunummaster

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
    • http://lugdunum2k.free.fr/kiten.html
Re: amule is not using zlib properly
« Reply #2 on: July 13, 2004, 03:29:30 PM »
Well... I just checked 2.0.0rc4 and I confirm the problem is there. For sure all versions have this problem.

check file SharedFileList.cpp

function :

void CSharedFileList::SendListToServer()
« Last Edit: July 13, 2004, 03:30:17 PM by lugdunummaster »
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: amule is not using zlib properly
« Reply #3 on: July 13, 2004, 04:52:01 PM »
hiya lug,

i've noticed using zlib 1.2.1 there's no problem connecting to 16.47 servers and staying connected.
seems ppl with zlib < 1.2.1 have such problems.. i'll test more

greets
Logged

galiza_ceive

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 3
Re: amule is not using zlib properly
« Reply #4 on: July 13, 2004, 05:36:49 PM »
Same trouble here with zlib 1.2.1(MUST BE USED NOT ONLY ADVERTIZED, server error), amule-cvs (today's snapshot --and yesterday's--)... but yesterday things worked

Edit 1 # i gets connected with servers with 16.46 lugdunum version...
« Last Edit: July 13, 2004, 06:01:04 PM by galiza_ceive »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: amule is not using zlib properly
« Reply #5 on: July 13, 2004, 08:05:30 PM »
Ok lug, sorry for the bug. Will fix it ASAP. Amazing it didn't get noticed since then....


/me hides
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: amule is not using zlib properly
« Reply #6 on: July 15, 2004, 02:48:59 AM »
Logged

bridge

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 4
Re: amule is not using zlib properly
« Reply #7 on: July 15, 2004, 09:58:32 AM »
Thanks for fixing that so quickly!

Also thanks to thermoman for updating his Debian packages  contemporary.

-bridge
Logged

fuzzix

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 8
    • http://fuzzbucket.tk/
Re: amule is not using zlib properly
« Reply #8 on: July 16, 2004, 01:36:35 AM »
Sorry to jump in on the thread, but does this issue affect any parts downloaded with 1.2.7?
I managed to connect to a few smaller servers and got some parts down.

Thanks.
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: amule is not using zlib properly
« Reply #9 on: July 16, 2004, 01:38:22 AM »
nope.. u have only to backup your client.met if u switch from/to 1.2x / 2.0.0rcx ..
and 1.2.8 is out too btw ;)
Logged

fuzzix

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 8
    • http://fuzzbucket.tk/
Re: amule is not using zlib properly
« Reply #10 on: July 16, 2004, 09:26:05 AM »
Grabbed it last night - good work guys!
Logged