aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Incorrect source exchange packet  (Read 1971 times)

eMulePlus

  • Newbie
  • Karma: 0
  • Offline Offline
  • Posts: 2
Incorrect source exchange packet
« on: July 23, 2004, 09:48:24 PM »

aMule 1.2.6 reported incorrect source exchange version and there was a hope that 2 bug-fix versions 1.2.7/1.2.8 would fix it, but the problem is still there.
Reported source exchange version doesn't fit format of your source exchange packets.
CUpDownClient::SendMuleInfoPacket contains:
Code: [Select]
CTag tag4(ET_SOURCEEXCHANGE,2);
But the sending packet format is NOT version 2:
Code: [Select]
void CUpDownClient::UDPReaskForDownload()
{
if(!reqfile || m_bUDPPending) {
return;
}

   if(m_nUDPPort != 0 && theApp.glob_prefs->GetUDPPort() != 0 &&
        !theApp.serverconnect->IsLowID() && !HasLowID() && !(socket && socket->IsConnected())) {
   
if(IsSourceRequestAllowed()) {
return;
}
m_bUDPPending = true;
Packet* response = new Packet(OP_REASKFILEPING,16,OP_EMULEPROT);
        memcpy(response->pBuffer,reqfile->GetFileHash(),16);
theApp.uploadqueue->AddUpDataOverheadFileRequest(response->size);
theApp.clientudp->SendPacket(response,GetIP(),GetUDPPort());
}

}
I think you know that the official eMule just discards such packets.

--
eMule Plus Team
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Incorrect source exchange packet
« Reply #1 on: July 23, 2004, 09:59:31 PM »

has been forgotten, thx

well, then let us fix it and release at weekend 1.2.9 as the last 1.2.x release

greets

Xaignar

  • Admin and Code Junky
  • Hero Member
  • *****
  • Karma: 19
  • Offline Offline
  • Posts: 1103
Re: Incorrect source exchange packet
« Reply #2 on: July 23, 2004, 10:01:14 PM »

[Nevermind]
Logged