aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Wrong opcode for ET_COMPATIBLECLIENT  (Read 8204 times)

spiralvoice

  • Guest
Wrong opcode for ET_COMPATIBLECLIENT
« on: December 05, 2003, 08:32:16 PM »

Hi,

@pure_ascii: You wrote today on the MLDonkey world forum about
the recognition of aMule as eMule compatible client in MLDonkey.

Please read my postings there because maybe I found a bug in aMule
regarding the opcode it sends for ET_COMPATIBLECLIENT.

In eMule 0.30d there is in opcodes.h
[code:1]#define ET_COMPATIBLECLIENT      0x26[/code:1]
In aMule (and xMule) is opcodes.h
[code:1]#define ET_COMPATABLECLIENT         0x30[/code:1]
Because of this a patched MLDonkey canŽt recognize aMule because
it looks for 0x26, this works for example with Shareaza.

Greetings, spiralvoice
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #1 on: December 05, 2003, 08:54:30 PM »

hey spiralvoice,

thx, w'll change it

greets
delta

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #2 on: December 05, 2003, 08:55:01 PM »

Thanks for your feedback spiralvoice. I'm not pureascii obviously but I'm a dev too. I'll research on that and fix it, then pure will notify you on MLDonkey forums.


*LATER*

Already changed and posted on MLDonkey forum. Thanks again.
Logged

spiralvoice

  • Guest
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #3 on: December 05, 2003, 10:09:11 PM »

Hi,

thanks for your quick reaction :D

I would like to propose something regarding ET_COMPATIBLECLIENT?

AFAIK

cDonkey uses 1
lMule uses 2 (opcode 0x26 - working)
xMule uses 2 (opcode 0x30 - not working)
aMule uses 3 (opcode 0x30, now 0x26 - working, but not yet seen here :wink:)
Shareaza uses 4 (Hint: missing in BaseClient.cpp :wink: )
MLDonkey uses 10 (new in CVS, donkeyMain.ml, line 144)

Every day clients with flag 2 and opcode 0x26 connect to my MLDonkey,
from what I have written above I suggest they are all lMules.

From what I have read the xMule dev takes some improvements from
aMule and imports them into his source code. I will post this also on the
xMule forum but maybe you have also contact to him.

To better distinguish between lMule and xMule - which was yet impossible
because of opcode 0x30 - xMule should use flag 5.

What do you think about that?

Greetings, spiralvoice
Logged

spiralvoice

  • Guest
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #4 on: December 05, 2003, 10:23:51 PM »

Quote
Original von spiralvoice

I will post this also on the
xMule forum but maybe you have also contact to him.

 :lol:  :lol:  :lol:
When I write "aMule" on their forum it gets "translated" in
Quote
\-- another program --/


Lets see what they do: http://xmule.org/forums/index.php?act=ST&f=3&t=1159#

Greetings, spiralvoice
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Logged

deltaHF

  • Evil Admin
  • Former Developer
  • Hero Member
  • *****
  • Karma: 6
  • Offline Offline
  • Posts: 3920
  • .. Legends may sleep, but they never die ..
    • http://www.amule.org
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #6 on: December 05, 2003, 11:17:25 PM »

well, even your link to our board doesn't work there spiralvoice .. ->

http://\-- another program --/.sourceforge.net/phpBB2/viewtopic.php?p=1512#1512

spiralvoice

  • Guest
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #7 on: December 06, 2003, 12:29:42 AM »

Hi,

I have this file:

ed2k://|file|aMule-1.2.0.tar.gz|1606153|AC83A90C460D06787B8BEE397ADE4B93|/

Test my donkey;-)

Greetings, spiralvoice
Logged

pure_ascii

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 16
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #8 on: December 06, 2003, 02:39:35 AM »

hi spialvoice,

thx for your fast reply. seems this opcode was changed by fault when trying to be recognised as emule 0.30 instead of 0.26 by servers.

We found the one to blame: Creteil aka Bigbob. ;)

@Creteil: Dont worry, shit happens ;)

bye, PA.
Logged

BigBob

  • aMule project creator.
  • Full Member
  • ***
  • Karma: 1
  • Offline Offline
  • Posts: 141
    • http://bigbob.fun.free.fr
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #9 on: December 06, 2003, 03:04:18 AM »

No one is perfect ...

A++
Logged
Creator of aMule & aStats projects

spiralvoice

  • Guest
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #10 on: December 06, 2003, 09:21:13 AM »

Hi,

just wanted to drop a note that aMule has been counted :D

Greetings, spiralvoice
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Wrong opcode for ET_COMPATIBLECLIENT
« Reply #11 on: December 06, 2003, 10:16:34 AM »

Great!
Logged