aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2

Author Topic: Category list in Settings dialog too small  (Read 7651 times)

KyroMaster

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 87
Category list in Settings dialog too small
« on: October 11, 2005, 07:03:13 PM »
The attached screenshot shows how the preferences dialog looks like on my system. The categories selectors height is way too small.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Category list in Settings dialog too small
« Reply #1 on: October 12, 2005, 05:31:06 AM »
That's why there is a scrollbar I guess
Logged

stefanero

  • Some Support
  • Developer
  • Hero Member
  • *****
  • Karma: 8
  • Offline Offline
  • Posts: 4235
Re: Category list in Settings dialog too small
« Reply #2 on: October 12, 2005, 09:44:03 AM »
KyroMaster it does not make sence to increase the size here, since you can change the font and the size

the size of hte prefs is fixed and not depended on the font, so some people have the scrollbar some not, depended on font/size
Logged
In its default setup, Windows XP on the Internet amounts to a car
parked in a bad part of town, with the doors unlocked, the key in
the ignition and a Post-It note on the dashboard saying, "Please
don't steal this."

KyroMaster

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 87
Re: Category list in Settings dialog too small
« Reply #3 on: October 12, 2005, 04:34:26 PM »
Sorry, I don´t quite understand your explanation :(
The box could be increased in height so there would be no scrollbar and the contents would fir in the window. IMHO this is better than using only half of the window height but showing a scrollbar.
Logged

stefanero

  • Some Support
  • Developer
  • Hero Member
  • *****
  • Karma: 8
  • Offline Offline
  • Posts: 4235
Re: Category list in Settings dialog too small
« Reply #4 on: October 13, 2005, 01:22:38 PM »
well but if you change your font size for example it would fit right away....
Logged
In its default setup, Windows XP on the Internet amounts to a car
parked in a bad part of town, with the doors unlocked, the key in
the ignition and a Post-It note on the dashboard saying, "Please
don't steal this."

lfroen

  • Guest
Re: Category list in Settings dialog too small
« Reply #5 on: October 14, 2005, 06:51:56 AM »
What stefanero mean, that your (KyroMaster) fonts are too big. It doesn't matter thou how big this list will be - you always can define even bigger font which will result in scrollbars.
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Category list in Settings dialog too small
« Reply #6 on: October 14, 2005, 07:11:06 AM »
Why not ignoring font settings for the ctegories, too?
Logged
Homefucking is killing prostitution

KyroMaster

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 87
Re: Category list in Settings dialog too small
« Reply #7 on: October 14, 2005, 11:34:24 AM »
Sorry for these dumb questions, but what has the font size to do with the size of the control? I program with wxWidgets myself, and AFAIK the font size is defined in my GTK2 environment. So when the control would be highter, the font size would be the same, so the scrollbars would disappear.
Logged

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Category list in Settings dialog too small
« Reply #8 on: October 14, 2005, 01:11:15 PM »
When you use a bigger fontsize than the one that coded the control, you get the scrollbars. If he uses a bigger one, you have many free space in there.
In short, if the font is bigger, it needs more space for the same text.
Logged
Homefucking is killing prostitution

lfroen

  • Guest
Re: Category list in Settings dialog too small
« Reply #9 on: October 14, 2005, 04:09:20 PM »
KyroMaster: sorry, but if you program with wxWidgets (or whatever gui toolkit) that your question is really dumb.
Yes, font is defined in your environment, but size of control is hardcoded. So, unless special measures taken in code to resize control according to your font size - bigger font will not fit and you will get scrollbars.
Logged

KyroMaster

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 87
Re: Category list in Settings dialog too small
« Reply #10 on: October 15, 2005, 12:18:44 AM »
Quote
Originally posted by lfroen
KyroMaster: sorry, but if you program with wxWidgets (or whatever gui toolkit) that your question is really dumb.
Yes, font is defined in your environment, but size of control is hardcoded. So, unless special measures taken in code to resize control according to your font size - bigger font will not fit and you will get scrollbars.

What I´d do in wxWidgets is to put the control into a sizer so that its height is always the height of the window minus the size of the buttons (I don´t know how the sizers are used actually in your preferences window). So if I have a too big font or a too little window I´ll get the scrollbars.
IMHO that´s not dumb  :P
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Category list in Settings dialog too small
« Reply #11 on: October 15, 2005, 08:40:27 AM »
But it looks awful with all that space wasted on the list ctrl.
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Category list in Settings dialog too small
« Reply #12 on: October 15, 2005, 05:45:08 PM »
Well, in fact I think KyroMaster does have a point. And so does Kry.

This is from the time before I entered aMule team, so Kry, why is this dialog coded with a list control? Couldn't we use a tabbed control there, like a notebook? There would be no wated space on the left and the interface would be cleaner, IMHO.

Cheers!
Logged

KyroMaster

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 87
Re: Category list in Settings dialog too small
« Reply #13 on: October 15, 2005, 05:52:57 PM »
Quote
Originally posted by Kry
But it looks awful with all that space wasted on the list ctrl.
What about making it as tall so that the contents fit in. And if the contents are too tall then just use the maximum size so the control will get scrollbars.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Category list in Settings dialog too small
« Reply #14 on: October 15, 2005, 06:33:53 PM »
Kyro has of course a point and a ptch will be wellcomed :P

phoenix: don't get me started on vertical tabs and wxMac.
Logged
Pages: [1] 2
« previous next »