aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: 'Max size ignored.'  (Read 4037 times)

Mig21

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 57
  • Just another guy.
'Max size ignored.'
« on: January 12, 2006, 04:31:09 AM »
hello

when entering a min size in the extended search options i get this popup:

Quote
Min size must be smaller than max size. Max size ignored.

this didn't happen before and i don't think it was put there intentionally

cheers
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: 'Max size ignored.'
« Reply #1 on: January 12, 2006, 04:44:53 AM »
Isn't it a too acurate message to be unintentional?
Logged

Mig21

  • Jr. Member
  • **
  • Karma: 0
  • Offline Offline
  • Posts: 57
  • Just another guy.
Re: 'Max size ignored.'
« Reply #2 on: January 12, 2006, 01:04:19 PM »
i don't think any user (certainly not me) wants that. wy not have a second popup because the availability was not specified? in fact, a popup with all the information in that form would be in order :)

i mean, if it goes in the log/status bar i don't really care but this popup is getting in my way for absolutely no good reason.
Logged

Xaignar

  • Admin and Code Junky
  • Hero Member
  • *****
  • Karma: 19
  • Offline Offline
  • Posts: 1103
Re: 'Max size ignored.'
« Reply #3 on: January 12, 2006, 01:07:37 PM »
This has been fixed on CVS. The problem is that it only compares min < max, which triggers if a max value hasn't been specified (max == 0). A workaround would be to set max to the highest posible value.
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: 'Max size ignored.'
« Reply #4 on: January 12, 2006, 07:02:26 PM »
Nah, not the highest value - would interfere with the search params. The workaround is of course ok.
Logged

lfroen

  • Guest
Re: 'Max size ignored.'
« Reply #5 on: January 13, 2006, 03:55:11 PM »
This is very confusing message. Xaignar: when max size == 0 this mean "any size" so error message is out of place.
Workaround is ok, but this is bug and should be fixed.
Logged

Xaignar

  • Admin and Code Junky
  • Hero Member
  • *****
  • Karma: 19
  • Offline Offline
  • Posts: 1103
Re: 'Max size ignored.'
« Reply #6 on: January 13, 2006, 04:51:34 PM »
This has been fixed in both the trunk and the 2.1.x branch.
See r6325:
Code: [Select]
- if ( max < min ) {
+ if ((max < min) and max) {
Logged