aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Universal Binary ed2kHelperScript  (Read 4223 times)

brainnolo

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 23
Universal Binary ed2kHelperScript
« on: November 18, 2007, 10:37:19 AM »
Hello, I made the ed2kHelperScript Universal binary, although is no big deal, I don't see the need to use Rosetta for that. You can commit this to CVS without problems ;)


Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Universal Binary ed2kHelperScript
« Reply #1 on: November 18, 2007, 01:08:34 PM »
Hi brainnolo,

Again, I am no Mac expert, remember that :)

We already have a directory called amule.app/Contents/MacOS/ed2kHelperScript.app. Do you want me to commit the files you posted over these files?

I am not very confortable with that, because I don't know the consequences of what I am doing, so could the Mac experts please step ahead and explain it to me? :)

I also have here the file aMule-20071112.zip that you posted in the other thread, are there any parts of it that should be committed?

These files look like binary stuff to me, and it is our policy not to distribute binaries. On the other hand, we have these directories in the tarball, so I am confused.

Cheers!
Logged

brainnolo

  • Approved Newbie
  • *
  • Karma: 5
  • Offline Offline
  • Posts: 23
Re: Universal Binary ed2kHelperScript
« Reply #2 on: November 18, 2007, 04:18:45 PM »
Yes you should replace the whole ed2kHelperScript.app. Although it looks like a regular application is just an AppleScript applet launcher generated by automatic means. What I did was to take the current version (which was generated with a PPC only version of Apple Script Editor), extract the script and have the "application" regenerated by Apple Script Editor. I'm using it regularly and it works fine.

From that zip file I posted you could commit content of the aMule.app/Contents/Frameworks directory, which contains UPnP binaries. I don't think redistributing those is a problem, although it would be against your policy. But then again, if you bundle them the UPnP option in the interface works, otherwise users have to figure out why it doesn't :D

EDIT: If you are unsure about which files to copy, just download the attachment from http://forum.amule.org/index.php?topic=13723.msg72810#msg72810 and put those files in the aMule.app/Contents/Frameworks directory


« Last Edit: November 18, 2007, 04:27:40 PM by brainnolo »
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Universal Binary ed2kHelperScript
« Reply #3 on: November 18, 2007, 05:15:16 PM »
Ok, the 3 library files have been committed to aMule.app/Contents/Frameworks.

Cheers!
Logged

phoenix

  • Evil respawning bird from aMule Dev Team
  • Developer
  • Hero Member
  • *****
  • Karma: 44
  • Offline Offline
  • Posts: 2503
  • The last shadow you'll ever see
Re: Universal Binary ed2kHelperScript
« Reply #4 on: November 18, 2007, 05:21:49 PM »
Also, the ed2kscript update has been committed.

Cheers!
Logged