Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[GonoszTopi]

I don't know if there is any multiplatform way to do this...

Yes there is. In Linux and OSX for sure, and Win32 has "directory change notification" for ages.

Hm? I know that each OS has its own way to do it, but the question is, is there a multiplatform way (like wxDirectoryNotification, for example), or we have to implement it in PlatformSpecific? (in case we want to)

[lfroen]

There's nothing wrong in doing it per-platform. Just wanted to point out that you claim about "Even in Linux there isn't a way..." is wrong. Notification works starting from (IIRC) 2.6.13 kernel - good enough IMHO. OSX and Windows have it too and rest is irrelevant for this discussion.

[GonoszTopi]

Notification works starting from 2.6.13 kernel

That's exactly what I meant.

[greek]

I want to suggest the removal of the option that allows vertical toolbar orientation.
The reason is that vertical toolbars don't work on a mac: they overlap with part of the window and also they are drawn differently than the horizontal toolbar. Another reason is that the implementation is really incomplete: one cannot chose for example if the toolbar is to the right or to the left. Finally, given that the download list has 13 columns, cluttering along the horizontal space is out of question.
So this part of the gui is just some kind of wannabe feature which never made it to completion, it is associated with bugs and it complicates further the gui code.
I suggest that, as a part of restructuring the code, this functionality is removed until there is  a more general, elegant and correct way to implement it.

[Kry]

I don't think so. Vertical toobar looks and works like it should - if it fails on mac (or windows) is a wxWidgets bug, which should be addressed by them. Some people use vertical toolbar, and we shouldn't just remove that option because you feel it's incomplete.

[el1073]

I prefer vertical toolbar, also because if I use the orizontal toolbar during connection the window filcks and autoresizes, so why remove this option?

[greek]

That is not a good criterion. If the horizontal toolbar did not flicker, why not use that one? Also imagine that you are allowed to remove the text in the horizontal toolbar so that it is neater. The issue with the bloated gui is that its hard to make fixes (the code is messy). And logically speaking, instead of  having 10 incomplete features, why not just offer one that works well?

And giving every possible option to the user is not the ultimate goal: if this were the goal, the toolbar should be able to be positioned at the botton, on the right, diagonally, it should allow you to reposition its tool buttons, to eliminate some etc. Why aren't those options offered? If those options are not offered what is the problem with removing one more similar option? The toolbar orientation is not central to the function of amule, which is to download files, and simplifying the code helps identifying bugs and improving the relevant functinality.

I guess once an irrelevant feature enters the code base it is very difficult to remove it in the feature and I am sure developer's ego plays (an admittedly very understandable) role in that. It's kind of sad to think like this...

[wuischke]

Actually I want to allow removing the text at some point in the future, I even wrote myself a bug tracker entry about it.

In general I agree with you about features and the function of aMule. I also agree that our current GUI solution is at best suboptimal. And if I remember correctly who implemented this, then you're even right about the ego of said developer.

But I have to disagree about the horizontal/vertical toolbar thing. In fact, I see no reason to do so. Doesn't work well on Mac? Don't enable it. Are there people using it? Obviously yes. Does it do any harm? (I assume you've seen the code to enable this.) I don't think so. - So, why remove it?

Oh - it's more of a limitation of wx and Carbon than a problem with aMule if vertical toolbar display is not so good, btw. There's little we can do about it. It looks OK with GTK2, though.

[GonoszTopi]

[...] the toolbar should be able to be positioned at the botton, on the right, diagonally, it should allow you to reposition its tool buttons, to eliminate some etc. Why aren't those options offered?

Because non of the developers had time/felt like implementing those? You're very welcome to implement said features.

The toolbar orientation is not central to the function of amule, which is to download files, and simplifying the code helps identifying bugs and improving the relevant functinality.

Let me follow the idea: We should start removing amuled and amulegui code from the code base, that would make code a lot cleaner. Actually I'd drop support for wxMac and wxMSW, I don't use them and they just make the code ugly and introduce bugs. Now, getting rid of 90% of the bugs so simply, we can focus on creating a better client.

Seriously, the feature IS useful for some people, makes no harm and you're not enforced to use it. However, you're free to reorganize code, write correct unittests for code pieces, etc. and we'll be glad to have you around.

I think this topic has been discussed enough and we could move on to do something useful. For example, see the top of my post

[Kry]

And if I remember correctly who implemented this, then you're even right about the ego of said developer.

You're fired.

[greek]

The most amazing thing with the open source model, is that it works at all!