aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Author Topic: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?  (Read 3701 times)

dealcorn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 16
Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« on: September 09, 2010, 03:43:33 AM »

Release 2.2.2 contains a "Fix for packets being lost in EC communication." which was identified in post 41 of http://forum.aMule.org/index.php?topic=14876 as an error in line 691 of ECSocket.cpp.  The Debian Lenny stable repositories contain aMule 2.2.1.  Is there a way to apply this known bug fix to 2.2.1?  I observe that the source code for aMule 2.2.1 downloaded from SourceForge does not contain the file ECSocket.cpp.  How do I locate the 2.2.1 line of code to which the bug fix is applied?
Logged

^marcell^

  • Developer
  • Hero Member
  • *****
  • Karma: 28
  • Offline Offline
  • Posts: 524
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #1 on: September 09, 2010, 07:46:06 PM »

I observe that the source code for aMule 2.2.1 downloaded from SourceForge does not contain the file ECSocket.cpp.
Are you sure? Did you look in the "src/libs/ec/cpp" directory?
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #2 on: September 09, 2010, 08:46:35 PM »

You know that the current stable version is 2.2.6 ?
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

dealcorn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 16
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #3 on: September 10, 2010, 09:35:12 AM »

I do not think ECSocket.cpp is on my server because  "find / -name ECSocket.cpp" returns no results when run as root.  Also, Debian Lenny does not mount /src so there is no path "src/libs/ec/cpp".  But for symptoms associated with this specific bug, amule 2.2.1 does exactly what I want with surprisingly good production so I prefer to the fix the understood bug and retain 2.2.1 from Lenny stable.  AMule 2.2.6 is available from the Lenny testing and unstable repositories and will roll into stable in due course.  A mixed distribution with aMule 2.2.6 is an appealing fallback position if I can not sort out the preferred approach.
Logged

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #4 on: September 10, 2010, 09:51:10 PM »

You shouldn't try to apply patches to a software if you can't even find its source directory.  ::)

Anyway 2.2.1 and 2.2.2 are not supported here anymore.
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #5 on: September 10, 2010, 11:16:55 PM »

I do not think ECSocket.cpp is on my server because  "find / -name ECSocket.cpp" returns no results when run as root.  Also, Debian Lenny does not mount /src so there is no path "src/libs/ec/cpp".  But for symptoms associated with this specific bug, amule 2.2.1 does exactly what I want with surprisingly good production so I prefer to the fix the understood bug and retain 2.2.1 from Lenny stable.
Do you understand that for that you'll have to download the sources and compile 2.2.1 for yourself? (In which case, you could also compile 2.2.6 or any other version, you're already diverging from pure Lenny stable.)
Logged
concordia cum veritate

dealcorn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 16
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #6 on: September 11, 2010, 06:31:01 AM »

Yes, I understand that compilation is required, may pose it's own challenges, and would be a temporary deviation from Debian "pure" stable.  The desired not "pure" outcome is that amulegui can display search results and that downloads can be started, cancelled, or paused from amulegui.  There is a conceptual judgement call whether it is preferable to apply a bug fix to 2.2.1 versus upgrade to 2.2.6 and this is not an emotional issue to me.  As pointed out in an earlier post, 2.2.1 is not a current priority area.   If how to apply the bug fix to 2.2.1 buried in the archives somewhere and not not readily accessible, an upgrade to 2.2.6 is the path of least resistance. 
Logged

GonoszTopi

  • The current man in charge of most things.
  • Administrator
  • Hero Member
  • *****
  • Karma: 169
  • Offline Offline
  • Posts: 2685
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #7 on: September 11, 2010, 07:19:41 AM »

Well, you can get the sources from SourceForge.
Logged
concordia cum veritate

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #8 on: September 11, 2010, 10:57:33 PM »

But you know, that I have an repo for exactly that. With tested upgrade path when squeeze goes stable.
Logged
Homefucking is killing prostitution

Stu Redman

  • Administrator
  • Hero Member
  • *****
  • Karma: 214
  • Offline Offline
  • Posts: 3739
  • Engines screaming
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #9 on: September 12, 2010, 11:54:17 AM »

I had to look twice to recognize you. That's you?  :)
Logged
The image of mother goddess, lying dormant in the eyes of the dead, the sheaf of the corn is broken, end the harvest, throw the dead on the pyre -- Iron Maiden, Isle of Avalon

Vollstrecker

  • Administrator
  • Hero Member
  • *****
  • Karma: 67
  • Offline Offline
  • Posts: 1549
  • Unofficial Debian Packager
    • http://vollstreckernet.de
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #10 on: September 13, 2010, 08:41:07 PM »

That pretty guy is me. At least the most of time.
Logged
Homefucking is killing prostitution

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #11 on: September 13, 2010, 10:29:02 PM »

Skip the homoerotic banter, guys, we're talking debian packages here.
Logged

dealcorn

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 16
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #12 on: September 17, 2010, 12:23:36 PM »

My initial post related to a possible fix for my problem that the Search and Statistics pages did not work in amulegui 2.2.1 where amuled 2.2.1 was running on a separate server.  These versions are from the Debian Lenny stable repository.  However, when I installed amulegui 2.2.6+debian0-7 on an Ubuntu 10.4 distribution, amulegui worked fine going to the same amuled 2.2.1 server. This is a not recommended, temporary workaround, but today I have no problems and there is no need to touch the server.
« Last Edit: September 17, 2010, 12:30:30 PM by dealcorn »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Howto Apply 2.2.2 Bug Fix for ECSocket.cpp to 2.2.1?
« Reply #13 on: September 17, 2010, 07:38:59 PM »

2.2.6 client worked with a 2.2.1 server? Maybe it's time you also buy some lottery tickets. But, happy for you I guess.
Logged