aMule Forum

Please login or register.

Login with username, password and session length
Advanced search  

News:

We're back! (IN POG FORM)

Pages: [1] 2 3

Author Topic: Tab selection in Mac OS X  (Read 16723 times)

Typhoid

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
Tab selection in Mac OS X
« on: April 30, 2006, 09:12:18 AM »

aMule 2.1.1, Intel Mac Mini Duo, Mac OS 10.4.6

When there are multiple tabs in the Search section, selecting and right-clicking on tabs does not work properly.  When I right-click on a tab, it selects the tab that is to the left of the one that I right-clicked on.
So if there are multiple tabs and I right-click on the second tab, then the first tab is selected.  If I right-click on the third tab, then the second tab is selected, and so on.
« Last Edit: April 30, 2006, 09:13:25 AM by Typhoid »
Logged

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Re: Tab selection in Mac OS X
« Reply #1 on: April 30, 2006, 10:52:14 AM »

It seems I owe the wxWidgets folks an apology.  On other threads reporting this bug, I blamed it on them re-breaking something I fixed.  It turns out it was because they applied the fix I suggested -- their fix plus the workaround I put in our code doubled up and overcompensated.  I have submitted the fix to our code.  The next Mac release won't have this bug.

Thanks for you report.
Logged

Typhoid

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
Re: Tab selection in Mac OS X
« Reply #2 on: May 29, 2006, 11:45:57 AM »

I just installed version 2.1.2 universal binary for 10.4 Tiger, and it appears to still have the tab selection issue.
« Last Edit: May 29, 2006, 11:57:35 AM by Typhoid »
Logged

Kry

  • Ex-developer
  • Retired admin
  • Hero Member
  • *****
  • Karma: -665
  • Offline Offline
  • Posts: 5795
Re: Tab selection in Mac OS X
« Reply #3 on: May 29, 2006, 12:18:04 PM »

Ken is a liar obviously.
Logged

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Re: Tab selection in Mac OS X
« Reply #4 on: June 04, 2006, 09:15:05 AM »

Quote
Originally posted by Kry
Ken is a liar obviously.

Indeed.

Several things happened:
  • I committed to CVS but didn't merge to the release branch, so it didn't get into 2.1.2
  • My commit was broken, anyway
  • None of my fellow developers noticed either of the above, which makes it ALL THEIR FAULT! :]
  • Oddly, the compiler didn't complain about my broken code, either

I'll try to fix this later today.
Logged

Typhoid

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
Right-clicking tabs in Mac OS X: missing context menu
« Reply #5 on: June 28, 2006, 04:20:38 AM »

Quote
When there are multiple tabs in the Search section, selecting and right-clicking on tabs does not work properly. When I right-click on a tab, it selects the tab that is to the left of the one that I right-clicked on.
So if there are multiple tabs and I right-click on the second tab, then the first tab is selected. If I right-click on the third tab, then the second tab is selected, and so on.

I installed  amule 2.1.3 Universal Binary version for Mac OS Tiger, and right-clicking on a tab now highlights the correct tab.   But now the context menu is missing from the tabs.
« Last Edit: June 28, 2006, 04:24:09 AM by Typhoid »
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #6 on: June 28, 2006, 05:55:58 AM »

@Typhoid:
I merged your new thread with this existing one.

Seems really weird that the context menu is not showing and that the correct tab is selected. On my machine, the wrong tab is still selected in a current CVS build of aMule. So my suspicion is that your right-clicking somehow generates a left click. Could you try doing a control-click on a tab?
Logged
Current aMule CVS builds for OS X can be found here.

Typhoid

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 6
Re: Tab selection in Mac OS X
« Reply #7 on: June 29, 2006, 04:42:22 AM »

I tried both control-clicking and right clicking on a tab in the Search results.  In each case, the correct tab is selected but there is no context menu.  I am running Mac OS 10.4.6 on an Intel Mac Mini.
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #8 on: June 29, 2006, 04:53:22 AM »

Weird. Unfortunately I can't test this on 10.4, because my Tiger machine is on a network that filters ed2k packets. Could anybody else test the right-clicking on tabs with aMule 2.1.3 on 10.4?
Logged
Current aMule CVS builds for OS X can be found here.

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #9 on: June 30, 2006, 06:17:07 AM »

Ok, with current amule CVS on OS X 10.3 I can reproduce the problem (no context menu). In addition, right-click and contol-click don't even select a search tab. There is, however, no problem with the category tabs in the download window.

Looks like we are dealing with a truth challenged serial offender here... ;)
Logged
Current aMule CVS builds for OS X can be found here.

ken

  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 825
Re: Tab selection in Mac OS X
« Reply #10 on: July 02, 2006, 08:20:41 AM »

lionel, what wx are you using for these builds?  I think the problem lies there.  One of the checks I put into the source code checks for wx version 2.7.0 or better.  Now, obviously wx 2.7.0 hasn't been released, but the wx part of the fix is incorporated into wx-cvs and that's the version reflected there.  So, my check is appropriate for the wx that will be released as 2.7.0 (and any wx-cvs after a certain point).  However, if you're using a wx-cvs that's post-2.6.3 but not as recent as when the change was put into wx, you'll confuse the issue.  The check I put in the code has no way to distinguish wx-cvs before the fix from wx-cvs after.

Try with wx 2.6.3 and/or current wx-cvs and see if the problem persists.
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #11 on: July 02, 2006, 05:30:58 PM »

I am using wx cvs from early March for all aMule builds, because I have not been able to compile a working aMule with a more recent version of wx (see here). That version is, however, already identified as 2.7.0, but it is probably pre-fix then.

I am making another attempt at compiling aMule with current wx as we speak (last attempt was 6 weeks or so ago). Maybe they fixed the issue by now. If not, it would be great if one of you guys could take a look at it. :)
Logged
Current aMule CVS builds for OS X can be found here.

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #12 on: July 03, 2006, 01:28:53 AM »

Problem is gone as promised when using current wx CVS. :)
Logged
Current aMule CVS builds for OS X can be found here.

inapina

  • Approved Newbie
  • *
  • Karma: 0
  • Offline Offline
  • Posts: 8
OS 10.4.6 tabs bug
« Reply #13 on: July 07, 2006, 02:38:37 PM »

hi there,
 i run mac os 10.4.6 with amule 2.1.3. which i only recently started running (10 days ago, before i was running 2.0.1)
when i rightclick a tab nothing happens ( until 5 days ago i had the other problem, rightclicking selected the previous tab...),there appears to be no menu in the tabs anymore...!
i posted this question in another thread already(forum max OSX_tabs_bug) as a reply to someone with a similar question, i hope i'm not confusing anyone.....
any help is appreciated big time
Logged

lionel77

  • Provider of Mac builds, Forum Mod
  • Hero Member
  • *****
  • Karma: 4
  • Offline Offline
  • Posts: 1107
  • Mac OS X 10.4 (Power Mac G5)
Re: Tab selection in Mac OS X
« Reply #14 on: July 07, 2006, 07:06:22 PM »

Here's the problem:
In order for ken's tab fix to work, aMule needs to be built against a more recent version of wx CVS. Unfortunately, when aMule is built against recent wx CVS, it crashes reliably after a few minutes here.

So until someone fixes that issue in wx (*wink* *wink*), you won't be able to right-click on search tabs and close them. :(
Logged
Current aMule CVS builds for OS X can be found here.
Pages: [1] 2 3